Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: two methods in DataGovUkExport did not call new parent uploadTos3 #378

Merged
merged 1 commit into from
Oct 10, 2024
Merged

fix: two methods in DataGovUkExport did not call new parent uploadTos3 #378

merged 1 commit into from
Oct 10, 2024

Conversation

fibble
Copy link
Contributor

@fibble fibble commented Oct 10, 2024

Description

Fix to ensure all report type call the uploadToS3 method

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@fibble fibble requested review from ilindsay and a team as code owners October 10, 2024 09:48
@fibble fibble changed the title fix: Two methods in DataGovUkExport did not call new parent uploadTos3 fix: two methods in DataGovUkExport did not call new parent uploadTos3 Oct 10, 2024
@gabrielg2020 gabrielg2020 merged commit d4b8b9f into main Oct 10, 2024
19 of 20 checks passed
@gabrielg2020 gabrielg2020 deleted the hotfix-two-funcs-didnt-call-new-s3upload-method branch October 10, 2024 15:06
@github-actions github-actions bot mentioned this pull request Oct 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielg2020 gabrielg2020 gabrielg2020 approved these changes

@jerotire jerotire jerotire approved these changes

@ilindsay ilindsay Awaiting requested review from ilindsay ilindsay is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fibble @jerotire @gabrielg2020