Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add commitlint to enforce the Conventional Commits specification #8

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

JoshuaLicense
Copy link
Contributor

Description

Adds Commitlint to enforce conventional commits:

  • A GitHub Action workflow which will be responsible for checking all PR titles.
  • A Git Hook (via. Husky) which will be responsible for checking commit titles.

Related issue: https://dvsa.atlassian.net/browse/VOL-4966

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@JoshuaLicense JoshuaLicense self-assigned this Feb 9, 2024
@JoshuaLicense JoshuaLicense marked this pull request as draft February 9, 2024 10:34
@JoshuaLicense JoshuaLicense changed the title ci: add commitlint (workflow and hooks) broken Feb 9, 2024
@JoshuaLicense JoshuaLicense changed the title broken feat(unknown): test Feb 9, 2024
@JoshuaLicense JoshuaLicense changed the title feat(unknown): test ci: add commitlint (workflow and hooks) Feb 9, 2024
@JoshuaLicense JoshuaLicense changed the title ci: add commitlint (workflow and hooks) ci: add commitlint to enforce the Conventional Commits specification Feb 9, 2024
@JoshuaLicense JoshuaLicense marked this pull request as ready for review February 9, 2024 10:37
@JoshuaLicense JoshuaLicense merged commit be6a3c6 into main Feb 12, 2024
5 of 7 checks passed
@JoshuaLicense JoshuaLicense deleted the add-commitlint branch February 12, 2024 09:45
JoshuaLicense pushed a commit that referenced this pull request Jul 23, 2024
* chore(dependencies): bump govuk-frontend from v4.6.0 to v4.8.0

* chore(deps): Lock "govuk-frontend" dependency to version 4.8.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants