Streamlit to Dash #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisac
reviewed
Dec 21, 2024
There was a problem hiding this comment.
Looks great!
- When saving a problem (Save Input Data to File), it wasn't clear that it was saved in the input folder. A clarification or note in the readme might be good.
- Perhaps automatically add a
.txtfile ending to the stored inputs and solutions if not included in the filename? - I think it would feel more robust if the problem generation is disabled (i.e., the sliders are greyed out) while running. Otherwise it's easy to change the problem while getting a solution for the old, lost one. Same for disabling the results tab when generating a new problem.
- Is it possible to have the upload-problem-file browser open at the input folder directly?
demo_configs.py
Outdated
| "value": 50, | ||
| } | ||
|
|
||
| ADVANCED_SETTINGS = ["Color by Case ID"] |
There was a problem hiding this comment.
What can this be changed to? Maybe add a comment?
Co-authored-by: Theodor Isacsson <theodor@isacsson.ca>
I don't think this is possible |
thisac
reviewed
Dec 28, 2024
utils.py
Outdated
Comment on lines
418
to
419
| if len(input_filename.split(".")) < 2: | ||
| input_filename = input_filename + ".txt" |
There was a problem hiding this comment.
Should be OK to have filenames with dots in, no? This would cause an issue if there's a dot in the name.
I quite like using pathlib, which can be used quite nicely here: https://docs.python.org/3/library/pathlib.html#pathlib.PurePath.with_suffix, and also for joining and reading/writing files.
thisac
approved these changes
Dec 31, 2024
utils.py
Outdated
Comment on lines
418
to
428
| if input_filename is not None: | ||
| input_file = PurePath(input_filename) | ||
|
|
||
| input_string = f'# Max num of bins : {data["num_bins"]} \n' | ||
| input_string += (f'# Bin dimensions ' | ||
| f'(L * W * H): {data["bin_dimensions"][0]} ' | ||
| f'{data["bin_dimensions"][1]} ' | ||
| f'{data["bin_dimensions"][2]} \n \n') | ||
| input_string += tabulate([header, *[v for v in case_info]], | ||
| headers="firstrow", colalign='right') | ||
| if input_file.suffix != ".txt": | ||
| input_file = input_file.with_suffix('.txt') | ||
|
|
||
| if input_filename is not None: | ||
| full_file_path = os.path.join("input", input_filename) | ||
| f = open(full_file_path, "w") | ||
| f.write(input_string) | ||
| f.close() | ||
| input_folder = Path(__file__).parent / "input" | ||
| file_path = input_folder / input_file.name | ||
|
|
||
| with Path(file_path).open("w") as f: | ||
| f.write(input_string) |
There was a problem hiding this comment.
If you want to go all in on pathlib:
if input_filename:
file_path = "input" / Path(input_filename).with_suffix('.txt')
file_path.write_text(input_string)There's also Path.resolve() if the absolute path is required, but I don't think it's necessary here.
Co-authored-by: Theodor Isacsson <theodor@isacsson.ca>
k8culver
force-pushed
the
update/streamlit-to-dash
branch
from
b24d3f3 to
7f63250
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: It is expected for
test-osxto fail because this demo usesmip