Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/modify classes to adapt compound-splitter for use as a Lucene/Solr p... #1

Merged
merged 1 commit into from
Aug 16, 2013

Conversation

48lizards
Copy link
Contributor

I've made changes to allow the GermanCompoundSplitter to be used as a Solr TokenFilter at index and query time.

  • Added a GermanCompoundSplitterTokenFilterFactory class that can be specified in the schema.xml, and a GermanCompoundSplitterTokenFilter class with a decompose() method that calls GermanCompoundSplitter's split() method.
  • Updated the call to FST.findTargetArc() with an extra parameter for compatibility with Lucene 4.x.
  • Added slf4j logging, and replaced RuntimeExceptions with logging.

dweiss added a commit that referenced this pull request Aug 16, 2013
Add/modify classes to adapt compound-splitter for use as a Lucene/Solr p...
@dweiss dweiss merged commit ebaa47f into dweiss:master Aug 16, 2013
@dweiss
Copy link
Owner

dweiss commented Jan 24, 2014

Hi Jonathan. I will have to revert your commit because you introduced changes that make the code not compile cleanly (missing pom entries). If you're still interested in this, could you submit a patch that runs cleanly with:

mvn clean verify

and

mvn -Pfst

(as described in the README file). Thanks.

@48lizards
Copy link
Contributor Author

Hi David,

Yes, I can take a look at that this weekend.

Thanks,
Jon

On Friday, January 24, 2014, Dawid Weiss notifications@github.com wrote:

Hi Jonathan. I will have to revert your commit because you introduced
changes that make the code not compile cleanly (missing pom entries). If
you're still interested in this, could you submit a patch that runs cleanly
with:

mvn clean verify

and

mvn -Pfst

(as described in the README file). Thanks.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-33211865
.

@48lizards
Copy link
Contributor Author

Hi Dawid,

Haven't gotten a chance yet but haven't forgotten.

Thanks,
Jon

On Fri, Jan 24, 2014 at 7:06 AM, Jonathan Beller
beller.jonathan@gmail.comwrote:

Hi David,

Yes, I can take a look at that this weekend.

Thanks,
Jon

On Friday, January 24, 2014, Dawid Weiss notifications@github.com wrote:

Hi Jonathan. I will have to revert your commit because you introduced
changes that make the code not compile cleanly (missing pom entries). If
you're still interested in this, could you submit a patch that runs cleanly
with:

mvn clean verify

and

mvn -Pfst

(as described in the README file). Thanks.

Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-33211865
.

@dweiss
Copy link
Owner

dweiss commented Jan 30, 2014

No problem at all, Jon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants