Fix #90 and #71 at the expense of $element injection

[ipavlic]

If the controller is instantiated after compiling and linking, any directives included in the model template won't have access to controller input values.

For example, take a modal template which includes a foo directive, <foo bar="vm.inputValue"></foo>. If compile and link functions are executed first, then foo's controller is instantiated during before compilation.

However, since the modal controller is instantiated in code after the linking, the inputValue is undefined. This makes it impossible to use directives/components which require values from the modal controller.

[coveralls]

Coverage decreased (-1.8%) to 84.127% when pulling 5e168fe on ipavlic:master into 2c07464 on dwmkerr:master.

[coveralls]

Coverage decreased (-1.8%) to 84.127% when pulling 74f10c7 on ipavlic:master into 2c07464 on dwmkerr:master.

[sirLisko]

I can confirm that it solved my problem too.
I almost got crazy trying to understand what it was going on with my directive and luckily I found @ipavlic PR.

@dwmkerr can you please merge this PR?

Cheers!

[nenesitooo]

👍

[zaparka]

👍

[sirLisko]

Hey @ipavlic I found a little problem in your PR.
Basically the $element is not passed anymore.

app.controller('ExampleModalController', [
  '$scope', '$element', 'close',

I know it's a smaller issue than the one that is fixing but it could be useful to keep track also on this :)

[ipavlic]

@sirLisko Yes, that's why the commit message says "at the expense of $element injection"

[sirLisko]

@ipavlic my bad, I didn't read it properly 😅

[dwmkerr]

@ipavlic @sirLisko just to confirm, if this means that $element is not injected, then it will cause problems. In many cases people are using this library for bootstrap modals, so it is not uncommon to have functions which interact with the element, e.g:

$scope.cancel = function() {
    $element.modal('hide');
}

But I do see the issue and think that dropping element is still probably the better solution. Two questions though:

1. How are angular doing it? They don't have the binding issues but still inject $element.
2. What is the alternative if someone still needs the element in their controller (to support an easy migration path)

With respect to point 1, it might be that angular are not doing it in all cases (see angular/angular.js#6988).

If there seems to be no way around this and still have the element injected, we might just have to go ahead anyway and warn users that the API has changed.