Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: standardise icons #90

Merged
merged 6 commits into from
Apr 25, 2019
Merged

feat: standardise icons #90

merged 6 commits into from
Apr 25, 2019

Conversation

dwmkerr
Copy link
Owner

@dwmkerr dwmkerr commented Apr 25, 2019

This looks good - the icons seem pretty clean. Some issues:

  • Labelling instructions might be needed for adaptive icons
  • The 'caption' feature of the init command is no longer generating a caption which is readable
  • The 'caption' feature of the init command should caption the adaptive icon foreground

@codecov
Copy link

codecov bot commented Apr 25, 2019

Codecov Report

Merging #90 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   96.84%   96.84%           
=======================================
  Files          17       17           
  Lines         222      222           
=======================================
  Hits          215      215           
  Misses          7        7
Impacted Files Coverage Δ
src/init/init.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3423491...1f1edc6. Read the comment docs.

@dwmkerr dwmkerr merged commit 9c65dcf into master Apr 25, 2019
@dwmkerr dwmkerr deleted the feat/standardise-icons branch April 25, 2019 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant