Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: getaddrinfo ENOTFOUND #41

Closed
vitramir opened this issue Sep 13, 2019 · 5 comments
Closed

Error: getaddrinfo ENOTFOUND #41

vitramir opened this issue Sep 13, 2019 · 5 comments

Comments

@vitramir
Copy link

I use this package to wait mongodb deployment inside Kubernetes. Sometimes DNS records do not have time to create, then I receive error "Error: getaddrinfo ENOTFOUND".

Is it bug or feature?

I think wait-port should also wait while DNS record appears.

@dwmkerr
Copy link
Owner

dwmkerr commented Sep 23, 2019

Would a flag such as:

--wait-for-dns

Work for this? i.e. opt-in. Otherwise for people who simply type in the wrong address they'll have to wait for timeouts or check the output if there's an error.

WDYT?

@vitramir
Copy link
Author

vitramir commented Oct 1, 2019

I think that my use case with undefined dns record is not usual and the flag "--wait-for-dns" will be enough.
It would be great if someone could release an update with such functionality so as not to fork.

dwmkerr added a commit that referenced this issue Oct 3, 2019
Allows the user to wait even if the address cannot be resolved; useful
if you know you will have to wait for DNS records to be created. Closes #41
@dwmkerr dwmkerr closed this as completed in 31418c2 Oct 3, 2019
@dwmkerr
Copy link
Owner

dwmkerr commented Oct 3, 2019

Done! The latest version has the wait-for-dns flag - if this works for you as expected let me know and I will close the issue.

@dwmkerr dwmkerr reopened this Oct 3, 2019
@vitramir
Copy link
Author

vitramir commented Oct 9, 2019

It works! Awesome! Thank you!

@vitramir vitramir closed this as completed Oct 9, 2019
@dwmkerr
Copy link
Owner

dwmkerr commented Oct 10, 2019

Cool, glad it works and the tool as another potential valuable use now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants