Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add autoSelectFamily for happy eyeballs support #99

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

acmacalister
Copy link
Contributor

In some environments, waiting on localhost can cause it to pick either ipv6 or ipv4 which can cause issue with certain sets of software (namely Docker network bridges which are exposed on ipv4 only). That being said, Node add Happy Eyeball support in nodejs/node#44731, which was released in Node 18, the currently support LTS. This PR adds the autoSelectFamily option to support said environments. Let me know if you have any questions. Thanks!

npx wait-port 1132

@dwmkerr
Copy link
Owner

dwmkerr commented Sep 20, 2023

Looks great, thanks @acmacalister !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants