Skip to content

Commit

Permalink
ENH: Improved typing and docs for scatter plot (shap#3811)
Browse files Browse the repository at this point in the history
* WIP type hints for scatter

* Simplify axes handling

* Improve docs

* Fixup test plot dims

* Refactor out x_jitter

* Split out histogram

* Return axes if show=False

* Fixup typo

* Docs formatting fixes

* apply suggestion

Co-authored-by: Jeremy Goh <30731072+thatlittleboy@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Jeremy Goh <30731072+thatlittleboy@users.noreply.github.com>

* Updates from review

* Further PR suggestions

* Simplify the use of `ind` variable

* Better docs for `overlay` param

---------

Co-authored-by: Jeremy Goh <30731072+thatlittleboy@users.noreply.github.com>
  • Loading branch information
connortann and thatlittleboy authored Aug 25, 2024
1 parent 4fbaed8 commit e4e705a
Show file tree
Hide file tree
Showing 4 changed files with 224 additions and 232 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,4 @@ __pycache__
/tests/mnist_data
catboost_info
node_modules
mpl-results
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,6 @@ module = [
"shap.plots._benchmark",
"shap.plots._force_matplotlib",
"shap.plots._force",
"shap.plots._scatter.*",
"shap.plots._text",
"shap.plots._waterfall",
]
Expand Down
Loading

0 comments on commit e4e705a

Please sign in to comment.