Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow App Admin to see People (authenticated with their App) #122

Closed
5 tasks done
nelsonic opened this issue Sep 17, 2020 · 2 comments
Closed
5 tasks done

Allow App Admin to see People (authenticated with their App) #122

nelsonic opened this issue Sep 17, 2020 · 2 comments
Assignees
@nelsonic
Labels
discuss Share your constructive thoughts on how to make progress with this issue enhancement New feature or enhancement of existing functionality in-progress An issue or pull request that is being worked on by the assigned person T4h Time Estimate 4 Hours technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@nelsonic
Copy link
Member

nelsonic commented Sep 17, 2020 •
edited
Loading

At present only superadmin can view the people authenticated with auth.

image

image

Obviously this means that non-admin cannot see people in order to grant them roles #119
which kinda limits the functionality of RBAC for non-admin people ... 🤦

So we need to allow non-admin people to see the people who have authenticated with their app but not see the people who have authenticated with other apps. 💭

Todo

  • Add :app_id to login_logs table
  • Log which app a person authenticates for/with in login_logs table
  • Select people from this table based on the app_id
  • Display these people in the /people (index) view
  • Allow app_admin to view the /person/:id provided that person has authenticated with their app.
@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality T4h Time Estimate 4 Hours discuss Share your constructive thoughts on how to make progress with this issue technical A technical issue that requires understanding of the code, infrastructure or dependencies labels Sep 17, 2020
@nelsonic nelsonic self-assigned this Sep 17, 2020
@nelsonic nelsonic added the in-progress An issue or pull request that is being worked on by the assigned person label Sep 17, 2020
@nelsonic
Copy link
Member Author

Given that dwyl/smart-home-auth-server#26 will not be functional without this, I'm working on it now. ⏳

This was referenced Sep 19, 2020
Merged
Closed
nelsonic added a commit that referenced this issue Sep 25, 2020
@nelsonic
create scratch.sql to store working SQL queries for #122
f53bcf2
nelsonic added a commit that referenced this issue Sep 25, 2020
@nelsonic
[WiP] create SQL query (with joins) to get people data for #122
7cd1acc
nelsonic added a commit that referenced this issue Sep 25, 2020
@nelsonic
display list of people for all apps belonging to a given person #122
d19e8f2
nelsonic added a commit that referenced this issue Sep 25, 2020
@nelsonic
delete unused code! #122
e134541
nelsonic added a commit that referenced this issue Sep 25, 2020
@nelsonic
move get_list_of_people/1 from Log to People (duh) #122
6c04910
nelsonic added a commit that referenced this issue Sep 25, 2020
@nelsonic
allow any app admin to view the profile of a person who has authentic…
d38db44 
…ated with their app #122
@nelsonic
Copy link
Member Author

This feature is included in #123 🚀

nelsonic added a commit that referenced this issue Sep 25, 2020
@nelsonic
tidy up code after my own review #122
588763e
nelsonic added a commit that referenced this issue Sep 25, 2020
@nelsonic
add app_id to people/index (table) view #122
c95fb1c
nelsonic added a commit that referenced this issue Sep 25, 2020
@nelsonic
hyperlink app_id to apps/:id for #122
7f269b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nelsonic nelsonic

Labels
discuss Share your constructive thoughts on how to make progress with this issue enhancement New feature or enhancement of existing functionality in-progress An issue or pull request that is being worked on by the assigned person T4h Time Estimate 4 Hours technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nelsonic