-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR] Version 0.01 #2
Conversation
Added constants for supported hash functions. Added encoding function that uses varint encoding.
@nelsonic I don't know if you want to review this or not (probably the latter) but I'll wait for a tweet from you. This will be used for the I can publish the package myself but to transfer it to a |
Using `listEquals` that is enough in our case, since we are comparing first-level arrays (array of bytes) and not objects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LuchoTurtle the code for this package is looking good so far. 👌
But it's not awaiting-review
... ⏳
Where are the GitHub Actions for running Continuous Integration (CI) Tests? 🤷♂️
Please don't assign a PR to me unless you are certain you've done everything you can to prepare it for my review. Thanks. 🙏
@nelsonic fixed the README and added CI according to your feedback. The CI appears to not run until it is merged to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @LuchoTurtle 👌
Thanks for making the updates. 🧑💻
Let's try and ship this. 🤞
Addresses #1 but doesn't close it.
This is the initial version of the package. It offers encoding and decoding following the Multihash standards and it is fully tested (100%).
The README follows both Dart's guidelines and the structure of most of the Multihash repos, hence why it differs a wee from dwyl's.
Adding CI and badges ought to be added after merging this.