Fix README references to header #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Token may not have been read from a header. * Token may have been read from header other than Authorization.
Current coverage is 100% (diff: 100%)@@ master #190 diff @@
====================================
Files 2 2
Lines 85 85
Methods 0 0
Messages 0 0
Branches 0 0
====================================
Hits 85 85
Misses 0 0
Partials 0 0
|
| @@ -168,7 +168,7 @@ signature `function(decoded, callback)` where: | |||
| `validateFunc` which can be accessed via `request.plugins['hapi-auth-jwt2'].extraInfo` | |||
| - `validateFunc` - (***required***) the function which is run once the Token has been decoded with | |||
| signature `function(decoded, request, callback)` where: | |||
| - `decoded` - (***required***) is the ***decoded*** and ***verified*** JWT received from the client in **request.headers.authorization** | |||
| - `decoded` - (***required***) is the decoded and verified JWT received in the request | |||
There was a problem hiding this comment.
I prefer more detail than less here, but it should be self-explanatory... 👍
There was a problem hiding this comment.
Do you mean the change in styling, or removal of the request.headers.authorization reference, or both, make for less detail?
|
@jmm this is a great update. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authorization.