Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate tests from QUnit to Lab? #5

Closed
nelsonic opened this issue Jul 9, 2015 · 3 comments
Closed

Migrate tests from QUnit to Lab? #5

nelsonic opened this issue Jul 9, 2015 · 3 comments
Labels
enhancement help wanted question

Comments

@nelsonic
Copy link
Member

nelsonic commented Jul 9, 2015

Given that QUnit refuses to run all the tests in the /test directory ... see: http://stackoverflow.com/questions/31312650/how-to-run-several-qunit-node-js-test-files-using-a-single-command

We may be forced to migrate to using Lab ...

(Which isn't all that bad as its more Hapi.js focussed testing framework, which means this will be a more shareable tutorial ...)
nelsonic added a commit that referenced this issue Jul 9, 2015
@nelsonic
migrated tests to using Lab instead of QUnit. Not liking the intermit…
a47f876 
…tent failur ... #5
nelsonic added a commit that referenced this issue Jul 9, 2015
@nelsonic
pretty much ready to give up on Lab as test runner... :-( #5
7a4573b
@nelsonic
Copy link
Member Author

nelsonic commented Jul 9, 2015

lab-tests-pass-intermittently

lab-says-zero-fail-but-still-doesnt-pass

Pretty much ready to give up on Lab right now. I've tried re-working the tests but it still says i'm not getting coverage on the lines where I am clearly hitting multiple times!

@nelsonic
Copy link
Member Author

nelsonic commented Jul 9, 2015

Having a bit of headache getting Lab's (built in) Coverage Reporter to acknowledge that certain lines of code are being executed...
how-does-lab-think-this-line-is-not-bing-covered

redis_config-js-showing-lines-4-7

See discussion over on: hapijs/lab#401

@nelsonic nelsonic mentioned this issue Jul 12, 2015
Closed
@nelsonic
Copy link
Member Author

Given that we didn't get an answer on the Lab issue, we moved to Tape.
But ... I suspect Lab would now recognise the coverage if we were to move back to it...
If anyone wants to volunteer to convert the tests back to Lab we're happy to accept a pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nelsonic