Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Reorganizing and enhancing document #47

Merged
merged 10 commits into from
Jan 15, 2023
Merged

[PR] Reorganizing and enhancing document #47

merged 10 commits into from
Jan 15, 2023

Conversation

LuchoTurtle
Copy link
Member

closes #46

This PR will effectively reorganize the document, make it more structure and add sections that delve into more detail according to API design and best practices.

…ols. #46

The guide of design and tips for structuring an API correctly will be made on a second parter.
Only missing the documentation and performance testing sections.
@LuchoTurtle LuchoTurtle added enhancement New feature or enhancement of existing functionality in-progress An issue or pull request that is being worked on by the assigned person documentation Improvements or additions to documentation labels Dec 31, 2022
@LuchoTurtle LuchoTurtle self-assigned this Dec 31, 2022
@LuchoTurtle LuchoTurtle changed the title [PR] Reorganizing document and enhancing [PR] Reorganizing and enhancing document Dec 31, 2022
@LuchoTurtle
Copy link
Member Author

Took a little longer to delve deeper into versioning and adding best API practices/standardization.

I'm close to finishing this and will be done by Monday for sure. I want to give a comprehensive guide to documenting and doing stress/performance tests on APIs (still need to do more research for the best options).

Pruned links, added new ones and deleted resources that were outdated or outright 404'd.

@LuchoTurtle LuchoTurtle requested a review from nelsonic January 2, 2023 20:47
@LuchoTurtle LuchoTurtle assigned nelsonic and unassigned LuchoTurtle Jan 2, 2023
@LuchoTurtle LuchoTurtle added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Jan 2, 2023
@LuchoTurtle
Copy link
Member Author

The refactoring of the whole document should now be complete.

I tried to maintain the pre-existing content (it was impossible sometimes, a few links were 404) and added new content according to #46 .

I initially intended to add more but I think having sections concise is a much easier read.

Let me know if there is something missing/ if I should elaborate more in any topic.

@nelsonic
Copy link
Member

nelsonic commented Jan 3, 2023

Thanks @LuchoTurtle will go through this PR next. 👍

@nelsonic nelsonic mentioned this pull request Jan 3, 2023
3 tasks
@@ -1231,6 +1231,11 @@ Besides managing different collaboratively APIs,
creating Open API specifications,
documentation
and monitoring.
- [**Insomnia**](https://insomnia.rest/):
similar to Postman, it's a API platform
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
similar to Postman, it's a API platform
similar to Postman, but ***`Open Source`***, is an `App`

@nelsonic nelsonic added in-review Issue or pull request that is currently being reviewed by the assigned person and removed awaiting-review An issue or pull request that needs to be reviewed labels Jan 14, 2023
@nelsonic
Copy link
Member

Picking up the review on this now as I've seen a couple of links to this in https://github.com/dwyl/mvp/pull/263/files#r1070223004 and rather than having to update the link:

https://github.com/dwyl/learn-api-design/blob/revamp/README.md#show-meaningful-errors

Would be better if it linked directly to the main branch.

So this is my side quest for the next hour. 🧑‍💻 👀 ⏳

README.md Outdated
or Twitch's [`Twirp`](https://blog.twitch.tv/en/2018/01/16/twirp-a-sweet-new-rpc-framework-for-go-5f2febbf35f/)
use `gRPC` for internal communication between microservices.

In these services, as *millions* of calls are made per-day,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very long sentence.

image

Please avoid writing sentences with more than 25 words as it dramatically lowers readability.
The average person would totally lose track of what they are reading half way into reading this.
Not saying that the people reading this doc are "stupid", they obvs aren't!
It's a highly technical doc aimed at an educated audience.
But just so you get into the habit of improving the readability of your writing for all areas of your communication. Write shorter sentences. Thank me later. 👌

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LuchoTurtle thank you very much for taking the time to do this 2023 refresh/update! 🎉
Lots of great new info and good to get it re-read by someone with fresh eyes and enhanced! 🚀

Still a few things we can add - will open a new issue - but this is an excellent update. Thanks again! 🙏

@nelsonic nelsonic merged commit 5106f12 into main Jan 15, 2023
@nelsonic nelsonic deleted the revamp branch January 15, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or enhancement of existing functionality in-review Issue or pull request that is currently being reviewed by the assigned person
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Enhance: Update + Section on Perf Testing
2 participants