-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add capture endpoint #22
Conversation
@@ -1,3 +1,3 @@ | |||
/* This file is for your main application css. */ | |||
|
|||
@import "./phoenix.css"; | |||
@import "./tachyons.css"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -25,6 +25,12 @@ defmodule AppWeb.Router do | |||
resources "/status", StatusController | |||
resources "/tags", TagController | |||
resources "/timers", TimerController | |||
|
|||
# capture | |||
resources "/capture", CaptureController, only: [:new, :create] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding this. 👍
it has reminded me of what we want the default
route to be ...
dwyl/app#246
(detail will be added ahead of "Sprint 1" next week)
|
||
def change do | ||
alter table(:items) do | ||
modify :text, :text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
describe "new capture" do | ||
test "renders form", %{conn: conn} do | ||
conn = get(conn, Routes.capture_path(conn, :new)) | ||
assert html_response(conn, 200) =~ "Capture" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test is fine for now.
we will search for the placeholder text in a future iteration. 👍
@@ -3,6 +3,6 @@ defmodule AppWeb.PageControllerTest do | |||
|
|||
test "GET /", %{conn: conn} do | |||
conn = get(conn, "/") | |||
assert html_response(conn, 200) =~ "Welcome to Phoenix!" | |||
assert html_response(conn, 200) =~ "Empower people to maximise effectiveness, creativity and happiness" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @SimonLab 🎉
ref: dwyl/app#234