Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add capture endpoint #22

Merged
merged 3 commits into from
Nov 15, 2019
Merged

add capture endpoint #22

merged 3 commits into from
Nov 15, 2019

Conversation

SimonLab
Copy link
Member

@SimonLab SimonLab commented Nov 14, 2019

@SimonLab SimonLab added the in-progress An issue or pull request that is being worked on by the assigned person label Nov 14, 2019
@SimonLab SimonLab self-assigned this Nov 14, 2019
@@ -1,3 +1,3 @@
/* This file is for your main application css. */

@import "./phoenix.css";
@import "./tachyons.css";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab SimonLab requested a review from nelsonic November 15, 2019 15:36
@SimonLab SimonLab assigned nelsonic and unassigned SimonLab Nov 15, 2019
@SimonLab SimonLab added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Nov 15, 2019
@nelsonic nelsonic temporarily deployed to production-capture-234-rgu3ngb November 15, 2019 15:56 Inactive
@nelsonic nelsonic added in-review Issue or pull request that is currently being reviewed by the assigned person and removed awaiting-review An issue or pull request that needs to be reviewed labels Nov 15, 2019
@@ -25,6 +25,12 @@ defmodule AppWeb.Router do
resources "/status", StatusController
resources "/tags", TagController
resources "/timers", TimerController

# capture
resources "/capture", CaptureController, only: [:new, :create]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this. 👍
it has reminded me of what we want the default route to be ...
dwyl/app#246
(detail will be added ahead of "Sprint 1" next week)


def change do
alter table(:items) do
modify :text, :text
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

describe "new capture" do
test "renders form", %{conn: conn} do
conn = get(conn, Routes.capture_path(conn, :new))
assert html_response(conn, 200) =~ "Capture"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test is fine for now.
we will search for the placeholder text in a future iteration. 👍

@@ -3,6 +3,6 @@ defmodule AppWeb.PageControllerTest do

test "GET /", %{conn: conn} do
conn = get(conn, "/")
assert html_response(conn, 200) =~ "Welcome to Phoenix!"
assert html_response(conn, 200) =~ "Empower people to maximise effectiveness, creativity and happiness"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @SimonLab 🎉

@nelsonic nelsonic merged commit dd80553 into master Nov 15, 2019
@nelsonic nelsonic deleted the capture-#234 branch November 15, 2019 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-review Issue or pull request that is currently being reviewed by the assigned person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants