Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google auth review suggestions #43

Merged
merged 2 commits into from
Dec 11, 2019
Merged

Google auth review suggestions #43

merged 2 commits into from
Dec 11, 2019

Conversation

SimonLab
Copy link
Member

Add suggestions from @nelsonic review on PR #24

@nelsonic nelsonic temporarily deployed to production-google-auth-x9uvkvd December 11, 2019 15:57 Inactive
@SimonLab SimonLab requested a review from nelsonic December 11, 2019 16:01
@SimonLab SimonLab added the awaiting-review An issue or pull request that needs to be reviewed label Dec 11, 2019
nelsonic
nelsonic approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab updates look good. thanks! 👍

@nelsonic nelsonic merged commit 15b3565 into master Dec 11, 2019
@nelsonic nelsonic deleted the google-auth-review-suggestions-#247 branch December 11, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonic nelsonic nelsonic approved these changes

Assignees

@nelsonic nelsonic

Labels
awaiting-review An issue or pull request that needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonLab @nelsonic