Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth! #37

Closed
4 tasks done
Tracked by #56
nelsonic opened this issue May 29, 2020 · 4 comments
Closed
4 tasks done
Tracked by #56

Auth! #37

nelsonic opened this issue May 29, 2020 · 4 comments
Assignees
@LuchoTurtle
Labels
enhancement priority-2 T4h technical

Comments

@nelsonic
Copy link
Member

nelsonic commented May 29, 2020 •
edited by LuchoTurtle
Loading

todo
@nelsonic nelsonic self-assigned this May 29, 2020
@nelsonic nelsonic mentioned this issue Nov 29, 2022
Closed
8 tasks
@nelsonic nelsonic assigned LuchoTurtle and unassigned nelsonic Nov 29, 2022
@nelsonic nelsonic pinned this issue Dec 2, 2022
@nelsonic
Copy link
Member Author

nelsonic commented Dec 9, 2022

@LuchoTurtle are you looking at this next? 💭

@LuchoTurtle
Copy link
Member

I am, just trying to fix some tests that broke
Quite a few of them :/

LuchoTurtle added a commit that referenced this issue Dec 9, 2022
@LuchoTurtle
feat: Adding auth_plug. #37
5a4ef91
LuchoTurtle added a commit that referenced this issue Dec 9, 2022
@LuchoTurtle
feat: Adding button to login and logout. #37
782cc8a
LuchoTurtle added a commit that referenced this issue Dec 9, 2022
@LuchoTurtle
feat: Saving person_email and fetching items according to auth info. #37
d32c90d
LuchoTurtle added a commit that referenced this issue Dec 9, 2022
@LuchoTurtle
feat: Making buttons better. Removing unnecessary code. #37
558b07d
@LuchoTurtle LuchoTurtle mentioned this issue Dec 9, 2022
Merged
3 tasks
LuchoTurtle added a commit that referenced this issue Dec 9, 2022
@LuchoTurtle
fix: Fixing tests. #37
1b11c5f
LuchoTurtle added a commit that referenced this issue Dec 9, 2022
@LuchoTurtle
feat: Adding authentication documentation. #37
5942cda
@LuchoTurtle
Copy link
Member

@nelsonic this should be ready for review. The PR has been already pushed for review 👍

LuchoTurtle added a commit that referenced this issue Dec 9, 2022
@LuchoTurtle
feat: Adding test passing detail to auth.md. #37
5b05693
LuchoTurtle added a commit that referenced this issue Dec 9, 2022
@LuchoTurtle
fix: Changing person_email to person_id. Optional route shows public …
c9cb631 
…items. #37
LuchoTurtle added a commit that referenced this issue Dec 9, 2022
@LuchoTurtle
fix: Fixing tests. #37
ade66af
LuchoTurtle added a commit that referenced this issue Dec 9, 2022
@LuchoTurtle
fix: Fixing auth file with latest changes. #37
180ed34
LuchoTurtle added a commit that referenced this issue Dec 9, 2022
@LuchoTurtle
fix: Fixing mix.exs. #37
c677d3a
LuchoTurtle added a commit that referenced this issue Dec 9, 2022
@LuchoTurtle
fix: Formatting files. #37
103bda6
LuchoTurtle added a commit that referenced this issue Dec 12, 2022
@LuchoTurtle
fix: Fixing router matching issues with filter. #37
84fb175 
Fixing "this clause cannot match because a previous clause at line 1 always matches" error.
LuchoTurtle added a commit that referenced this issue Dec 12, 2022
@LuchoTurtle
feat: Adding test for clearing completed items. #37
21b5d7a
LuchoTurtle added a commit that referenced this issue Dec 12, 2022
@LuchoTurtle
feat: Adding readme with tests. #37
7e957db
@nelsonic
Copy link
Member Author

Please ensure the tests pass and have 100% coverage. 🙏

LuchoTurtle added a commit that referenced this issue Dec 13, 2022
@LuchoTurtle
feat: Adding tests and making changes to README to reflect these. #37
0c12a6b
LuchoTurtle added a commit that referenced this issue Dec 13, 2022
@LuchoTurtle
fix: Updating README permalinks. #37
d7f5ca3
LuchoTurtle added a commit that referenced this issue Dec 13, 2022
@LuchoTurtle
fix: Updating mix.lock. #37
8336e4b
nelsonic added a commit that referenced this issue Dec 20, 2022
@nelsonic
create .env_sample for auth see: #56 #37
4238996
nelsonic added a commit that referenced this issue Dec 20, 2022
@nelsonic
remove unused code/variables to avoid warnings #56 #37
1ac2772
nelsonic added a commit that referenced this issue Dec 27, 2022
@nelsonic
simplify code in auth.md #37
66a60fa
nelsonic added a commit that referenced this issue Dec 27, 2022
@nelsonic
mix format #37
683f3ab
nelsonic added a commit that referenced this issue Dec 27, 2022
@nelsonic
move login/logout buttons to top (header) for #37
06170ba
LuchoTurtle added a commit that referenced this issue Dec 28, 2022
@LuchoTurtle
fix: Fixing compile issues and tests. #37
048bf29
LuchoTurtle added a commit that referenced this issue Dec 28, 2022
@LuchoTurtle
fix: Running mix format. #37
bc84770
LuchoTurtle added a commit that referenced this issue Dec 28, 2022
@LuchoTurtle
fix: Removing swoosh and unused variable warnings. #37
f4316b0
@nelsonic nelsonic unpinned this issue Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LuchoTurtle LuchoTurtle

Labels
enhancement priority-2 T4h technical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nelsonic @LuchoTurtle