Adds Github section to style guide #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nelsonic Please take a look and make any amendments 😊 Thanks! |
|
|
||
| ###Pull Requests | ||
| Good pull requests (PR) reduce the back and forth required between the person submitting the PR and the assigned reviewer, saving everyone time. | ||
| + Before submitting a PR, **open a new issue** so you can _confirm the need_ for the functionality you are intending to add (like in [this example](https://github.com/dshaw/env/issues/6)) |
There was a problem hiding this comment.
I prefer this PR: indexzero/ps-tree#12
There was a problem hiding this comment.
Changed to the correct issue 👍
|
Thanks @iteles |
nelsonic
added a commit
that referenced
this pull request
Aug 15, 2015
Adds Github section to style guide
Cleop
pushed a commit
that referenced
this pull request
May 25, 2017
Creates first draft of readme based on outline in issue #3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds sections on:
Fixes #2