Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The ps-tree package may be unsafe now. Better find an alternative. #35

Closed
haoqunjiang opened this issue Nov 26, 2018 · 2 comments · Fixed by #36
Closed

The ps-tree package may be unsafe now. Better find an alternative. #35

haoqunjiang opened this issue Nov 26, 2018 · 2 comments · Fixed by #36
Labels
help wanted

Comments

@haoqunjiang
Copy link

See:
indexzero/ps-tree#33
dominictarr/event-stream#116
@nelsonic
Copy link
Member

@sodatea thanks for opening this issue. 👍
we are aware of the ps-tree / event-stream issue.
Please keep in mind that terminate should not be used in "customer-facing" code.
We use it exclusively for "hot reloading" on or development machine.

@indexzero
Copy link

FYI ps-tree@1.1.1 locked to event-stream@3.3.4 (which if I read this thread correctly pre-dates the questionable changes).

Thanks to folks for bringing it to my attention: indexzero/ps-tree#34

@forestbelton forestbelton mentioned this issue Nov 26, 2018
Closed
nelsonic added a commit that referenced this issue Nov 26, 2018
@nelsonic
Update to latest ps-tree@1.1.1 fixes #35
4fe9f9e
@nelsonic nelsonic mentioned this issue Nov 26, 2018
Merged
nelsonic added a commit that referenced this issue Nov 26, 2018
@nelsonic
update version of ps-tree to latest (v1.1.1) for #35 thanks to @index…
1ad452a 
…zero for headsup closes #35
nelsonic added a commit that referenced this issue Nov 26, 2018
@nelsonic
update version of ps-tree to latest (v1.1.1) for #35
8f32123
nelsonic added a commit that referenced this issue Nov 26, 2018
@nelsonic
npm audit fix for #35
c219ea0
@virtuoushub virtuoushub mentioned this issue Nov 27, 2018
Closed
@kevinawoo kevinawoo mentioned this issue Nov 28, 2018
Merged
@sethidden sethidden mentioned this issue May 24, 2024
Closed
@sethidden sethidden mentioned this issue Jun 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to latest ps-tree@1.1.1 dwyl/terminate
3 participants
@indexzero @nelsonic @haoqunjiang