-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Chore) Get latest Rails versions #154
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pezholio
force-pushed
the
chore/get-latest-rails-versions
branch
from
May 17, 2024 16:00
589f240
to
4afbae2
Compare
Pull Request Test Coverage Report for Build 9131042083Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9130987734Details
💛 - Coveralls |
pezholio
force-pushed
the
chore/get-latest-rails-versions
branch
9 times, most recently
from
May 20, 2024 08:10
25b6567
to
d24c11a
Compare
pezholio
changed the title
Chore/get latest rails versions
(Chore) Get latest rRils versions
May 20, 2024
This ensures all matrix tests have passed, allowing us to add one required step for each workflow, rather than having to require a passing status for each individual Ruby / Rails version.
We call the Rubygems API and get the latest version for 5,6 and 7, then set those to the matrix values.
pezholio
force-pushed
the
chore/get-latest-rails-versions
branch
from
May 20, 2024 08:15
d24c11a
to
8b08e8f
Compare
pezholio
changed the title
(Chore) Get latest rRils versions
(Chore) Get latest Rails versions
May 20, 2024
mec
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 This is possibly as complicated as I would like to see the actions get in the spririt of keeping everyhing approachable at the cost of verbosity.
There is a \ No newline at end of file
here, might be worth checking your editor?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures we always run our integration tests against the latest minor / patch versions of Rails 5.x.x, 6.x.x and 7.x.x. Although Rails < 7 is not actively worked on, they still get patch updates (for security etc). I've also updated the unit tests and integration test actions to have a "Final results" step. This ensures all the Matrix tests have run successfully, so we don't have to require the status checks for each version to be up to date before merging:
Before
After