Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Chore) Get latest Rails versions #154

Merged
merged 3 commits into from
May 21, 2024
Merged

Conversation

pezholio
Copy link
Contributor

@pezholio pezholio commented May 17, 2024

This ensures we always run our integration tests against the latest minor / patch versions of Rails 5.x.x, 6.x.x and 7.x.x. Although Rails < 7 is not actively worked on, they still get patch updates (for security etc). I've also updated the unit tests and integration test actions to have a "Final results" step. This ensures all the Matrix tests have run successfully, so we don't have to require the status checks for each version to be up to date before merging:

Before

image

After

image

@pezholio pezholio force-pushed the chore/get-latest-rails-versions branch from 589f240 to 4afbae2 Compare May 17, 2024 16:00
@coveralls
Copy link

coveralls commented May 17, 2024

Pull Request Test Coverage Report for Build 9131042083

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9129513075: 0.0%
Covered Lines: 393
Relevant Lines: 393

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9130987734

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9129513075: 0.0%
Covered Lines: 393
Relevant Lines: 393

💛 - Coveralls

@pezholio pezholio force-pushed the chore/get-latest-rails-versions branch 9 times, most recently from 25b6567 to d24c11a Compare May 20, 2024 08:10
@pezholio pezholio changed the title Chore/get latest rails versions (Chore) Get latest rRils versions May 20, 2024
pezholio added 2 commits May 20, 2024 09:15
This ensures all matrix tests have passed, allowing us
to add one required step for each workflow, rather than
having to require a passing status for each individual
Ruby / Rails version.
We call the Rubygems API and get the latest version for
5,6 and 7, then set those to the matrix values.
@pezholio pezholio force-pushed the chore/get-latest-rails-versions branch from d24c11a to 8b08e8f Compare May 20, 2024 08:15
@pezholio pezholio marked this pull request as ready for review May 20, 2024 08:17
@pezholio pezholio changed the title (Chore) Get latest rRils versions (Chore) Get latest Rails versions May 20, 2024
@pezholio pezholio enabled auto-merge May 20, 2024 08:34
@pezholio pezholio requested a review from mec May 20, 2024 09:33
Copy link
Contributor

@mec mec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 This is possibly as complicated as I would like to see the actions get in the spririt of keeping everyhing approachable at the cost of verbosity.

There is a \ No newline at end of file here, might be worth checking your editor?

@pezholio pezholio merged commit 8524dcf into main May 21, 2024
18 checks passed
@pezholio pezholio deleted the chore/get-latest-rails-versions branch May 21, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants