Update Ruby for Rails 8 integration #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12318450626Details
💛 - Coveralls |
mec
force-pushed
the
chore/update-ruby-for-integration-tests
branch
6 times, most recently
from
2e6b2b4 to
cbfc706
Compare
We install the gem to run our integration tests. They recently started to fail and the issues seemed to be that bundler couldn't locate the branch. The branch name is supplied by `github.ref` switching to the logic here seems to have fixed this. `head_ref` for PRs with a fall back to `ref_name` if it is not a PR. Documentation: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs#github-context
Rails 8 is now showing up in our integration test matrix and only supports Ruby > 3.2. This work updates Ruby for these tests, we still run unit tests against older Ruby versions.
mec
force-pushed
the
chore/update-ruby-for-integration-tests
branch
from
cbfc706 to
6cf7e17
Compare
jdudley1123
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Rails 8 is out, it is showing up in our intergration test
matrix, but it only supports Ruby > 3.2.
This passes a build arg to use 3.2.6 in out integration tests.