Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dailymotion videos not working #1627

Closed
1 of 3 tasks
Kennsworth opened this issue Apr 6, 2024 · 4 comments · Fixed by #1670
Closed
1 of 3 tasks

Dailymotion videos not working #1627

Kennsworth opened this issue Apr 6, 2024 · 4 comments · Fixed by #1670
Labels
bug Something isn't working regression An intentional behavior that worked before does not work now service/dailymotion Improvements or additions to Dailymotion support

Comments

@Kennsworth
Copy link

Kennsworth commented Apr 6, 2024

Current Behavior

Black Screen when using daily motion video
https://dailymotion.com/video/x31i1so

Expected Behavior

video plays

Steps To Reproduce

  1. enter room
  2. select example daily motion video from list, https://dailymotion.com/video/x31i1so
  3. black screen

Environment

  • This happens on the official site, opentogethertube.com
  • This happens using a self-hosted version.
  • I'm using the docker image.

Anything else?

https://dailymotion.com/video/x31i1so
Google Chrome, Mac

@Kennsworth Kennsworth added bug Something isn't working uncomfirmed Bug has not yet been confirmed, do not start a fix. labels Apr 6, 2024
@dyc3 dyc3 added regression An intentional behavior that worked before does not work now and removed uncomfirmed Bug has not yet been confirmed, do not start a fix. labels Apr 6, 2024
@dyc3
Copy link
Owner

dyc3 commented Apr 6, 2024

Confirmed, can reproduce. It's been a while since I touched dailymotion, and this doesn't look like a particularly easy fix right now.

@dyc3 dyc3 added the service/dailymotion Improvements or additions to Dailymotion support label Apr 6, 2024
@dyc3
Copy link
Owner

dyc3 commented Apr 6, 2024

Yeah it turns out dailymotion completely changed their player API.

@dyc3
Copy link
Owner

dyc3 commented Apr 6, 2024

I've taken a closer look at it and made an attempt at fixing it in #1628. I don't think it will be possible to keep dailymotion support around.

The primary problem is that the new dailymotion player has regressed in it's capabilities. It is now completely impossible to set specific settings for the player like disabling the embed's controls, as these settings have been moved such that the owner of the video sets them in their web UI for Dailymotion Studio (which is not available outside of France). This also means that the player could behave very differently on a per video basis, so it would be really hard to get the player to provide a high quality user experience.

See the web sdk params: https://developers.dailymotion.com/player/#player-runtime-parameters
and the rest api params: https://developers.dailymotion.com/api/platform-api/reference/#player

@dyc3 dyc3 pinned this issue Apr 6, 2024
@dyc3
Copy link
Owner

dyc3 commented Apr 11, 2024

After reaching out to the Dailymotion support, they have no plans to address OTT's use case, as part of the missing functionality is a part of "Dailymotion Pro". I don't blame them for deprecating and disabling the old SDK, but it does mean that dailymotion support will need to be removed, at least temporarily as I figure out a more long term solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression An intentional behavior that worked before does not work now service/dailymotion Improvements or additions to Dailymotion support
Projects
None yet
2 participants