Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporarily remove broken dailymotion support #1670

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented Apr 11, 2024

Dailymotion has pulled official support for their old SDK, and as such, dailymotion videos no longer work. Support is being removed temporarily to not cause confusion for users.

closes #1627

Copy link
Owner Author

dyc3 commented Apr 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dyc3 and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 61.5010%. Comparing base (905ab60) to head (7ef2b9b).

Files Patch % Lines
client/src/locales/de.ts 0.0000% 1 Missing ⚠️
client/src/locales/es.ts 0.0000% 1 Missing ⚠️
client/src/locales/fr.ts 0.0000% 1 Missing ⚠️
client/src/locales/ru.ts 0.0000% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             master      #1670        +/-   ##
================================================
+ Coverage   61.3475%   61.5010%   +0.1535%     
================================================
  Files           170        168         -2     
  Lines         24904      24689       -215     
  Branches       1474       1451        -23     
================================================
- Hits          15278      15184        -94     
+ Misses         9570       9450       -120     
+ Partials         56         55         -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Apr 11, 2024

Passing run #1677 ↗︎

0 79 1 0 Flakiness 0

Details:

Merge 7ef2b9b into 905ab60...
Project: OpenTogetherTube Commit: 54bc42cafe ℹ️
Status: Passed Duration: 05:01 💡
Started: Apr 11, 2024 10:40 PM Ended: Apr 11, 2024 10:45 PM

Review all test suite changes for PR #1670 ↗︎

@dyc3 dyc3 changed the title remove broken dailymotion support temporarily remove broken dailymotion support Apr 11, 2024
@dyc3 dyc3 marked this pull request as ready for review April 11, 2024 22:51
@dyc3 dyc3 merged commit bf4d80c into master Apr 11, 2024
22 of 23 checks passed
@dyc3 dyc3 deleted the 04-11-remove_broken_dailymotion_support branch April 11, 2024 22:53
Copy link

cypress bot commented Apr 11, 2024

Passing run #1678 ↗︎

0 79 1 0 Flakiness 0

Details:

temporarily remove broken dailymotion support (#1670)
Project: OpenTogetherTube Commit: bf4d80c307
Status: Passed Duration: 05:00 💡
Started: Apr 11, 2024 10:54 PM Ended: Apr 11, 2024 10:59 PM

Review all test suite changes for PR #1670 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dailymotion videos not working
1 participant