Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP or SOCKS proxy support #177

Closed
feeops opened this issue Dec 10, 2022 · 2 comments · Fixed by #264
Closed

HTTP or SOCKS proxy support #177

feeops opened this issue Dec 10, 2022 · 2 comments · Fixed by #264
Labels
enhancement

Comments

@feeops
Copy link

feeops commented Dec 10, 2022

can you support http or socks proxy?
@dyc3 dyc3 changed the title can you support http or socks proxy? HTTP or SOCKS proxy support Dec 10, 2022
@dyc3
Copy link
Owner

dyc3 commented Dec 10, 2022

If you can come up with a use case that's not "avoiding Valve's rate limits" or "I have 3 billion steam accounts for some reason" I would be happy to accept contributions to add that.

Otherwise, I don't see how this is useful for anybody other than scammers and spammers, which is something I do not want to facilitate.

@feeops
Copy link
Author

feeops commented Dec 11, 2022

I am in China.China network block steam website.

If you can come up with a use case that's not "avoiding Valve's rate limits" or "I have 3 billion steam accounts for some reason" I would be happy to accept contributions to add that.

Otherwise, I don't see how this is useful for anybody other than scammers and spammers, which is something I do not want to facilitate.

I am in China.China ISP network block steam website.

@dyc3 dyc3 mentioned this issue Jul 2, 2023
Merged
@dyc3 dyc3 closed this as completed in #264 Jul 2, 2023
dyc3 added a commit that referenced this issue Jul 2, 2023
@dyc3
add HTTP proxy support (#264)
fe663cf 
- allow extracting the http client from web api transport
- refactor most commands so that they can accept an external transport
- update confirmer to use transport's http client
- update remove command
- update TwoFactorClient so it doesn't need to be mutable
- update get_server_time so it requires a transport
- update remove_authenticator
- update login proceedure to use given transport
- update usages of do_login
- update setup
- update trade
- update code command
- update qr-login command
- make borrowcheck happy
- make WebApiTransport Clone and remove Default impl
- remove dead code
- fix lints

closes #177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add HTTP proxy support dyc3/steamguard-cli
2 participants
@dyc3 @feeops