[OTE-777][OTE-690][OTE-688] Update clob code to add revshare logic (#…

…2251)

protocol/app/app.go

@@ -1130,6 +1130,7 @@ func New(
 		clobFlags,
 		rate_limit.NewPanicRateLimiter[sdk.Msg](),
 		daemonLiquidationInfo,
+		app.RevShareKeeper,
 	)
 	clobModule := clobmodule.NewAppModule(
 		appCodec,

protocol/indexer/events/order_fill.go

@@ -2,6 +2,7 @@ package events
 
 import (
 	"fmt"
+	"math/big"
 
 	v1 "github.com/dydxprotocol/v4-chain/protocol/indexer/protocol/v1"
 	clobtypes "github.com/dydxprotocol/v4-chain/protocol/x/clob/types"
@@ -19,6 +20,7 @@ func NewOrderFillEvent(
 	takerFee int64,
 	totalFilledMaker satypes.BaseQuantums,
 	totalFilledTaker satypes.BaseQuantums,
+	affiliateRevShareQuoteQuantums *big.Int,
 ) *OrderFillEventV1 {
 	indexerTakerOrder := v1.OrderToIndexerOrder(takerOrder)
 	return &OrderFillEventV1{
@@ -31,6 +33,8 @@ func NewOrderFillEvent(
 		TakerFee:         takerFee,
 		TotalFilledMaker: totalFilledMaker.ToUint64(),
 		TotalFilledTaker: totalFilledTaker.ToUint64(),
+		// Since revshare is always less than taker fee, this will not overflow.
+		AffiliateRevShare: affiliateRevShareQuoteQuantums.Uint64(),
 	}
 }
 
@@ -44,6 +48,7 @@ func NewLiquidationOrderFillEvent(
 	makerFee int64,
 	takerFee int64,
 	totalFilledMaker satypes.BaseQuantums,
+	affiliateRevShareQuoteQuantums *big.Int,
 ) *OrderFillEventV1 {
 	if !liquidationTakerOrder.IsLiquidation() {
 		panic(fmt.Sprintf("liquidationTakerOrder is not a liquidation order: %v", liquidationTakerOrder))
@@ -64,5 +69,7 @@ func NewLiquidationOrderFillEvent(
 		TakerFee:         takerFee,
 		TotalFilledMaker: totalFilledMaker.ToUint64(),
 		TotalFilledTaker: fillAmount.ToUint64(),
+		// Since revshare is always less than taker fee, this will not overflow.
+		AffiliateRevShare: affiliateRevShareQuoteQuantums.Uint64(),
 	}
 }

protocol/indexer/events/order_fill_test.go

@@ -1,6 +1,7 @@
 package events_test
 
 import (
+	"math/big"
 	"testing"
 
 	"github.com/dydxprotocol/v4-chain/protocol/indexer/events"
@@ -20,6 +21,7 @@ var (
 	fillAmount            = satypes.BaseQuantums(5)
 	makerFee              = int64(-2)
 	takerFee              = int64(5)
+	affiliateRevShare     = big.NewInt(0)
 )
 
 func TestNewOrderFillEvent_Success(t *testing.T) {
@@ -31,18 +33,20 @@ func TestNewOrderFillEvent_Success(t *testing.T) {
 		takerFee,
 		fillAmount,
 		fillAmount,
+		affiliateRevShare,
 	)
 
 	expectedOrderFillEventProto := &events.OrderFillEventV1{
 		MakerOrder: indexerMakerOrder,
 		TakerOrder: &events.OrderFillEventV1_Order{
 			Order: &indexerTakerOrder,
 		},
-		FillAmount:       fillAmount.ToUint64(),
-		MakerFee:         makerFee,
-		TakerFee:         takerFee,
-		TotalFilledMaker: fillAmount.ToUint64(),
-		TotalFilledTaker: fillAmount.ToUint64(),
+		FillAmount:        fillAmount.ToUint64(),
+		MakerFee:          makerFee,
+		TakerFee:          takerFee,
+		TotalFilledMaker:  fillAmount.ToUint64(),
+		TotalFilledTaker:  fillAmount.ToUint64(),
+		AffiliateRevShare: affiliateRevShare.Uint64(),
 	}
 	require.Equal(t, expectedOrderFillEventProto, orderFillEvent)
 }
@@ -56,6 +60,7 @@ func TestNewLiquidationOrderFillEvent_Success(t *testing.T) {
 		makerFee,
 		takerFee,
 		fillAmount,
+		affiliateRevShare,
 	)
 
 	expectedLiquidationOrder := events.LiquidationOrderV1{
@@ -71,11 +76,12 @@ func TestNewLiquidationOrderFillEvent_Success(t *testing.T) {
 		TakerOrder: &events.OrderFillEventV1_LiquidationOrder{
 			LiquidationOrder: &expectedLiquidationOrder,
 		},
-		FillAmount:       fillAmount.ToUint64(),
-		MakerFee:         makerFee,
-		TakerFee:         takerFee,
-		TotalFilledMaker: fillAmount.ToUint64(),
-		TotalFilledTaker: fillAmount.ToUint64(),
+		FillAmount:        fillAmount.ToUint64(),
+		MakerFee:          makerFee,
+		TakerFee:          takerFee,
+		TotalFilledMaker:  fillAmount.ToUint64(),
+		TotalFilledTaker:  fillAmount.ToUint64(),
+		AffiliateRevShare: affiliateRevShare.Uint64(),
 	}
 	require.Equal(t, expectedOrderFillEventProto, liquidationOrderFillEvent)
 }