[TRA-107] Add parentSubaccountNumber endpoint for historical-pnl #1476
Conversation
Signed-off-by: Shrenuj Bansal <shrenuj@dydx.exchange>
| SubaccountTable.findAll( | ||
| { | ||
| id: childSubaccountIds, | ||
| }, | ||
| [QueryableField.ID], | ||
| ), | ||
| PnlTicksTable.findAll( | ||
| { | ||
| subaccountId: childSubaccountIds, | ||
| limit, | ||
| createdBeforeOrAtBlockHeight: createdBeforeOrAtHeight | ||
| ? createdBeforeOrAtHeight.toString() | ||
| : undefined, | ||
| createdBeforeOrAt, | ||
| createdOnOrAfterBlockHeight: createdOnOrAfterHeight | ||
| ? createdOnOrAfterHeight.toString() | ||
| : undefined, | ||
| createdOnOrAfter, | ||
| }, | ||
| [QueryableField.LIMIT], | ||
| { | ||
| ...DEFAULT_POSTGRES_OPTIONS, | ||
| orderBy: [[QueryableField.BLOCK_HEIGHT, Ordering.DESC]], | ||
| }, | ||
| ), |
There was a problem hiding this comment.
don't you want the to pull both the childSubaccountIds and the parentSubaccountId? You're ignoring the parent now
There was a problem hiding this comment.
The childSubccountIds are inclusive. So parentSubaccountNumber 0 will have childSubaccountNumbers 0, 128, 256 , ...
There was a problem hiding this comment.
the documentation for getChildSubaccountId or getChildSubaccountNums doesn't seem to indicate that, could you update?
There was a problem hiding this comment.
It does?
Is there anything more you'd like to have specified?
| @@ -207,5 +207,65 @@ describe('pnlTicks-controller#V4', () => { | |||
| ], | |||
| }); | |||
| }); | |||
|
|
|||
| it('Get /historical-pnl/parentSubaccountNumber', async () => { | |||
There was a problem hiding this comment.
can you create a test to verify that this returns an aggregated pnl of child and parent subaccount?
There was a problem hiding this comment.
That is exactly what this test does. It aggregates the pnl for subaccounts 0 and 128 when parentSubaccountNumber 0 is requested
|
@Mergifyio backport release/indexer/v5.x |
✅ Backports have been created
|
Signed-off-by: Shrenuj Bansal <shrenuj@dydx.exchange> (cherry picked from commit eadfc82)
Changelist
Add parentSubaccountNumber endpoint for historical-pnl
Test Plan
Added tests
Author/Reviewer Checklist
state-breakinglabel.indexer-postgres-breakinglabel.PrepareProposalorProcessProposal, manually add the labelproposal-breaking.feature:[feature-name].backport/[branch-name].refactor,chore,bug.