Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change >=2 to >2 for stale pnl accounts #1704

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Change >=2 to >2 for stale pnl accounts #1704

merged 1 commit into from
Jun 17, 2024

Conversation

dydxwill
Copy link
Contributor

@dydxwill dydxwill commented Jun 17, 2024 •
edited by coderabbitai bot
Loading

Changelist

Change >= to > for stale pnl accounts

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

  • Bug Fixes
    • Adjusted the logic for handling transfers to ensure more accurate detection of stale transfer accounts.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 17, 2024 •
edited
Loading

Walkthrough

The change in the pnl-instrumentation.ts file updates the condition for checking the hours since the last transfer from >= 2 to > 2. This modification affects when subaccountId is pushed to staleTransferSubaccounts, potentially delaying some entries.

Changes

File Change Summary
indexer/services/roundtable/src/tasks/pnl-instrumentation.ts Updated condition for checking hours since last transfer from >= 2 to > 2

Poem

In the land of bits and bytes, so fair,
We tweak the code with utmost care.
Hours since last transfer, a subtle dance,
From >= 2 to > 2, we enhance.
To keep our metrics sharp and bright,
In the heart of digital night.
🌟🐇💻✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dydxwill dydxwill changed the title Change >= to > for stale pnl accounts Change >=2 to >2 for stale pnl accounts Jun 17, 2024
coderabbitai[bot]
coderabbitai bot reviewed Jun 17, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 31196d9 and ae0a7f2.

Files selected for processing (1)
  • indexer/services/roundtable/src/tasks/pnl-instrumentation.ts (1 hunks)
Additional comments not posted (2)
indexer/services/roundtable/src/tasks/pnl-instrumentation.ts (2)

Line range hint 1-1: The overall structure and logic of the function are well-implemented.

77-77: Change from >= to > correctly implemented to adjust the staleness threshold.

Verification successful

The change from >= 2 to > 2 for hoursSinceLastTransfer has been correctly identified and implemented. The search results confirm that the only occurrence of hoursSinceLastTransfer > 2 is in the file indexer/services/roundtable/src/tasks/pnl-instrumentation.ts. No other instances of hoursSinceLastTransfer >= 2 were found, indicating that the change is isolated and should not have unexpected side effects.

  • indexer/services/roundtable/src/tasks/pnl-instrumentation.ts: if (hoursSinceLastTransfer > 2)
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the impact of the threshold change on the behavior of the system.

# Test: Search for function calls that might be affected by this change. Expect: No unexpected side effects.
rg --type typescript $'hoursSinceLastTransfer > 2'

Length of output: 86

Script:

#!/bin/bash
# Description: Verify the impact of the threshold change on the behavior of the system.

# Correcting file type and searching for the pattern.
rg --type ts 'hoursSinceLastTransfer > 2'
rg --type ts 'hoursSinceLastTransfer >= 2'

Length of output: 187

@dydxwill dydxwill merged commit 2142cfa into main Jun 17, 2024
11 checks passed
@dydxwill dydxwill deleted the wl/pnl-tiny-fix branch June 17, 2024 17:40
@dydxwill
Copy link
Contributor Author

@Mergifyio backport release/indexer/v5.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 27, 2024 •
edited
Loading

backport release/indexer/v5.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 27, 2024
@dydxwill @mergify
Change >=2 to >2 for stale pnl accounts (#1704)
724772d 
(cherry picked from commit 2142cfa)
@mergify mergify bot mentioned this pull request Jun 27, 2024
Merged
6 tasks
dydxwill added a commit that referenced this pull request Jun 27, 2024
@mergify @dydxwill
Change >=2 to >2 for stale pnl accounts (backport #1704) (#1802)
8c41e95 
Co-authored-by: dydxwill <119354122+dydxwill@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@adamfraser adamfraser adamfraser approved these changes

Assignees
No one assigned
Labels
indexer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dydxwill @adamfraser