Sample onBatch stats

[dydxwill]

Changelist

Sample onBatch stats

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

• If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
• If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
• If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
• If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
• If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
• Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

• New Features
  • Improved monitoring by adding sampling rate configuration for message forwarding metrics (queue time, processing time, batch size).

[coderabbitai]

Walkthrough

The MessageForwarder class in message-forwarder.ts has been updated to include the config.MESSAGE_FORWARDER_STATSD_SAMPLE_RATE parameter in the stats.timing calls for logging metrics such as socks.batch_time_in_queue, socks.batch_processing_time, and socks.batch_size. This addition ensures that these timing metrics now respect the specified sampling rate for more accurate and controlled metric reporting.

Changes

File	Change Summary
indexer/services/socks/src/lib/message-forwarder.ts	Added parameter config.MESSAGE_FORWARDER_STATSD_SAMPLE_RATE to stats.timing calls for batch metrics.

Poem

In the land of code, where metrics gleam,
A forwarder danced in a developer's dream.
With timing precise and sampling set,
Batch stats now sparkle like a gem inset.
Forward, onward, metrics trace,
Enhancing performance, bringing grace.
🐇✨📊

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 41420ff and d572a11.

Files selected for processing (1)

• indexer/services/socks/src/lib/message-forwarder.ts (2 hunks)

Additional comments not posted (3)

indexer/services/socks/src/lib/message-forwarder.ts (3)

131-133: LGTM! Sampling rate addition is correct.

The inclusion of config.MESSAGE_FORWARDER_STATSD_SAMPLE_RATE in the stats.timing call ensures that the timing metric respects the specified sampling rate.

---

170-172: LGTM! Sampling rate addition is correct.

The inclusion of config.MESSAGE_FORWARDER_STATSD_SAMPLE_RATE in the stats.timing call ensures that the timing metric respects the specified sampling rate.

---

176-178: LGTM! Sampling rate addition is correct.

The inclusion of config.MESSAGE_FORWARDER_STATSD_SAMPLE_RATE in the stats.timing call ensures that the timing metric respects the specified sampling rate.

[dydxwill]

@Mergifyio backport release/indexer/v5.x

[mergify]

backport release/indexer/v5.x

✅ Backports have been created

• #1944 Sample onBatch stats (backport #1942) has been created for branch release/indexer/v5.x