[TRA-508] Require that market exists in market map when creating new oracle market #1960
Conversation
This reverts commit 90014f3.
WalkthroughThe recent updates significantly enhance the integration and functionality of the market map module within the application. Key changes include the introduction of a Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Outside diff range, codebase verification and nitpick comments (17)
protocol/x/prices/types/errors.go (2)
28-32: Add a comment to describe the new error.Adding a brief comment to describe the
ErrMarketPairConversionFailederror can enhance readability and maintainability.+ // ErrMarketPairConversionFailed indicates a failure in converting a market pair to a currency pair. ErrMarketPairConversionFailed = errorsmod.Register( ModuleName, 206, "Market pair conversion to currency pair failed", )
33-33: Add a comment to describe the new error.Adding a brief comment to describe the
ErrTickerNotFoundInMarketMaperror can enhance readability and maintainability.+ // ErrTickerNotFoundInMarketMap indicates that a ticker could not be located within the market map. ErrTickerNotFoundInMarketMap = errorsmod.Register(ModuleName, 207, "Ticker not found in market map")protocol/x/clob/keeper/msg_server_update_liquidations_config_test.go (1)
6-6: Revert unnecessary import movement.The movement of the import statement for the
libpackage is unnecessary and does not alter any functionality. It is better to keep the imports grouped logically.- "github.com/dydxprotocol/v4-chain/protocol/lib" govtypes "github.com/cosmos/cosmos-sdk/x/gov/types" "github.com/dydxprotocol/v4-chain/protocol/mocks" "github.com/dydxprotocol/v4-chain/protocol/testutil/constants" keepertest "github.com/dydxprotocol/v4-chain/protocol/testutil/keeper" "github.com/dydxprotocol/v4-chain/protocol/x/clob/keeper" "github.com/dydxprotocol/v4-chain/protocol/x/clob/memclob" "github.com/dydxprotocol/v4-chain/protocol/x/clob/types" "github.com/dydxprotocol/v4-chain/protocol/x/perpetuals" "github.com/dydxprotocol/v4-chain/protocol/x/prices" "github.com/stretchr/testify/require" + "github.com/dydxprotocol/v4-chain/protocol/lib"protocol/x/prices/keeper/keeper.go (2)
29-29: Add a comment to describe the new field.Adding a brief comment to describe the
MarketMapKeeperfield can enhance readability and maintainability.RevShareKeeper types.RevShareKeeper + // MarketMapKeeper manages the market map data. MarketMapKeeper types.MarketMapKeeper
43-43: Add a comment to describe the new parameter.Adding a brief comment to describe the
marketMapKeeperparameter can enhance readability and maintainability.revShareKeeper types.RevShareKeeper, + // marketMapKeeper manages the market map data. marketMapKeeper types.MarketMapKeeper,protocol/x/prices/genesis_test.go (3)
37-40: Ensure all instances ofPricesKeepersmatch the new signature.The following locations still use the old signature for
PricesKeepersand need to be updated to includemarketMapKeeper:
protocol/x/prices/module_test.goprotocol/x/prices/keeper/msg_server_create_oracle_market_test.goprotocol/x/prices/keeper/msg_server_update_market_param_test.goprotocol/x/prices/keeper/slinky_adapter_test.goprotocol/x/prices/keeper/market_price_test.goprotocol/x/prices/keeper/market_test.goprotocol/x/prices/keeper/update_price_test.goprotocol/x/prices/keeper/validate_market_price_updates_test.goprotocol/x/prices/keeper/grpc_query_market_test.goprotocol/x/prices/keeper/market_param_test.goprotocol/x/prices/keeper/keeper_test.goprotocol/x/prices/keeper/msg_server_update_market_prices_test.goprotocol/testutil/keeper/prices.goprotocol/app/process/transactions_test.goprotocol/app/process/process_proposal_test.goprotocol/app/prepare/prepare_proposal_test.goprotocol/app/process/full_node_process_proposal_test.goprotocol/app/process/market_prices_test.goPlease update these instances to ensure consistency with the new function signature.
Analysis chain
LGTM! But verify the function usage in the codebase.
The code changes are approved.
However, ensure that all function calls to
PricesKeepersmatch the new signature.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `PricesKeepers` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'PricesKeepers'Length of output: 28890
55-58: Ensure all function calls toPricesKeepersmatch the new signature.The following files contain calls to
PricesKeepersthat do not match the new signature and need to be updated:
protocol/x/prices/module_test.go: Line 1protocol/x/prices/keeper/keeper_test.go: Line 1protocol/x/prices/keeper/msg_server_update_market_prices_test.go: Lines 1, 2, 3, 4protocol/x/prices/keeper/market_test.go: Lines 1, 2, 3, 4protocol/x/prices/keeper/market_price_test.go: Lines 1, 2, 3, 4, 5protocol/x/prices/keeper/validate_market_price_updates_test.go: Lines 1, 2, 3, 4, 5protocol/x/prices/keeper/market_param_test.go: Lines 1, 2, 3, 4, 5protocol/x/prices/keeper/grpc_query_market_test.go: Lines 1, 2, 3, 4, 5protocol/x/prices/keeper/update_price_test.go: Line 1protocol/x/prices/keeper/msg_server_update_market_param_test.go: Line 1protocol/x/prices/keeper/slinky_adapter_test.go: Lines 1, 2, 3, 4, 5protocol/app/process/transactions_test.go: Lines 1, 2, 3, 4, 5protocol/app/process/market_prices_test.go: Lines 1, 2, 3protocol/app/process/process_proposal_test.go: Line 1protocol/app/process/full_node_process_proposal_test.go: Line 1protocol/app/prepare/prepare_proposal_test.go: Line 1Please update these instances to match the new signature, ensuring the
marketMapKeeperis included as the last parameter.Analysis chain
LGTM! But verify the function usage in the codebase.
The code changes are approved.
However, ensure that all function calls to
PricesKeepersmatch the new signature.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `PricesKeepers` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'PricesKeepers'Length of output: 28890
111-114: Ensure allPricesKeepersfunction calls match the new signature.The following occurrences of
PricesKeepersdo not match the new signature and need to be updated:
File:
protocol/x/prices/module_test.go
- Line: 1
- Current:
ctx, keeper, _, _, mockTimeProvider, _, _ := keeper.PricesKeepers(t)- Expected:
ctx, keeper, _, _, mockTimeProvider, _, marketMapKeeper := keeper.PricesKeepers(t)File:
protocol/x/prices/keeper/grpc_query_market_test.go
- Line: 1
- Current:
ctx, keeper, _, _, mockTimeProvider, _, _ := keepertest.PricesKeepers(t)- Expected:
ctx, keeper, _, _, mockTimeProvider, _, marketMapKeeper := keepertest.PricesKeepers(t)File:
protocol/x/prices/keeper/market_test.go
- Line: 1
- Current:
ctx, keeper, _, _, mockTimeProvider, _, _ := keepertest.PricesKeepers(t)- Expected:
ctx, keeper, _, _, mockTimeProvider, _, marketMapKeeper := keepertest.PricesKeepers(t)File:
protocol/x/prices/keeper/market_price_test.go
- Line: 1
- Current:
ctx, keeper, _, _, mockTimeProvider, _, _ := keepertest.PricesKeepers(t)- Expected:
ctx, keeper, _, _, mockTimeProvider, _, marketMapKeeper := keepertest.PricesKeepers(t)File:
protocol/x/prices/keeper/market_param_test.go
- Line: 1
- Current:
ctx, keeper, _, _, mockTimeProvider, _, _ := keepertest.PricesKeepers(t)- Expected:
ctx, keeper, _, _, mockTimeProvider, _, marketMapKeeper := keepertest.PricesKeepers(t)File:
protocol/x/prices/keeper/msg_server_update_market_prices_test.go
- Line: 1
- Current:
ctx, k, _, _, mockTimeKeeper, _, _ := keepertest.PricesKeepers(t)- Expected:
ctx, k, _, _, mockTimeKeeper, _, marketMapKeeper := keepertest.PricesKeepers(t)File:
protocol/x/prices/keeper/validate_market_price_updates_test.go
- Line: 1
- Current:
ctx, k, _, indexPriceCache, mockTimeProvider, _, _ := keepertest.PricesKeepers(t)- Expected:
ctx, k, _, indexPriceCache, mockTimeProvider, _, marketMapKeeper := keepertest.PricesKeepers(t)File:
protocol/app/prepare/prepare_proposal_test.go
- Line: 1
- Current:
ctx, _, _, _, _, _, _ := keepertest.PricesKeepers(t)- Expected:
ctx, _, _, _, _, _, marketMapKeeper := keepertest.PricesKeepers(t)File:
protocol/app/process/process_proposal_test.go
- Line: 1
- Current:
ctx, pricesKeeper, _, indexPriceCache, mockTimeProvider, _, _ := keepertest.PricesKeepers(t)- Expected:
ctx, pricesKeeper, _, indexPriceCache, mockTimeProvider, _, marketMapKeeper := keepertest.PricesKeepers(t)File:
protocol/app/process/transactions_test.go
- Line: 1
- Current:
ctx, pricesKeeper, _, _, _, _, _ := keepertest.PricesKeepers(t)- Expected:
ctx, pricesKeeper, _, _, _, _, marketMapKeeper := keepertest.PricesKeepers(t)File:
protocol/app/process/market_prices_test.go
- Line: 1
- Current:
ctx, k, _, _, _, _, _ := keepertest.PricesKeepers(t)- Expected:
ctx, k, _, _, _, _, marketMapKeeper := keepertest.PricesKeepers(t)Please update these occurrences to ensure consistency with the new function signature.
Analysis chain
LGTM! But verify the function usage in the codebase.
The code changes are approved.
However, ensure that all function calls to
PricesKeepersmatch the new signature.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `PricesKeepers` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'PricesKeepers'Length of output: 28890
protocol/x/prices/keeper/market_test.go (3)
171-171: Ensure all instances ofPricesKeepersincludemarketMapKeeperThe code changes are approved. However, some calls to
PricesKeepersdo not includemarketMapKeeper. Please update the following instances to match the new signature:
protocol/x/prices/module_test.goprotocol/x/prices/genesis_test.goprotocol/x/prices/keeper/grpc_query_market_test.goprotocol/x/prices/keeper/market_param_test.goprotocol/x/prices/keeper/market_price_test.goprotocol/x/prices/keeper/keeper_test.goprotocol/x/prices/keeper/msg_server_create_oracle_market_test.goprotocol/x/prices/keeper/msg_server_update_market_param_test.goprotocol/x/prices/keeper/msg_server_update_market_prices_test.goprotocol/app/process/process_proposal_test.goprotocol/app/process/transactions_test.goprotocol/app/prepare/prepare_proposal_test.goprotocol/app/process/market_prices_test.goprotocol/app/process/full_node_process_proposal_test.goAnalysis chain
LGTM! But verify the function usage in the codebase.
The code changes are approved.
However, ensure that all function calls to
PricesKeepersmatch the new signature.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `PricesKeepers` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'PricesKeepers'Length of output: 28890
18-18: UpdatePricesKeepersfunction calls to match the new signature.The following files contain calls to
PricesKeepersthat need to be updated to includemarketMapKeeper:
protocol/x/prices/module_test.goprotocol/x/prices/genesis_test.goprotocol/x/prices/keeper/grpc_query_market_test.goprotocol/x/prices/keeper/market_price_test.goprotocol/x/prices/keeper/msg_server_update_market_prices_test.goprotocol/x/prices/keeper/msg_server_create_oracle_market_test.goprotocol/x/prices/keeper/validate_market_price_updates_test.goprotocol/x/prices/keeper/slinky_adapter_test.goprotocol/x/prices/keeper/keeper_test.goprotocol/x/prices/keeper/market_test.goprotocol/x/prices/keeper/msg_server_update_market_param_test.goprotocol/x/prices/keeper/market_param_test.goprotocol/app/process/transactions_test.goprotocol/app/process/market_prices_test.goprotocol/app/process/process_proposal_test.goprotocol/app/process/full_node_process_proposal_test.goprotocol/app/prepare/prepare_proposal_test.goAnalysis chain
LGTM! But verify the function usage in the codebase.
The code changes are approved.
However, ensure that all function calls to
PricesKeepersmatch the new signature.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `PricesKeepers` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'PricesKeepers'Length of output: 28890
220-220: Ensure allPricesKeepersfunction calls match the new signature.The following files contain calls to
PricesKeepersthat do not match the new signature and need to be updated:
protocol/x/prices/module_test.goprotocol/x/prices/keeper/keeper_test.goprotocol/x/prices/keeper/market_param_test.goprotocol/x/prices/keeper/validate_market_price_updates_test.goprotocol/x/prices/keeper/update_price_test.goprotocol/x/prices/keeper/slinky_adapter_test.goprotocol/x/prices/keeper/msg_server_update_market_param_test.goprotocol/x/prices/keeper/msg_server_create_oracle_market_test.goprotocol/x/prices/keeper/market_test.goprotocol/x/prices/keeper/market_price_test.goprotocol/x/prices/keeper/grpc_query_market_test.goprotocol/x/prices/keeper/msg_server_update_market_prices_test.goprotocol/app/prepare/prepare_proposal_test.goprotocol/app/process/transactions_test.goprotocol/app/process/process_proposal_test.goprotocol/app/process/full_node_process_proposal_test.goprotocol/app/process/market_prices_test.goPlease ensure these files are updated to match the new
PricesKeepersfunction signature.Analysis chain
LGTM! But verify the function usage in the codebase.
The code changes are approved.
However, ensure that all function calls to
PricesKeepersmatch the new signature.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `PricesKeepers` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'PricesKeepers'Length of output: 28890
protocol/app/process/transactions_test.go (2)
111-111: Unused unpacked variable inTestDecodeProcessProposalTxs_Error.The additional variable unpacked from the
keepertest.PricesKeepersfunction call is not used in theTestDecodeProcessProposalTxs_Errorfunction. This should be corrected to either use the variable or modify the function call to only unpack the necessary variables.
protocol/app/process/transactions_test.goline 111Analysis chain
Ensure correct unpacking of additional variable.
Verify that the additional variable unpacked from the
keepertest.PricesKeepersfunction call is correctly handled.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correct unpacking of the additional variable from the `keepertest.PricesKeepers` function call. # Test: Search for the `PricesKeepers` function call within the `TestDecodeProcessProposalTxs_Error` function. Expect: Proper unpacking of the additional variable. rg --type go 'TestDecodeProcessProposalTxs_Error' -A 20Length of output: 1570
Script:
#!/bin/bash # Description: Verify the correct unpacking of the additional variable from the `keepertest.PricesKeepers` function call. # Test: Search for the `PricesKeepers` function call within the `transactions_test.go` file. Expect: Proper unpacking of the additional variable. rg --type go 'PricesKeepers' -A 20 protocol/app/process/transactions_test.goLength of output: 3386
191-191: Ensure correct unpacking of additional variable.The
marketMapKeepervariable is unpacked from thekeepertest.PricesKeepersfunction call but is not utilized within theTestDecodeProcessProposalTxs_Validfunction. This indicates that the additional variable is not correctly handled.
protocol/app/process/transactions_test.goline 191Analysis chain
Ensure correct unpacking of additional variable.
Verify that the additional variable unpacked from the
keepertest.PricesKeepersfunction call is correctly handled.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correct unpacking of the additional variable from the `keepertest.PricesKeepers` function call. # Test: Search for the `PricesKeepers` function call within the `TestDecodeProcessProposalTxs_Valid` function. Expect: Proper unpacking of the additional variable. rg --type go 'TestDecodeProcessProposalTxs_Valid' -A 20Length of output: 1613
Script:
#!/bin/bash # Description: Verify the correct unpacking of the additional variable from the `keepertest.PricesKeepers` function call. # Test: Search for the `PricesKeepers` function call within the `TestDecodeProcessProposalTxs_Valid` function. Expect: Proper unpacking of the additional variable. rg --type go 'TestDecodeProcessProposalTxs_Valid' -A 50Length of output: 3577
Script:
#!/bin/bash # Description: Verify the correct unpacking of the additional variable from the `keepertest.PricesKeepers` function call. # Test: Search for the `PricesKeepers` function call within the `TestDecodeProcessProposalTxs_Valid` function. Expect: Proper unpacking of the additional variable. rg --type go 'TestDecodeProcessProposalTxs_Valid' -A 100Length of output: 7383
Script:
#!/bin/bash # Description: Verify the definition of the `PricesKeepers` function to understand what variables it returns. # Test: Search for the definition of the `PricesKeepers` function. Expect: Proper unpacking of the additional variable. rg --type go 'func PricesKeepers' -A 20Length of output: 1511
Script:
#!/bin/bash # Description: Verify the usage of `marketMapKeeper` within the `TestDecodeProcessProposalTxs_Valid` function to ensure it is correctly handled. # Test: Search for the usage of `marketMapKeeper` within the `TestDecodeProcessProposalTxs_Valid` function. Expect: Proper handling of the additional variable. rg --type go 'marketMapKeeper' -A 20Length of output: 28469
protocol/testutil/app/app.go (1)
207-208: Update required: Handle new type inUpdateGenesisDocWithAppStateForModule.The
UpdateGenesisDocWithAppStateForModulefunction does not currently handle the new typemarketmapmoduletypes.GenesisState. Please update the switch statement in this function to include a case formarketmapmoduletypes.GenesisState.
protocol/testutil/app/app.go: Update the switch statement inUpdateGenesisDocWithAppStateForModuleto handlemarketmapmoduletypes.GenesisState.Analysis chain
LGTM! But verify the usage of the updated interface.
The addition of
marketmapmoduletypes.GenesisStateto theGenesisStatesinterface is appropriate and aligns with the PR objectives.However, ensure that all implementations and usages of the
GenesisStatesinterface are updated accordingly to handle the new type.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all usages of the updated GenesisStates interface. # Test: Search for the interface usage. Expect: Implementations and usages should handle the new type. rg --type go -A 5 $'type GenesisStates interface'Length of output: 392
Script:
#!/bin/bash # Description: Verify all implementations and usages of the updated GenesisStates interface. # Search for all implementations of the GenesisStates interface. rg --type go 'GenesisStates' -A 10 # Search for all usages of the GenesisStates interface. rg --type go 'GenesisStates'Length of output: 2794
Script:
#!/bin/bash # Description: Verify handling of the new type in UpdateGenesisDocWithAppStateForModule function and other relevant places. # Search for the UpdateGenesisDocWithAppStateForModule function implementation. rg --type go 'func UpdateGenesisDocWithAppStateForModule' -A 20 # Search for any other functions that use GenesisStates. rg --type go 'GenesisStates' -A 5Length of output: 2823
protocol/x/perpetuals/keeper/perpetual_test.go (3)
427-433: Use consistent indentation and spacing.Ensure consistent indentation and spacing for better readability and maintainability.
- _, err := keepertest.CreateTestMarket( - t, - pc.Ctx, - pc.PricesKeeper, - pricestypes.MarketParam{ - Id: 0, - Pair: "base-quote", - Exponent: -10, - MinExchanges: uint32(1), - MinPriceChangePpm: uint32(50), - ExchangeConfigJson: "{}", - }, - pricestypes.MarketPrice{ - Id: 0, - Exponent: -10, - Price: 1_000, // leave this as a placeholder b/c we cannot set the price to 0 - }, + _, err := keepertest.CreateTestMarket( + t, + pc.Ctx, + pc.PricesKeeper, + pricestypes.MarketParam{ + Id: 0, + Pair: "base-quote", + Exponent: -10, + MinExchanges: uint32(1), + MinPriceChangePpm: uint32(50), + ExchangeConfigJson: "{}", + }, + pricestypes.MarketPrice{ + Id: 0, + Exponent: -10, + Price: 1_000, // leave this as a placeholder b/c we cannot set the price to 0 + }, )
507-515: Use consistent indentation and spacing.Ensure consistent indentation and spacing for better readability and maintainability.
- _, err := keepertest.CreateTestMarket( - t, - pc.Ctx, - pc.PricesKeeper, - pricestypes.MarketParam{ - Id: 0, - Pair: "base-quote", - Exponent: -10, - MinExchanges: uint32(1), - MinPriceChangePpm: uint32(50), - ExchangeConfigJson: "{}", - }, - pricestypes.MarketPrice{ - Id: 0, - Exponent: -10, - Price: 1_000, // leave this as a placeholder b/c we cannot set the price to 0 - }, + _, err := keepertest.CreateTestMarket( + t, + pc.Ctx, + pc.PricesKeeper, + pricestypes.MarketParam{ + Id: 0, + Pair: "base-quote", + Exponent: -10, + MinExchanges: uint32(1), + MinPriceChangePpm: uint32(50), + ExchangeConfigJson: "{}", + }, + pricestypes.MarketPrice{ + Id: 0, + Exponent: -10, + Price: 1_000, // leave this as a placeholder b/c we cannot set the price to 0 + }, )
1072-1080: Use consistent indentation and spacing.Ensure consistent indentation and spacing for better readability and maintainability.
- _, err := keepertest.CreateTestMarket( - t, - pc.Ctx, - pc.PricesKeeper, - pricestypes.MarketParam{ - Id: marketId, - Pair: "base-quote", - Exponent: tc.exponent, - MinExchanges: uint32(1), - MinPriceChangePpm: uint32(50), - ExchangeConfigJson: "{}", - }, - pricestypes.MarketPrice{ - Id: marketId, - Exponent: tc.exponent, - Price: tc.price, - }, + _, err := keepertest.CreateTestMarket( + t, + pc.Ctx, + pc.PricesKeeper, + pricestypes.MarketParam{ + Id: marketId, + Pair: "base-quote", + Exponent: tc.exponent, + MinExchanges: uint32(1), + MinPriceChangePpm: uint32(50), + ExchangeConfigJson: "{}", + }, + pricestypes.MarketPrice{ + Id: marketId, + Exponent: tc.exponent, + Price: tc.price, + }, )
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (53)
- protocol/app/app.go (5 hunks)
- protocol/app/prepare/prepare_proposal_test.go (2 hunks)
- protocol/app/process/full_node_process_proposal_test.go (1 hunks)
- protocol/app/process/market_prices_test.go (3 hunks)
- protocol/app/process/process_proposal_test.go (1 hunks)
- protocol/app/process/transactions_test.go (4 hunks)
- protocol/testing/e2e/gov/add_new_market_test.go (6 hunks)
- protocol/testing/e2e/gov/perpetuals_test.go (2 hunks)
- protocol/testing/e2e/gov/prices_test.go (2 hunks)
- protocol/testutil/app/app.go (1 hunks)
- protocol/testutil/constants/marketmap.go (1 hunks)
- protocol/testutil/keeper/assets.go (1 hunks)
- protocol/testutil/keeper/clob.go (3 hunks)
- protocol/testutil/keeper/marketmap.go (1 hunks)
- protocol/testutil/keeper/perpetuals.go (4 hunks)
- protocol/testutil/keeper/prices.go (8 hunks)
- protocol/testutil/keeper/rewards.go (1 hunks)
- protocol/testutil/keeper/sending.go (1 hunks)
- protocol/testutil/keeper/subaccounts.go (1 hunks)
- protocol/testutil/prices/market_param_price.go (1 hunks)
- protocol/x/clob/genesis_test.go (1 hunks)
- protocol/x/clob/keeper/clob_pair_test.go (7 hunks)
- protocol/x/clob/keeper/get_price_premium_test.go (1 hunks)
- protocol/x/clob/keeper/grpc_query_mev_node_to_node_test.go (1 hunks)
- protocol/x/clob/keeper/liquidations_test.go (1 hunks)
- protocol/x/clob/keeper/msg_server_update_clob_pair_test.go (2 hunks)
- protocol/x/clob/keeper/msg_server_update_liquidations_config_test.go (2 hunks)
- protocol/x/clob/keeper/orders_test.go (8 hunks)
- protocol/x/clob/module_test.go (8 hunks)
- protocol/x/perpetuals/genesis_test.go (2 hunks)
- protocol/x/perpetuals/keeper/perpetual_test.go (9 hunks)
- protocol/x/perpetuals/lib/lib_test.go (12 hunks)
- protocol/x/perpetuals/module_test.go (2 hunks)
- protocol/x/prices/genesis_test.go (4 hunks)
- protocol/x/prices/keeper/grpc_query_market_test.go (4 hunks)
- protocol/x/prices/keeper/keeper.go (3 hunks)
- protocol/x/prices/keeper/keeper_test.go (1 hunks)
- protocol/x/prices/keeper/market.go (3 hunks)
- protocol/x/prices/keeper/market_param_test.go (8 hunks)
- protocol/x/prices/keeper/market_price_test.go (5 hunks)
- protocol/x/prices/keeper/market_test.go (6 hunks)
- protocol/x/prices/keeper/msg_server_create_oracle_market_test.go (4 hunks)
- protocol/x/prices/keeper/msg_server_update_market_param_test.go (1 hunks)
- protocol/x/prices/keeper/msg_server_update_market_prices_test.go (4 hunks)
- protocol/x/prices/keeper/slinky_adapter_test.go (4 hunks)
- protocol/x/prices/keeper/update_price_test.go (1 hunks)
- protocol/x/prices/keeper/validate_market_price_updates_test.go (4 hunks)
- protocol/x/prices/module.go (2 hunks)
- protocol/x/prices/module_test.go (5 hunks)
- protocol/x/prices/types/errors.go (1 hunks)
- protocol/x/prices/types/expected_keepers.go (2 hunks)
- protocol/x/rewards/keeper/keeper_test.go (2 hunks)
- protocol/x/subaccounts/keeper/subaccount_test.go (4 hunks)
Files skipped from review due to trivial changes (2)
- protocol/app/process/full_node_process_proposal_test.go
- protocol/x/prices/keeper/grpc_query_market_test.go
Additional comments not posted (149)
protocol/x/prices/keeper/keeper_test.go (1)
11-11: LGTM!The addition of the extra underscore to handle the new return value from
PricesKeepersis correct and does not affect the test logic.protocol/testutil/keeper/marketmap.go (1)
14-30: LGTM!The function
createMarketMapKeepercorrectly initializes and returns a market map keeper along with the store key.protocol/x/prices/types/expected_keepers.go (1)
33-38: LGTM!The
MarketMapKeeperinterface is well-defined with methods for interacting with market data, and it aligns with the requirements.protocol/x/clob/keeper/msg_server_update_liquidations_config_test.go (1)
59-59: LGTM!The addition of the
MarketMapKeeperinitialization line is appropriate and ensures that the necessary state is set up before the test runs.protocol/x/prices/keeper/keeper.go (1)
55-55: LGTM!The addition of the
MarketMapKeeperfield and the update to theNewKeeperfunction are appropriate and ensure that theKeepercan manage market data effectively.protocol/x/prices/keeper/slinky_adapter_test.go (4)
15-15: Verify the necessity of the additional return value.The additional return value from
PricesKeepersis not used in this test function. Ensure it is needed for future modifications or remove it to keep the code clean.
32-32: Verify the necessity of the additional return value.The additional return value from
PricesKeepersis not used in this test function. Ensure it is needed for future modifications or remove it to keep the code clean.
56-56: Verify the necessity of the additional return value.The additional return value from
PricesKeepersis not used in this test function. Ensure it is needed for future modifications or remove it to keep the code clean.
79-79: Verify the necessity of the additional return value.The additional return value from
PricesKeepersis not used in this test function. Ensure it is needed for future modifications or remove it to keep the code clean.protocol/testutil/prices/market_param_price.go (1)
70-77: Verify the correctness of the new JSON structure.The new
ExchangeConfigJsonstructure enhances functionality by including detailed exchange parameters. Ensure the JSON structure is correctly formatted and aligns with the expected schema.protocol/testutil/keeper/assets.go (1)
61-68: Verify the necessity of the newmarketMapKeeper.The new
marketMapKeeperis integrated into theAssetsKeepersfunction. Ensure it is necessary for the intended functionality and does not introduce errors.protocol/x/prices/genesis_test.go (1)
101-101: LGTM!The code changes are approved.
protocol/testutil/keeper/sending.go (1)
61-68: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
SendingKeepersWithSubaccountsKeepermatch the new signature.Verification successful
Verify the function signature of
SendingKeepersWithSubaccountsKeepermatches the new usage.The function
SendingKeepersWithSubaccountsKeeperis used inprotocol/x/sending/keeper/transfer_test.goand defined inprotocol/testutil/keeper/sending.go. Ensure that the function calls and definition match the new signature.
protocol/x/sending/keeper/transfer_test.go:
- Line 1:
ks := keepertest.SendingKeepersWithSubaccountsKeeper(t, mockSubaccountsKeeper)- Line 2:
ks := keepertest.SendingKeepersWithSubaccountsKeeper(t, mockSubaccountsKeeper)
protocol/testutil/keeper/sending.go:
- Line 1:
return SendingKeepersWithSubaccountsKeeper(t, nil)- Line 2:
func SendingKeepersWithSubaccountsKeeper(t testing.TB, saKeeper types.SubaccountsKeeper)Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `SendingKeepersWithSubaccountsKeeper` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'SendingKeepersWithSubaccountsKeeper'Length of output: 1643
protocol/testutil/keeper/rewards.go (1)
47-48: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
RewardsKeepersmatch the new signature.Verification successful
The function call to
RewardsKeepersinprotocol/x/rewards/module_test.gomatches the new signature.
- The function definition in
protocol/testutil/keeper/rewards.goincludes multiple return values, includingpricesKeeper.- The call in
protocol/x/rewards/module_test.gocorrectly captures these return values.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `RewardsKeepers` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go -A 5 $'RewardsKeepers'Length of output: 726
Script:
#!/bin/bash # Description: Extract more lines around the call to `keepertest.RewardsKeepers(t)` to verify it matches the new signature. # Extract 10 lines before and after the call to `keepertest.RewardsKeepers(t)`. rg --type go -B 10 -A 10 $'keepertest.RewardsKeepers(t)' protocol/x/rewards/module_test.goLength of output: 91
Script:
#!/bin/bash # Description: Extract more lines around the term `RewardsKeepers` to verify it matches the new signature. # Extract 20 lines before and after the term `RewardsKeepers`. rg --type go -B 20 -A 20 $'RewardsKeepers' protocol/x/rewards/module_test.goLength of output: 1427
Script:
#!/bin/bash # Description: Search for the `keepertest.RewardsKeepers` function definition to verify its parameters. # Search for the function definition of `RewardsKeepers`. rg --type go -A 10 'func RewardsKeepers'Length of output: 766
protocol/x/clob/keeper/grpc_query_mev_node_to_node_test.go (1)
22-23: LGTM! Ensure consistent initialization in other tests.The initialization of the market map using
InitGenesisis a good addition to ensure the market map is in a defined state before executing the test cases.Verify if other test files also require this initialization step for consistency.
Verification successful
LGTM! Ensure consistent initialization in other tests.
The initialization of the market map using
InitGenesisis a good addition to ensure the market map is in a defined state before executing the test cases. This step is consistently applied across various test files in the codebase.
- The
InitGenesismethod is used in multiple test files, including those in theclobmodule.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of `InitGenesis` in other test files. # Test: Search for the usage of `InitGenesis`. Expect: Consistent initialization across test files. rg --type go 'InitGenesis'Length of output: 24515
protocol/x/prices/keeper/msg_server_create_oracle_market_test.go (2)
118-126: LGTM! Ensure the validation of market state in other tests.The validation step that checks if the market is enabled in the MarketMap is a good addition to ensure the market's state is correctly reflected.
Verify if other test files also require this validation step for consistency.
Verification successful
Validation of market state is consistently applied in other test files.
The validation step that checks if the market is enabled in the MarketMap is present in multiple test files, ensuring consistency.
protocol/x/prices/keeper/msg_server_create_oracle_market_test.goprotocol/x/prices/keeper/market_test.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the validation of market state in other test files. # Test: Search for the validation of market state. Expect: Consistent validation across test files. rg --type go 'MarketPairToCurrencyPair'Length of output: 1995
Script:
#!/bin/bash # Description: Verify the validation of market state in other test files. # Test: Search for the validation of market state. Expect: Consistent validation across test files. rg --type go 'mmMarket.Ticker.Enabled'Length of output: 314
33-39: LGTM! Ensure consistent market initialization in other tests.The initialization of the market in the MarketMap using
CreateMarketInMarketMapFromParamsis a good addition to ensure the market is created before executing the test cases.Verify if other test files also require this initialization step for consistency.
Verification successful
LGTM! Ensure consistent market initialization in other tests.
The initialization of the market in the MarketMap using
CreateMarketInMarketMapFromParamsis consistently applied across the test files. This ensures that the market is created before executing the test cases, enhancing the accuracy and robustness of the tests.
protocol/x/prices/keeper/msg_server_create_oracle_market_test.goprotocol/x/prices/keeper/market_test.goprotocol/x/prices/module_test.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of `CreateMarketInMarketMapFromParams` in other test files. # Test: Search for the usage of `CreateMarketInMarketMapFromParams`. Expect: Consistent initialization across test files. rg --type go 'CreateMarketInMarketMapFromParams'Length of output: 627
Script:
#!/bin/bash # Extract relevant portions of market_test.go and module_test.go to verify the initialization step. # Extract lines around the usage of CreateMarketInMarketMapFromParams in market_test.go rg --type go --context 10 'CreateMarketInMarketMapFromParams' protocol/x/prices/keeper/market_test.go # Extract lines around the usage of CreateMarketInMarketMapFromParams in module_test.go rg --type go --context 10 'CreateMarketInMarketMapFromParams' protocol/x/prices/module_test.goLength of output: 1510
protocol/x/prices/keeper/update_price_test.go (1)
126-126: LGTM! Ensure consistent usage of the updatedPricesKeepersfunction.The changes to the
PricesKeepersfunction call are approved.Verify if other test files also use the updated
PricesKeepersfunction for consistency.Verification successful
LGTM! Ensure consistent usage of the updated
PricesKeepersfunction.The changes to the
PricesKeepersfunction call are approved. The usage of the updated function is consistent across the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of the updated `PricesKeepers` function in other test files. # Test: Search for the usage of `PricesKeepers`. Expect: Consistent usage across test files. rg --type go 'PricesKeepers'Length of output: 6539
Script:
#!/bin/bash # Description: Verify the usage of the updated `PricesKeepers` function in all test files with context. # Search for the usage of `PricesKeepers` and include surrounding lines for context. rg --type go 'PricesKeepers' -A 3 -B 3Length of output: 31767
protocol/testutil/keeper/subaccounts.go (2)
54-54: Initialization ofmarketMapKeeperlooks good.The
marketMapKeeperis initialized correctly following the existing pattern.
61-61: Integration ofmarketMapKeeperintocreatePricesKeeperlooks good.The
marketMapKeeperis correctly passed as an argument to thecreatePricesKeeperfunction.protocol/x/prices/keeper/market_price_test.go (6)
28-28: Addition of extra underscore inTestUpdateMarketPriceslooks good.The change suggests that the
keepertest.PricesKeepers(t)function now returns an additional value that is not used in this test function.
63-63: Addition of extra underscore inTestUpdateMarketPrices_NotFoundlooks good.The change suggests that the
keepertest.PricesKeepers(t)function now returns an additional value that is not used in this test function.
92-92: Addition of extra underscore inTestGetMarketPricelooks good.The change suggests that the
keepertest.PricesKeepers(t)function now returns an additional value that is not used in this test function.
107-107: Addition of extra underscore inTestGetMarketPrice_NotFoundlooks good.The change suggests that the
keepertest.PricesKeepers(t)function now returns an additional value that is not used in this test function.
113-113: Addition of extra underscore inTestGetAllMarketPriceslooks good.The change suggests that the
keepertest.PricesKeepers(t)function now returns an additional value that is not used in this test function.
129-129: Addition of extra underscore inTestGetMarketIdToValidIndexPricelooks good.The change suggests that the
keepertest.PricesKeepers(t)function now returns an additional value that is not used in this test function.protocol/x/prices/keeper/market.go (3)
51-66: Validation for market existence in market map looks good.The validation ensures that the market exists in the market map before proceeding with the creation process, maintaining the integrity of the market data.
78-78: Addition of currency pair tocurrencyPairIDCachelooks good.The currency pair is added to the cache following the existing pattern.
100-110: Enabling the market in the market map looks good.Enabling the market after creation ensures that the market is active and can be used. The error handling is crucial for logging any issues.
protocol/app/process/market_prices_test.go (3)
68-68: Verify the handling of the additional return value.The additional return value from
keepertest.PricesKeepers(t)is currently unused. Ensure that this value is correctly handled or explicitly ignored if not needed.
123-123: Verify the handling of the additional return value.The additional return value from
keepertest.PricesKeepers(t)is currently unused. Ensure that this value is correctly handled or explicitly ignored if not needed.
165-165: Verify the handling of the additional return value.The additional return value from
keepertest.PricesKeepers(t)is currently unused. Ensure that this value is correctly handled or explicitly ignored if not needed.protocol/testutil/constants/marketmap.go (4)
1-9: LGTM!The package declaration and imports are appropriate and necessary for the file's functionality.
11-17: LGTM!The global variables are correctly defined and initialized.
19-106: LGTM!The
MarketMap_DefaultGenesisStateis correctly defined and initialized with various market configurations.
107-107: LGTM!The file ends correctly with the closing brace of the
MarketMap_DefaultGenesisStatedefinition.protocol/x/prices/module.go (2)
104-108: LGTM!The
AppModulestructure has been correctly updated to include the newmarketMapKeeperfield.
117-125: LGTM!The
NewAppModuleconstructor function has been correctly updated to accept the newmarketMapKeeperparameter and initialize the corresponding field.protocol/x/prices/keeper/msg_server_update_market_param_test.go (2)
147-147: Update variable unpacking to match the new function signature.The
PricesKeepersfunction now returns an additional value, which is currently unused. Ensure that this change is consistent with the updated function signature.
150-150: Use of dedicated test utility function for market creation.The use of
keepertest.CreateTestMarketimproves the clarity and maintainability of the test code by encapsulating the market creation logic.protocol/x/perpetuals/genesis_test.go (4)
21-21: InitializemarketMapGenesisStatefor test setup.The initialization of
marketMapGenesisStateensures that the market map's genesis state is properly set up before running the tests, improving the test environment's fidelity.
26-26: InitializemarketMapGenesisStateinMarketMapKeeper.The
InitGenesismethod of theMarketMapKeeperis now called withmarketMapGenesisState, ensuring that the market map's genesis state is properly initialized.
126-126: InitializemarketMapGenesisStatefor test setup.The initialization of
marketMapGenesisStateensures that the market map's genesis state is properly set up before running the tests, improving the test environment's fidelity.
127-127: InitializemarketMapGenesisStateinMarketMapKeeper.The
InitGenesismethod of theMarketMapKeeperis now called withmarketMapGenesisState, ensuring that the market map's genesis state is properly initialized.protocol/x/prices/keeper/market_param_test.go (10)
19-19: Update variable unpacking to match the new function signature.The
PricesKeepersfunction now returns an additional value, which is currently unused. Ensure that this change is consistent with the updated function signature.
50-50: Update variable unpacking to match the new function signature.The
PricesKeepersfunction now returns an additional value, which is currently unused. Ensure that this change is consistent with the updated function signature.
59-59: AdjustExponentfield to -8.The
Exponentfield has been adjusted to -8, which may impact the logic governing market behavior. Ensure that this change is consistent with the intended functionality.
63-63: Use of dedicated test utility function for market creation.The use of
keepertest.CreateTestMarketimproves the clarity and maintainability of the test code by encapsulating the market creation logic.
65-65: AdjustExponentfield to -8.The
Exponentfield has been adjusted to -8, which may impact the logic governing market behavior. Ensure that this change is consistent with the intended functionality.
183-183: Update variable unpacking to match the new function signature.The
PricesKeepersfunction now returns an additional value, which is currently unused. Ensure that this change is consistent with the updated function signature.
192-192: AdjustExponentfield dynamically.The
Exponentfield is now dynamically calculated based on thetargetId, ensuring consistency with the creation of market parameters.
204-204: Update variable unpacking to match the new function signature.The
PricesKeepersfunction now returns an additional value, which is currently unused. Ensure that this change is consistent with the updated function signature.
219-219: Update variable unpacking to match the new function signature.The
PricesKeepersfunction now returns an additional value, which is currently unused. Ensure that this change is consistent with the updated function signature.
225-225: Update variable unpacking to match the new function signature.The
PricesKeepersfunction now returns an additional value, which is currently unused. Ensure that this change is consistent with the updated function signature.protocol/x/clob/keeper/get_price_premium_test.go (1)
162-162: InitializeMarketMapKeeperbefore other keepers.The initialization of
MarketMapKeeperwith a default genesis state ensures that the market map is correctly set up before running the tests. This change is crucial for the integrity of the test environment.protocol/testing/e2e/gov/prices_test.go (1)
145-171: Initialize marketmap module with genesis market data.The initialization of the marketmap module with genesis market data ensures that the market map is correctly set up before running the tests. This change enhances the robustness of the test environment.
protocol/testutil/keeper/perpetuals.go (2)
39-39: AddMarketMapKeepertoPerpKeepersTestContext.The addition of
MarketMapKeeperto thePerpKeepersTestContextstructure is necessary for managing market map data in testing scenarios. This change expands the capabilities of the testing context.
Line range hint
70-90: InitializeMarketMapKeeperinPerpetualsKeepersWithClobHelpers.The initialization of
MarketMapKeeperin thePerpetualsKeepersWithClobHelpersfunction ensures that the market map is correctly set up alongside other necessary keepers. This change is crucial for the integrity of the testing environment.protocol/x/prices/module_test.go (3)
38-40: Verify the correctness of the newexponentvalues.The
exponentvalues formarket_paramsandmarket_priceshave been changed from0to-1. Ensure this change aligns with the new conventions or requirements in the system's handling of price data.
Line range hint
55-65:
Verify the handling of the additional return value.The
createAppModuleWithKeeperfunction now accommodates an additional return value from thekeeper.PricesKeepers(t)function, which returns an extranilvalue. Ensure this additional return value is handled correctly and does not introduce any issues.
255-264: Verify the correctness and completeness of the new block of code.A new block of code has been added to create a market in the market map using the parameters defined in
genState.MarketParams. Ensure this addition is correct and enhances the robustness of the testing framework.protocol/testutil/keeper/clob.go (2)
42-42: Verify the integration of the newMarketMapKeeperfield.The
MarketMapKeeperhas been added as a new field in theClobKeepersTestContextstructure. Ensure this new field is integrated correctly and does not introduce any issues.
87-94: Verify the initialization and usage of the newMarketMapKeeper.The
NewClobKeepersTestContextWithUninitializedMemStorefunction has been modified to include the initialization ofMarketMapKeeper. Ensure this new keeper is initialized correctly and used appropriately.Also applies to: 177-177
protocol/app/process/process_proposal_test.go (1)
261-261: Verify the handling of the additional return values.The
TestProcessProposalHandler_Errorfunction now accommodates additional return values from thekeepertest.PricesKeepers(t)function. Ensure these additional return values are handled correctly and do not affect the test logic.protocol/x/prices/keeper/market_test.go (1)
234-234: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
PricesKeepersmatch the new signature.protocol/x/perpetuals/module_test.go (1)
Line range hint
252-259:
LGTM!The changes improve the test infrastructure by leveraging a dedicated test market creation function.
protocol/x/clob/keeper/msg_server_update_clob_pair_test.go (1)
257-258: LGTM!The changes ensure that the
MarketMapKeeperis properly initialized before proceeding with the test logic.protocol/testutil/keeper/prices.go (9)
64-64: LGTM!The changes to the
PricesKeepersfunction look good.
106-106: LGTM!The changes to the
createPricesKeeperfunction look good.
119-119: LGTM!The changes to the
CreateMarketInMarketMapFromParamsfunction look good.
159-159: LGTM!The changes to the
ConstructMarketMapFromParamsfunction look good.
178-183: LGTM!The changes to the
CreateTestMarketfunction look good.
126-159: Ensure error handling forConvertMarketParamsToMarketMap.The call to
h.ConvertMarketParamsToMarketMapshould include error handling to manage potential failures.- mm, err := h.ConvertMarketParamsToMarketMap(mpr) + mm, err := h.ConvertMarketParamsToMarketMap(mpr) + require.NoError(t, err)Likely invalid or redundant comment.
59-59: Ensure proper parameter passing.Verify that the
marketMapKeeperparameter is correctly passed to thecreatePricesKeeperfunction.Verification successful
The
marketMapKeeperparameter is correctly passed to thecreatePricesKeeperfunction.The
createPricesKeeperfunction definition includesmarketMapKeeperas a parameter, and it is passed correctly in the function call withinprotocol/testutil/keeper/prices.go.
Function Definition:
func createPricesKeeper( stateStore storetypes.CommitMultiStore, db *dbm.MemDB, cdc *codec.ProtoCodec, transientStoreKey storetypes.StoreKey, revShareKeeper *revsharekeeper.Keeper, marketMapKeeper *marketmapkeeper.Keeper, ) ( *keeper.Keeper, storetypes.StoreKey, *pricefeedserver_types.MarketToExchangePrices, *mocks.TimeProvider, ) {Function Call:
createPricesKeeper(stateStore, db, cdc, transientStoreKey, revShareKeeper, marketMapKeeper)The
marketMapKeeperparameter is indeed part of the function signature and is passed correctly in the call.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correct passing of `marketMapKeeper` parameter to the `createPricesKeeper` function. # Test: Search for the `createPricesKeeper` function call within the `PricesKeepers` function. Expect: Proper passing of `marketMapKeeper`. rg --type go 'createPricesKeeper' -A 5Length of output: 3219
Script:
#!/bin/bash # Description: Retrieve the complete definition of the `createPricesKeeper` function to verify its parameters. # Search for the `createPricesKeeper` function definition in Go files ast-grep --lang go --pattern 'func createPricesKeeper($$_) { $$$ }'Length of output: 71
Script:
#!/bin/bash # Description: Retrieve the complete definition of the `createPricesKeeper` function to verify its parameters. # Search for the `createPricesKeeper` function definition in Go files and include 20 lines of context to capture the parameters rg --type go 'func createPricesKeeper' -A 20Length of output: 1393
73-73: Verify the integration ofmarketMapKeeper.Ensure that the new
marketMapKeeperparameter is correctly integrated and utilized within thecreatePricesKeeperfunction.Verification successful
The
marketMapKeeperparameter is correctly integrated within thecreatePricesKeeperfunction.The parameter is properly utilized and passed to the
keeper.NewKeeperfunction, ensuring its correct initialization and usage.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correct integration of `marketMapKeeper` parameter within the `createPricesKeeper` function. # Test: Search for the usage of `marketMapKeeper` within the `createPricesKeeper` function. Expect: Proper usage and initialization. rg --type go 'createPricesKeeper' -A 20Length of output: 10039
Script:
#!/bin/bash # Description: Extract the full implementation of the `createPricesKeeper` function to verify the integration of `marketMapKeeper`. # Test: Use `ast-grep` to retrieve the complete implementation of the `createPricesKeeper` function. ast-grep --lang go --pattern 'func createPricesKeeper($_, $_, $_, $_, $_, $_) { $$$ }' protocol/testutil/keeper/prices.goLength of output: 123
Script:
#!/bin/bash # Description: Extract the full implementation of the `createPricesKeeper` function to verify the integration of `marketMapKeeper`. # Test: Use `rg` to search for the `createPricesKeeper` function definition and include 50 lines of context to capture the complete implementation. rg 'func createPricesKeeper' -A 50 protocol/testutil/keeper/prices.goLength of output: 1542
44-44: Verify the integration ofmarketMapKeeper.Ensure that the new
marketMapKeeperparameter is correctly integrated and utilized within thePricesKeepersfunction.Verification successful
Verify the integration of
marketMapKeeper.Ensure that the new
marketMapKeeperparameter is correctly integrated and utilized within thePricesKeepersfunction.
Verify the integration of
marketMapKeeper.Ensure that the new
marketMapKeeperparameter is correctly integrated and utilized within thePricesKeepersfunction.
Verified the integration of
marketMapKeeper.The
marketMapKeeperparameter is correctly integrated and utilized within thePricesKeepersfunction.
marketMapKeeperis initialized usingcreateMarketMapKeeper.- It is passed to
createPricesKeeper.- It is returned from the
PricesKeepersfunction.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correct integration of `marketMapKeeper` parameter within the `PricesKeepers` function. # Test: Search for the usage of `marketMapKeeper` within the `PricesKeepers` function. Expect: Proper usage and initialization. rg --type go 'PricesKeepers' -A 20Length of output: 80522
Script:
#!/bin/bash # Description: Verify the complete implementation of `PricesKeepers` function and the usage of `marketMapKeeper`. # Test: Retrieve the complete implementation of `PricesKeepers` function to verify initialization and usage of `marketMapKeeper`. ast-grep --lang go --pattern 'func PricesKeepers($_) { $$$ }'Length of output: 63
Script:
#!/bin/bash # Description: Verify the complete implementation of `PricesKeepers` function and the usage of `marketMapKeeper`. # Test: Retrieve the complete implementation of `PricesKeepers` function to verify initialization and usage of `marketMapKeeper`. rg 'func PricesKeepers' -A 50Length of output: 3459
protocol/app/process/transactions_test.go (6)
111-111: LGTM!The changes to the
TestDecodeProcessProposalTxs_Errorfunction look good.
191-191: LGTM!The changes to the
TestDecodeProcessProposalTxs_Validfunction look good.
321-321: LGTM!The changes to the
TestProcessProposalTxs_Validate_Errorfunction look good.
428-428: LGTM!The changes to the
TestProcessProposalTxs_Validate_Validfunction look good.
321-321: Ensure correct unpacking of additional variable.Verify that the additional variable unpacked from the
keepertest.PricesKeepersfunction call is correctly handled.
428-428: Ensure correct unpacking of additional variable.Verify that the additional variable unpacked from the
keepertest.PricesKeepersfunction call is correctly handled.Verification successful
Ensure correct unpacking of additional variable.
The
PricesKeepersfunction call within theTestProcessProposalTxs_Validate_Validfunction correctly unpacks the additional variableindexPriceCache. This confirms that the additional variable is handled appropriately.
protocol/app/process/transactions_test.go:
- Line 428:
ctx, pricesKeeper, _, indexPriceCache, mockTimeProvider, _, _ := keepertest.PricesKeepers(t)Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correct unpacking of the additional variable from the `keepertest.PricesKeepers` function call. # Test: Search for the `PricesKeepers` function call within the `TestProcessProposalTxs_Validate_Valid` function. Expect: Proper unpacking of the additional variable. rg --type go 'TestProcessProposalTxs_Validate_Valid' -A 20Length of output: 1726
Script:
#!/bin/bash # Description: Verify the correct unpacking of the additional variable from the `keepertest.PricesKeepers` function call. # Test: Search for the `PricesKeepers` function call within the `TestProcessProposalTxs_Validate_Valid` function. Expect: Proper unpacking of the additional variable. rg --type go 'TestProcessProposalTxs_Validate_Valid' -A 50Length of output: 3619
Script:
#!/bin/bash # Description: Verify the correct unpacking of the additional variable from the `keepertest.PricesKeepers` function call. # Test: Search for the `PricesKeepers` function call directly and include sufficient context lines to determine if it is within the `TestProcessProposalTxs_Validate_Valid` function. rg --type go 'PricesKeepers' -A 10 -B 10Length of output: 83826
Script:
#!/bin/bash # Description: Verify the correct unpacking of the additional variable from the `keepertest.PricesKeepers` function call. # Test: Search for the `TestProcessProposalTxs_Validate_Valid` function and include more context lines to capture the `PricesKeepers` function call within it. rg --type go 'func TestProcessProposalTxs_Validate_Valid' -A 100Length of output: 7406
protocol/x/prices/keeper/validate_market_price_updates_test.go (5)
125-125: LGTM!The changes to the
TestPerformStatefulPriceUpdateValidation_Validfunction look good.
210-210: LGTM!The changes to the
TestPerformStatefulPriceUpdateValidation_SkipNonDeterministicCheck_Validfunction look good.
210-210: Ensure correct unpacking of additional variable.Verify that the additional variable unpacked from the
keepertest.PricesKeepersfunction call is correctly handled.Verification successful
Ensure correct unpacking of additional variable.
The additional variable
indexPriceCacheunpacked from thekeepertest.PricesKeepersfunction call is correctly handled in theTestPerformStatefulPriceUpdateValidation_SkipNonDeterministicCheck_Validfunction.
- The variable
indexPriceCacheis used to update prices within the function, confirming its correct handling.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correct unpacking of the additional variable from the `keepertest.PricesKeepers` function call. # Test: Search for the `PricesKeepers` function call within the `TestPerformStatefulPriceUpdateValidation_SkipNonDeterministicCheck_Valid` function. Expect: Proper unpacking of the additional variable. rg --type go 'TestPerformStatefulPriceUpdateValidation_SkipNonDeterministicCheck_Valid' -A 20Length of output: 2287
Script:
#!/bin/bash # Description: Verify the correct unpacking of the additional variable from the `keepertest.PricesKeepers` function call. # Search for the `keepertest.PricesKeepers` function call within the `validate_market_price_updates_test.go` file and include more context lines. rg --type go 'keepertest.PricesKeepers' -A 30Length of output: 101224
125-125: Ensure correct unpacking of additional variable.Verify that the additional variable unpacked from the
keepertest.PricesKeepersfunction call is correctly handled.Verification successful
Ensure correct unpacking of additional variable.
The additional variable
mockTimeProviderunpacked from thekeepertest.PricesKeepersfunction call is correctly handled in the test cases.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correct unpacking of the additional variable from the `keepertest.PricesKeepers` function call. # Test: Search for the `PricesKeepers` function call within the `TestPerformStatefulPriceUpdateValidation_Valid` function. Expect: Proper unpacking of the additional variable. rg --type go 'TestPerformStatefulPriceUpdateValidation_Valid' -A 20Length of output: 2249
Script:
#!/bin/bash # Description: Verify the correct unpacking of the additional variable from the `keepertest.PricesKeepers` function call. # Search for the `keepertest.PricesKeepers` function call in the entire file to capture the relevant context. rg --type go 'keepertest.PricesKeepers' protocol/x/prices/keeper/validate_market_price_updates_test.go -A 10Length of output: 1778
Script:
#!/bin/bash # Description: Verify the definition of `keepertest.PricesKeepers` to confirm the expected return values and their correct handling. # Search for the definition of `PricesKeepers` in the keepertest package. rg --type go 'func PricesKeepers' --files-with-matches | xargs rg 'func PricesKeepers' -A 10Length of output: 436
343-343: Ensure correct unpacking of additional variable.Verify that the additional variable unpacked from the
keepertest.PricesKeepersfunction call is correctly handled.Ensure correct unpacking of additional variable.
The additional variable
mockTimeProvideris correctly unpacked from thekeepertest.PricesKeepersfunction call and is used appropriately in the test setup.
- The variable
mockTimeProvideris used to mock the current time withmockTimeProvider.On("Now").Return(constants.TimeT).Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correct unpacking of the additional variable from the `keepertest.PricesKeepers` function call. # Test: Search for the `PricesKeepers` function call within the `TestPerformStatefulPriceUpdateValidation_Error` function. Expect: Proper unpacking of the additional variable. rg --type go 'TestPerformStatefulPriceUpdateValidation_Error' -A 20Length of output: 2163
Script:
#!/bin/bash # Description: Search for the `PricesKeepers` function call within the `validate_market_price_updates_test.go` file to verify the correct unpacking of the additional variable. # Locate the `PricesKeepers` function call and capture surrounding lines for context. rg --type go 'PricesKeepers' -A 10 validate_market_price_updates_test.goLength of output: 150
Script:
#!/bin/bash # Description: Locate the correct file path for the test file containing the `TestPerformStatefulPriceUpdateValidation_Error` function. # Search for the file containing the `TestPerformStatefulPriceUpdateValidation_Error` function. rg --files-with-matches 'TestPerformStatefulPriceUpdateValidation_Error'Length of output: 135
Script:
#!/bin/bash # Description: Search for the `PricesKeepers` function call within the `protocol/x/prices/keeper/validate_market_price_updates_test.go` file to verify the correct unpacking of the additional variable. # Locate the `PricesKeepers` function call and capture surrounding lines for context. rg --type go 'PricesKeepers' -A 10 protocol/x/prices/keeper/validate_market_price_updates_test.goLength of output: 1767
protocol/x/prices/keeper/msg_server_update_market_prices_test.go (4)
189-189: Verify the impact of the additional return value.The additional return value from
keepertest.PricesKeepers(t)should be verified to ensure it does not affect the test logic.Verification successful
Verify the usage of
PricesKeepersin the test file.The
PricesKeepersfunction does not have an additional return value. Ensure that the current return values are correctly used in the test file.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the impact of the additional return value from `keepertest.PricesKeepers(t)`. # Test: Search for the function definition. Expect: The function should return the additional value. rg --type go 'func PricesKeepers' -A 5Length of output: 461
402-402: Verify the impact of the additional return value.The additional return value from
keepertest.PricesKeepers(t)should be verified to ensure it does not affect the test logic.
379-379: Verify the impact of the additional return value.The additional return value from
keepertest.PricesKeepers(t)should be verified to ensure it does not affect the test logic.Verification successful
The additional return value from
keepertest.PricesKeepers(t)does not negatively impact the test logic.The usage of
mockTimeProviderin the test file is appropriate and ensures the tests are deterministic by mocking the current time.
protocol/x/prices/keeper/msg_server_update_market_prices_test.go:
- The additional return value
mockTimeProvideris used to mock the current time, which is a standard practice in testing.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the impact of the additional return value from `keepertest.PricesKeepers(t)`. # Test: Search for the function definition. Expect: The function should return the additional value. rg --type go 'func PricesKeepers' -A 5Length of output: 461
Script:
#!/bin/bash # Description: Verify the usage of the additional return value `mockTimeProvider` in the test file. # Test: Search for the usage of `mockTimeProvider` in the `msg_server_update_market_prices_test.go` file. rg 'mockTimeProvider' protocol/x/prices/keeper/msg_server_update_market_prices_test.go -A 5Length of output: 644
315-315: Verify the impact of the additional return value.The additional return value from
keepertest.PricesKeepers(t)should be verified to ensure it does not affect the test logic.Verification successful
The additional return values from
keepertest.PricesKeepers(t)do not affect the test logic as they are not used in the test function.
- The additional return values
revShareKeeperandmarketMapKeeperare not utilized in the test filemsg_server_update_market_prices_test.go.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the impact of the additional return value from `keepertest.PricesKeepers(t)`. # Test: Search for the function definition. Expect: The function should return the additional value. rg --type go 'func PricesKeepers' -A 5Length of output: 461
Script:
#!/bin/bash # Description: Retrieve the complete function signature of `PricesKeepers` from `protocol/testutil/keeper/prices.go`. # Display the complete function signature for PricesKeepers rg --type go 'func PricesKeepers' -A 10 protocol/testutil/keeper/prices.goLength of output: 418
Script:
#!/bin/bash # Description: Search for the usage of `revShareKeeper` and `marketMapKeeper` in `msg_server_update_market_prices_test.go`. # Search for `revShareKeeper` usage rg 'revShareKeeper' protocol/x/prices/keeper/msg_server_update_market_prices_test.go # Search for `marketMapKeeper` usage rg 'marketMapKeeper' protocol/x/prices/keeper/msg_server_update_market_prices_test.goLength of output: 170
protocol/testing/e2e/gov/add_new_market_test.go (5)
8-9: LGTM! New imports are correctly integrated.The new imports from the
slinkyandmarketmaptypespackages are necessary for the added functionality.
357-359: LGTM! Ensure the function works as expected.The changes to check the state of the market after a failed proposal are correctly integrated.
Verify the function works as expected.
Verification successful
LGTM! Ensure the function works as expected.
The changes to check the state of the market after a failed proposal are correctly integrated. The
TestAddNewMarketProposalfunction comprehensively covers various scenarios, including the verification that the market remains disabled if the proposal fails.
protocol/testing/e2e/gov/add_new_market_test.golines 357-359Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the function `TestAddNewMarketProposal` works as expected. # Test: Run the test function. Expect: The test should pass. go test -run TestAddNewMarketProposalLength of output: 109
Script:
#!/bin/bash # Search for the implementation of the `TestAddNewMarketProposal` function in the codebase. ast-grep --lang go --pattern 'func TestAddNewMarketProposal($_) { $$$ }'Length of output: 34834
321-324: LGTM! Ensure the function works as expected.The changes to check the state of the market after initialization are correctly integrated.
Verify the function works as expected.
Verification successful
LGTM! Ensure the function works as expected.
The function
TestAddNewMarketProposalis well-implemented and covers various scenarios to validate the behavior of adding a new market proposal. The changes to check the state of the market after initialization are correctly integrated.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the function `TestAddNewMarketProposal` works as expected. # Test: Run the test function. Expect: The test should pass. go test -run TestAddNewMarketProposalLength of output: 109
Script:
#!/bin/bash # Locate the implementation of the `TestAddNewMarketProposal` function. ast-grep --lang go --pattern 'func TestAddNewMarketProposal($_) $_'Length of output: 34829
400-402: LGTM! Ensure the function works as expected.The changes to check the state of the market after a successful proposal are correctly integrated.
Verify the function works as expected.
Verification successful
LGTM! Ensure the function works as expected.
The changes to check the state of the market after a successful proposal are correctly integrated. The
TestAddNewMarketProposalfunction is comprehensive and covers multiple scenarios, ensuring the proposal mechanism works as expected.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the function `TestAddNewMarketProposal` works as expected. # Test: Run the test function. Expect: The test should pass. go test -run TestAddNewMarketProposalLength of output: 109
Script:
#!/bin/bash # Search for the implementation of the `TestAddNewMarketProposal` function in the codebase. ast-grep --lang go --pattern 'func TestAddNewMarketProposal($_) $_'Length of output: 34829
305-315: LGTM! Ensure the function works as expected.The changes to include additional checks and updates related to market parameters and their state are correctly integrated.
Verify the function works as expected.
protocol/x/clob/genesis_test.go (1)
429-429: LGTM! Ensure the function works as expected.The new initialization step for
MarketMapKeeperis correctly integrated.Verify the function works as expected.
Verification successful
LGTM! Ensure the function works as expected.
The new initialization step for
MarketMapKeeperis correctly integrated.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the function `TestGenesis` works as expected. # Test: Run the test function. Expect: The test should pass. go test -run TestGenesisLength of output: 96
Script:
#!/bin/bash # Search for the TestGenesis function implementation in the codebase and display its context rg -A 20 'func TestGenesis' --glob '*.go'Length of output: 31001
protocol/x/clob/module_test.go (4)
36-36: Import statement approved.The import statement for
marketmap_keeperis correctly added.
63-64: Function changes approved.The function
createAppModulecorrectly callscreateAppModuleWithKeeperand returns theAppModule.
Line range hint
75-104: Function changes approved.The function
createAppModuleWithKeepercorrectly initializes and returns the new keeper*marketmap_keeper.Keeperalong with other keepers and context.
Line range hint
289-317: Function changes approved.The function
TestAppModule_InitExportGenesiscorrectly initializes the genesis state for the new keepermarketMapKeeperand integrates it with the existing logic.
protocol/testing/e2e/gov/perpetuals_test.go (2)
18-19: Import statements approved.The import statements for
slinkytypesandmarketmaptypesare correctly added.
279-306: Function changes approved.The function
TestUpdatePerpetualsParamscorrectly initializes themarketmapmodule with genesis markets and integrates it with the existing logic.
protocol/x/rewards/keeper/keeper_test.go (2)
15-15: Import statement approved.The import statement for
keepertestis correctly added.
696-699: Function changes approved.The function
TestProcessRewardsForBlockcorrectly uses theCreateTestMarketfunction fromkeepertestto set up the test market.
protocol/x/perpetuals/lib/lib_test.go (13)
425-426: Verify the updatedpriceandexponentvalues.The
pricevalue has been increased from5_555to55_550, and theexponenthas been changed from a non-negative integer to-1. Ensure these changes align with the expected business logic.
445-446: Verify the updatedpriceandexponentvalues.The
pricevalue has been updated to55_550, and theexponenthas been changed to-1. Ensure these changes are consistent with the expected calculations.
455-456: Verify the updatedpriceandexponentvalues.The
pricevalue has been updated to55_550, and theexponenthas been changed to-1. Ensure these changes align with the expected business logic.
465-466: Verify the updatedpriceandexponentvalues.The
pricevalue has been updated to55_550, and theexponenthas been changed to-1. Ensure these changes are consistent with the expected calculations.
476-476: Verify the updatedexponentvalue.The
exponenthas been changed to-1. Ensure this change aligns with the expected business logic.
486-486: Verify the updatedexponentvalue.The
exponenthas been changed to-1. Ensure this change is consistent with the expected calculations.
499-500: Verify the updatedpriceandexponentvalues.The
pricevalue has been updated to55_550, and theexponenthas been changed to-1. Ensure these changes align with the expected business logic.
511-512: Verify the updatedpriceandexponentvalues.The
pricevalue has been updated to367_500, and theexponenthas been changed to-1. Ensure these changes are consistent with the expected calculations.
524-525: Verify the updatedpriceandexponentvalues.The
pricevalue has been updated to1_234_560, and theexponenthas been changed to-1. Ensure these changes align with the expected business logic.
537-538: Verify the updatedpriceandexponentvalues.The
pricevalue has been updated to1_234_560, and theexponenthas been changed to-1. Ensure these changes are consistent with the expected calculations.
548-549: Verify the updatedpriceandexponentvalues.The
pricevalue has been updated to367_500, and theexponenthas been changed to-1. Ensure these changes align with the expected business logic.
565-566: Verify the updatedpriceandexponentvalues.The
pricevalue has been updated to367_500, and theexponenthas been changed to-1. Ensure these changes are consistent with the expected calculations.
581-582: Verify the updatedpriceandexponentvalues.The
pricevalue has been updated to367_500, and theexponenthas been changed to-1. Ensure these changes align with the expected business logic.
protocol/app/prepare/prepare_proposal_test.go (2)
364-364: Verify the updated context variable unpacking.The context variable unpacking from the
keepertest.PricesKeepers(t)function has been expanded to include an additional variable. Ensure this change aligns with the updated return signature of thePricesKeepersfunction.
443-443: Verify the updated context variable unpacking.The context variable unpacking from the
keepertest.PricesKeepers(t)function has been expanded to include an additional variable. Ensure this change aligns with the updated return signature of thePricesKeepersfunction.
protocol/x/clob/keeper/clob_pair_test.go (7)
44-44: Initialization of MarketMapKeeper's genesis state looks good.The addition of
ks.MarketMapKeeper.InitGenesis(ks.Ctx, constants.MarketMap_DefaultGenesisState)ensures that theMarketMapKeeperis properly initialized before the test execution.
159-159: Initialization of MarketMapKeeper's genesis state looks good.The addition of
ks.MarketMapKeeper.InitGenesis(ks.Ctx, constants.MarketMap_DefaultGenesisState)ensures that theMarketMapKeeperis properly initialized before the test execution.
262-262: Initialization of MarketMapKeeper's genesis state looks good.The addition of
ks.MarketMapKeeper.InitGenesis(ks.Ctx, constants.MarketMap_DefaultGenesisState)ensures that theMarketMapKeeperis properly initialized before the test execution.
415-415: Initialization of MarketMapKeeper's genesis state looks good.The addition of
ks.MarketMapKeeper.InitGenesis(ks.Ctx, constants.MarketMap_DefaultGenesisState)ensures that theMarketMapKeeperis properly initialized before the test execution.
613-613: Initialization of MarketMapKeeper's genesis state looks good.The addition of
ks.MarketMapKeeper.InitGenesis(ks.Ctx, constants.MarketMap_DefaultGenesisState)ensures that theMarketMapKeeperis properly initialized before the test execution.
874-874: Initialization of MarketMapKeeper's genesis state looks good.The addition of
ks.MarketMapKeeper.InitGenesis(ks.Ctx, constants.MarketMap_DefaultGenesisState)ensures that theMarketMapKeeperis properly initialized before the test execution.
1055-1055: Initialization of MarketMapKeeper's genesis state looks good.The addition of
ks.MarketMapKeeper.InitGenesis(ks.Ctx, constants.MarketMap_DefaultGenesisState)ensures that theMarketMapKeeperis properly initialized before the test execution.
protocol/app/app.go (4)
927-927: EnsureMarketMapKeeperis correctly initialized.The addition of
&app.MarketMapKeepertoapp.PricesKeepershould be verified to ensure thatMarketMapKeeperis correctly initialized before usage.Verification successful
Ensure
MarketMapKeeperis correctly initialized.The addition of
&app.MarketMapKeepertoapp.PricesKeepershould be verified to ensure thatMarketMapKeeperis correctly initialized before usage. The initialization ofMarketMapKeeperis confirmed inprotocol/app/app.go.
protocol/app/app.go:MarketMapKeeperis initialized correctly before being used.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that MarketMapKeeper is initialized before usage in PricesKeeper. # Test: Search for the initialization of MarketMapKeeper. Expect: Initialization before usage. rg --type go 'MarketMapKeeper'Length of output: 6484
935-935: EnsureMarketMapKeeperis correctly initialized.The addition of
&app.MarketMapKeepertopricesModuleshould be verified to ensure thatMarketMapKeeperis correctly initialized before usage.
1351-1351: EnsureMarketMapKeeperis correctly initialized beforepricesModule.The addition of
marketmapmoduletypes.ModuleNamebeforepricesmoduletypes.ModuleNameinSetOrderInitGenesisshould be verified to ensure thatMarketMapKeeperis correctly initialized beforepricesModule.Verification successful
Verified:
MarketMapKeeperis correctly initialized beforepricesModuleinSetOrderInitGenesis.The order of initialization in
SetOrderInitGenesiscorrectly placesmarketmapmoduletypes.ModuleNamebeforepricesmoduletypes.ModuleName.
protocol/app/app.go, lines 1351-1351Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that MarketMapKeeper is initialized before pricesModule in SetOrderInitGenesis. # Test: Search for the initialization order in SetOrderInitGenesis. Expect: MarketMapKeeper before pricesModule. rg --type go 'SetOrderInitGenesis'Length of output: 94
Script:
#!/bin/bash # Description: Extract the arguments of SetOrderInitGenesis in protocol/app/app.go to verify the initialization order. # Extract lines where SetOrderInitGenesis is called and the subsequent lines to capture the arguments. rg --type go -A 10 'SetOrderInitGenesis' protocol/app/app.goLength of output: 365
Script:
#!/bin/bash # Description: Extract more lines following the SetOrderInitGenesis call in protocol/app/app.go to capture the complete list of arguments. # Extract lines where SetOrderInitGenesis is called and the subsequent 50 lines to capture the full list of arguments. rg --type go -A 50 'SetOrderInitGenesis' protocol/app/app.goLength of output: 1655
1394-1394: EnsureMarketMapKeeperis correctly initialized beforepricesModule.The addition of
marketmapmoduletypes.ModuleNamebeforepricesmoduletypes.ModuleNameinSetOrderMigrationsshould be verified to ensure thatMarketMapKeeperis correctly initialized beforepricesModule.Verification successful
Initialization order is correct.
The
MarketMapKeeperis correctly initialized beforepricesModulein theSetOrderMigrationscall.
marketmapmoduletypes.ModuleNameis listed beforepricesmoduletypes.ModuleName.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that MarketMapKeeper is initialized before pricesModule in SetOrderMigrations. # Test: Search for the initialization order in SetOrderMigrations. Expect: MarketMapKeeper before pricesModule. rg --type go 'SetOrderMigrations'Length of output: 92
Script:
#!/bin/bash # Description: Find and inspect the definition of SetOrderMigrations to verify the initialization order. # Locate the definition of SetOrderMigrations rg --type go 'func SetOrderMigrations' -A 10Length of output: 46
Script:
#!/bin/bash # Description: Search for SetOrderMigrations method calls and include more surrounding lines to capture its definition and usage context. # Locate the SetOrderMigrations method calls and include surrounding lines for context rg --type go 'SetOrderMigrations' -A 20 -B 10Length of output: 1624
protocol/x/clob/keeper/orders_test.go (8)
939-939: LGTM! TheMarketMapKeeperinitialization ensures consistent state.The addition of
ks.MarketMapKeeper.InitGenesis(ks.Ctx, constants.MarketMap_DefaultGenesisState)ensures that the market map is properly initialized before the test runs.
998-998: LGTM! TheMarketMapKeeperinitialization ensures consistent state.The addition of
ks.MarketMapKeeper.InitGenesis(ks.Ctx, constants.MarketMap_DefaultGenesisState)ensures that the market map is properly initialized before the test runs.
1754-1754: LGTM! TheMarketMapKeeperinitialization ensures consistent state.The addition of
ks.MarketMapKeeper.InitGenesis(ks.Ctx, constants.MarketMap_DefaultGenesisState)ensures that the market map is properly initialized before the test runs.
1807-1807: LGTM! TheMarketMapKeeperinitialization ensures consistent state.The addition of
ks.MarketMapKeeper.InitGenesis(ks.Ctx, constants.MarketMap_DefaultGenesisState)ensures that the market map is properly initialized before the test runs.
1974-1974: LGTM! TheMarketMapKeeperinitialization ensures consistent state.The addition of
ks.MarketMapKeeper.InitGenesis(ks.Ctx, constants.MarketMap_DefaultGenesisState)ensures that the market map is properly initialized before the test runs.
2108-2108: LGTM! TheMarketMapKeeperinitialization ensures consistent state.The addition of
ks.MarketMapKeeper.InitGenesis(ks.Ctx, constants.MarketMap_DefaultGenesisState)ensures that the market map is properly initialized before the test runs.
2278-2278: LGTM! TheMarketMapKeeperinitialization ensures consistent state.The addition of
ks.MarketMapKeeper.InitGenesis(ks.Ctx, constants.MarketMap_DefaultGenesisState)ensures that the market map is properly initialized before the test runs.
2408-2408: LGTM! TheMarketMapKeeperinitialization ensures consistent state.The addition of
ks.MarketMapKeeper.InitGenesis(ks.Ctx, constants.MarketMap_DefaultGenesisState)ensures that the market map is properly initialized before the test runs.
protocol/x/perpetuals/keeper/perpetual_test.go (3)
902-927: Ensure proper test coverage for negative exponents and atomic resolutions.The test cases for
TestGetNotionalInBaseQuantums_Successnow include negative exponents and atomic resolutions. Make sure these scenarios are well-documented and covered in other related tests.Verification successful
Test coverage for negative exponents and atomic resolutions is comprehensive.
The test cases for negative exponents and atomic resolutions are well-documented and covered across multiple related test files:
protocol/x/perpetuals/lib/lib_test.goprotocol/x/perpetuals/keeper/perpetual_test.goprotocol/lib/prices/utils_test.goprotocol/daemons/pricefeed/client/price_function/util_test.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that negative exponents and atomic resolutions are covered in related tests. # Test: Search for test cases with negative exponents and atomic resolutions. Expect: Multiple occurrences. rg --type go -A 5 'exponent:\s*-'Length of output: 23172
Line range hint
758-784:
Ensure proper test coverage for negative exponents and atomic resolutions.The test cases for
TestGetNetNotional_Successnow include negative exponents and atomic resolutions. Make sure these scenarios are well-documented and covered in other related tests.Verification successful
Negative exponents and atomic resolutions are properly covered in related tests.
The test cases for
TestGetNetNotional_Successand other related tests include scenarios with negative exponents and atomic resolutions across multiple files:
protocol/x/perpetuals/lib/lib_test.goprotocol/x/perpetuals/keeper/perpetual_test.goprotocol/lib/prices/utils_test.goprotocol/daemons/pricefeed/client/price_function/util_test.goThese scenarios are well-documented and tested throughout the codebase.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that negative exponents and atomic resolutions are covered in related tests. # Test: Search for test cases with negative exponents and atomic resolutions. Expect: Multiple occurrences. rg --type go -A 5 'exponent:\s*-'Length of output: 23172
1054-1058: Ensure proper test coverage for maximum uint values.The test case for
TestGetNetCollateral_Successincludes maximum uint values. Ensure similar edge cases are covered in other related tests.Verification successful
Test coverage for maximum uint values is already ensured.
The test cases across multiple files already include maximum uint values (
math.MaxUint64), ensuring that such edge cases are covered.
protocol/x/subaccounts/keeper/transfer_test.goprotocol/x/subaccounts/keeper/subaccount_test.goprotocol/x/vault/types/msg_deposit_to_vault_test.goprotocol/x/clob/memclob/memclob_cancel_order_test.goprotocol/x/clob/keeper/liquidations_test.goprotocol/lib/math_test.goprotocol/app/ante/types/free_gas_meter_test.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that maximum uint values are covered in related tests. # Test: Search for test cases with maximum uint values. Expect: Multiple occurrences. rg --type go -A 5 'math.MaxUint64'Length of output: 64436
protocol/x/clob/keeper/liquidations_test.go (1)
2270-2270: LGTM! Ensure the initialization of the genesis state forMarketMapKeeper.The code changes are approved. Initializing the genesis state for
MarketMapKeeperis crucial for ensuring the MarketMapKeeper is in a defined state before the test logic proceeds.However, ensure that the initialization of the genesis state for
MarketMapKeeperis correctly implemented in other relevant tests if necessary.Verification successful
Initialization of
MarketMapKeeperGenesis State VerifiedThe initialization of the genesis state for
MarketMapKeeperis consistently implemented across various test files. This ensures that theMarketMapKeeperis in a defined state before the test logic proceeds, enhancing test reliability.
protocol/x/perpetuals/genesis_test.goprotocol/x/clob/genesis_test.goprotocol/x/clob/keeper/msg_server_update_clob_pair_test.goprotocol/x/clob/keeper/msg_server_update_liquidations_config_test.goprotocol/x/clob/keeper/get_price_premium_test.goprotocol/x/clob/keeper/orders_test.goprotocol/x/clob/keeper/liquidations_test.goprotocol/x/clob/keeper/grpc_query_mev_node_to_node_test.goprotocol/x/clob/keeper/clob_pair_test.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the initialization of the genesis state for `MarketMapKeeper` in other relevant tests. # Test: Search for the initialization of `MarketMapKeeper`. Expect: Consistent initialization across tests. rg --type go --pattern 'MarketMapKeeper.InitGenesis'Length of output: 464
Script:
#!/bin/bash # Description: Verify the initialization of the genesis state for `MarketMapKeeper` in other relevant tests. # Test: Search for the initialization of `MarketMapKeeper`. Expect: Consistent initialization across tests. rg 'MarketMapKeeper.InitGenesis' --type goLength of output: 2874
protocol/x/subaccounts/keeper/subaccount_test.go (6)
2134-2134: Update the market pair format inGenerateMarketParamPrice.The
WithPairargument has been updated to "0-0", which likely reflects a new expected format for market pairs.
2138-2138: Update the market pair format inGenerateMarketParamPrice.The
WithPairargument has been updated to "1-1", which likely reflects a new expected format for market pairs.
2926-2929: ReplacepricesKeeper.CreateMarketwithkeepertest.CreateTestMarket.The new function introduces a
tparameter and modifies the context in which the market is created, likely to enhance test control and reliability.
5323-5323: Update the market pair format inGenerateMarketParamPrice.The
WithPairargument has been updated to "0-0", which likely reflects a new expected format for market pairs.
5327-5327: Update the market pair format inGenerateMarketParamPrice.The
WithPairargument has been updated to "1-1", which likely reflects a new expected format for market pairs.
5513-5516: ReplacepricesKeeper.CreateMarketwithkeepertest.CreateTestMarket.The new function introduces a
tparameter and modifies the context in which the market is created, likely to enhance test control and reliability.
| @@ -45,15 +52,16 @@ func PricesKeepers(t testing.TB) ( | |||
| ) []GenesisInitializer { | |||
| // Necessary keeper for testing | |||
| revShareKeeper, _, _ = createRevShareKeeper(stateStore, db, cdc) | |||
| marketMapKeeper, _ = createMarketMapKeeper(stateStore, db, cdc) | |||
There was a problem hiding this comment.
Ensure error handling for createMarketMapKeeper.
The call to createMarketMapKeeper should include error handling to manage potential failures.
- marketMapKeeper, _ = createMarketMapKeeper(stateStore, db, cdc)
+ var err error
+ marketMapKeeper, err = createMarketMapKeeper(stateStore, db, cdc)
+ if err != nil {
+ t.Fatalf("Failed to create marketMapKeeper: %v", err)
+ }Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| marketMapKeeper, _ = createMarketMapKeeper(stateStore, db, cdc) | |
| var err error | |
| marketMapKeeper, err = createMarketMapKeeper(stateStore, db, cdc) | |
| if err != nil { | |
| t.Fatalf("Failed to create marketMapKeeper: %v", err) | |
| } |
protocol/testutil/keeper/prices.go
Outdated
| func CreateMarketInMarketMapFromParams( | ||
| t testing.TB, | ||
| ctx sdk.Context, | ||
| mmk *marketmapkeeper.Keeper, | ||
| allMarketParams []types.MarketParam, | ||
| ) { | ||
| marketMap := ConstructMarketMapFromParams(t, allMarketParams) | ||
| for _, market := range marketMap.Markets { | ||
| market.Ticker.Enabled = false | ||
| require.NoError(t, mmk.CreateMarket(ctx, market)) | ||
| } | ||
| } |
There was a problem hiding this comment.
Ensure error handling for CreateMarket.
The call to mmk.CreateMarket should include error handling to manage potential failures.
- require.NoError(t, mmk.CreateMarket(ctx, market))
+ err := mmk.CreateMarket(ctx, market)
+ require.NoError(t, err)Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| func CreateMarketInMarketMapFromParams( | |
| t testing.TB, | |
| ctx sdk.Context, | |
| mmk *marketmapkeeper.Keeper, | |
| allMarketParams []types.MarketParam, | |
| ) { | |
| marketMap := ConstructMarketMapFromParams(t, allMarketParams) | |
| for _, market := range marketMap.Markets { | |
| market.Ticker.Enabled = false | |
| require.NoError(t, mmk.CreateMarket(ctx, market)) | |
| } | |
| } | |
| func CreateMarketInMarketMapFromParams( | |
| t testing.TB, | |
| ctx sdk.Context, | |
| mmk *marketmapkeeper.Keeper, | |
| allMarketParams []types.MarketParam, | |
| ) { | |
| marketMap := ConstructMarketMapFromParams(t, allMarketParams) | |
| for _, market := range marketMap.Markets { | |
| market.Ticker.Enabled = false | |
| err := mmk.CreateMarket(ctx, market) | |
| require.NoError(t, err) | |
| } | |
| } |
protocol/testutil/keeper/prices.go
Outdated
| t testing.TB, | ||
| ctx sdk.Context, | ||
| k *keeper.Keeper, | ||
| marketParam types.MarketParam, | ||
| marketPrice types.MarketPrice, | ||
| ) (types.MarketParam, error) { | ||
| CreateMarketInMarketMapFromParams( | ||
| t, | ||
| ctx, | ||
| k.MarketMapKeeper.(*marketmapkeeper.Keeper), | ||
| []types.MarketParam{marketParam}, | ||
| ) | ||
|
|
||
| return k.CreateMarket( | ||
| ctx, | ||
| marketParam, | ||
| marketPrice, | ||
| ) | ||
| } |
There was a problem hiding this comment.
Ensure error handling for CreateMarketInMarketMapFromParams.
The call to CreateMarketInMarketMapFromParams should include error handling to manage potential failures.
- CreateMarketInMarketMapFromParams(
+ err := CreateMarketInMarketMapFromParams(
+ t,
+ ctx,
+ k.MarketMapKeeper.(*marketmapkeeper.Keeper),
+ []types.MarketParam{marketParam},
+ )
+ require.NoError(t, err)Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| t testing.TB, | |
| ctx sdk.Context, | |
| k *keeper.Keeper, | |
| marketParam types.MarketParam, | |
| marketPrice types.MarketPrice, | |
| ) (types.MarketParam, error) { | |
| CreateMarketInMarketMapFromParams( | |
| t, | |
| ctx, | |
| k.MarketMapKeeper.(*marketmapkeeper.Keeper), | |
| []types.MarketParam{marketParam}, | |
| ) | |
| return k.CreateMarket( | |
| ctx, | |
| marketParam, | |
| marketPrice, | |
| ) | |
| } | |
| t testing.TB, | |
| ctx sdk.Context, | |
| k *keeper.Keeper, | |
| marketParam types.MarketParam, | |
| marketPrice types.MarketPrice, | |
| ) (types.MarketParam, error) { | |
| err := CreateMarketInMarketMapFromParams( | |
| t, | |
| ctx, | |
| k.MarketMapKeeper.(*marketmapkeeper.Keeper), | |
| []types.MarketParam{marketParam}, | |
| ) | |
| require.NoError(t, err) | |
| return k.CreateMarket( | |
| ctx, | |
| marketParam, | |
| marketPrice, | |
| ) | |
| } |
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
protocol/testutil/keeper/prices.go (1)
63-63: Ensure the function usage is updated.The function
PricesKeepershas been updated to return seven values. However, there are multiple instances in the codebase where this function is called, but the return values do not match the new signature. These instances need to be updated to handle seven return values.
- Files and lines to update:
protocol/x/prices/module_test.go: ctx, keeper, _, _, mockTimeProvider, _, _ := keeper.PricesKeepers(t)protocol/x/prices/keeper/keeper_test.go: ctx, keeper, _, _, _, _, _ := keepertest.PricesKeepers(t)protocol/x/prices/keeper/update_price_test.go: ctx, k, _, indexPriceCache, mockTimeProvider, _, _ := keepertest.PricesKeepers(t)protocol/x/prices/genesis_test.go: ctx, k, _, _, mockTimeProvider, _, marketMapKeeper := keepertest.PricesKeepers(t)protocol/x/prices/genesis_test.go: ctx, k, _, _, mockTimeProvider, _, _ := keepertest.PricesKeepers(t)protocol/x/prices/keeper/validate_market_price_updates_test.go: ctx, k, _, indexPriceCache, mockTimeProvider, _, _ := keepertest.PricesKeepers(t)protocol/x/prices/keeper/msg_server_update_market_prices_test.go: ctx, k, _, indexPriceCache, mockTimeProvider, _, _ := keepertest.PricesKeepers(t)protocol/x/prices/keeper/msg_server_update_market_param_test.go: ctx, pricesKeeper, _, _, mockTimeProvider, _, _ := keepertest.PricesKeepers(t)protocol/x/prices/keeper/market_price_test.go: ctx, keeper, _, _, mockTimeProvider, _, _ := keepertest.PricesKeepers(t)protocol/x/prices/keeper/slinky_adapter_test.go: ctx, keeper, _, _, mockTimeProvider, _, _ := keepertest.PricesKeepers(t)protocol/x/prices/keeper/market_test.go: ctx, keeper, _, _, mockTimeProvider, revShareKeeper, marketMapKeeper := keepertest.PricesKeepers(t)protocol/x/prices/keeper/market_param_test.go: ctx, keeper, _, _, mockTimeProvider, _, _ := keepertest.PricesKeepers(t)protocol/x/prices/keeper/grpc_query_market_test.go: ctx, keeper, _, _, mockTimeProvider, _, _ := keepertest.PricesKeepers(t)protocol/app/process/transactions_test.go: ctx, pricesKeeper, _, _, _, _, _ := keepertest.PricesKeepers(t)protocol/app/process/market_prices_test.go: ctx, k, _, _, _, _, _ := keepertest.PricesKeepers(t)protocol/app/prepare/prepare_proposal_test.go: ctx, _, _, _, _, _, _ := keepertest.PricesKeepers(t)Please update these instances to match the new function signature.
Analysis chain
Ensure the function usage is updated.
The function signature of
PricesKeepershas been updated. Ensure that all calls to this function are updated accordingly.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the function usage of `PricesKeepers` in the codebase. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type go $'PricesKeepers'Length of output: 6661
Script:
#!/bin/bash # Description: Verify each occurrence of the `PricesKeepers` function to ensure it matches the new signature. # Test: Check if each call to `PricesKeepers` handles seven return values. rg --type go 'PricesKeepers' -A 1 | grep -E 'ctx, [^,]+, [^,]+, [^,]+, [^,]+, [^,]+, [^,]+ := keepertest.PricesKeepers\(t\)|ctx, [^,]+, [^,]+, [^,]+, [^,]+, [^,]+, [^,]+ := keeper.PricesKeepers\(t\)'Length of output: 6762
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (7)
- protocol/app/app.go (4 hunks)
- protocol/testutil/keeper/prices.go (6 hunks)
- protocol/x/prices/keeper/market_test.go (7 hunks)
- protocol/x/prices/keeper/msg_server_create_oracle_market_test.go (1 hunks)
- protocol/x/prices/keeper/slinky_adapter_test.go (5 hunks)
- protocol/x/prices/module_test.go (4 hunks)
- protocol/x/subaccounts/keeper/transfer_test.go (2 hunks)
Files skipped from review due to trivial changes (1)
- protocol/x/subaccounts/keeper/transfer_test.go
Files skipped from review as they are similar to previous changes (5)
- protocol/app/app.go
- protocol/x/prices/keeper/market_test.go
- protocol/x/prices/keeper/msg_server_create_oracle_market_test.go
- protocol/x/prices/keeper/slinky_adapter_test.go
- protocol/x/prices/module_test.go
Additional comments not posted (8)
protocol/testutil/keeper/prices.go (8)
44-44: Ensure error handling forcreateMarketMapKeeper.The call to
createMarketMapKeepershould include error handling to manage potential failures.
118-123: Ensure error handling forCreateMarket.The call to
mmk.CreateMarketshould include error handling to manage potential failures.
Line range hint
125-158:
Ensure error handling forNewAPIHandlerandConvertMarketParamsToMarketMap.The calls to
dydx.NewAPIHandlerandh.ConvertMarketParamsToMarketMapshould include error handling to manage potential failures.
Line range hint
160-169:
Ensure error handling forCreateMarketInMarketMapFromParams.The call to
CreateMarketInMarketMapFromParamsshould include error handling to manage potential failures.
221-230: Ensure error handling forCreateTestMarket.The call to
CreateTestMarketshould include error handling to manage potential failures.
Line range hint
278-285:
Ensure error handling forCreateTestMarket.The call to
CreateTestMarketshould include error handling to manage potential failures.
32-32: Ensure the new import is necessary.The import statement for
marketmapmoduletypesshould be verified to ensure it's used in the code.Verification successful
The import statement for
marketmapmoduletypesis necessary and correctly used.
protocol/testutil/keeper/prices.go: Usage ofmarketmapmoduletypesconfirms the necessity of the import.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of `marketmapmoduletypes` in the code. # Test: Search for the usage. Expect: At least one occurrence. rg --type go $'marketmapmoduletypes'Length of output: 11507
Line range hint
78-78:
Ensure the function usage is updated.The function signature of
createPricesKeeperhas been updated. Ensure that all calls to this function are updated accordingly.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
protocol/go.sumis excluded by!**/*.sum
Files selected for processing (6)
- protocol/go.mod (3 hunks)
- protocol/mocks/OracleClient.go (1 hunks)
- protocol/testing/e2e/gov/perpetuals_test.go (2 hunks)
- protocol/x/clob/module_test.go (8 hunks)
- protocol/x/perpetuals/module_test.go (3 hunks)
- protocol/x/prices/module_test.go (4 hunks)
Files skipped from review as they are similar to previous changes (4)
- protocol/testing/e2e/gov/perpetuals_test.go
- protocol/x/clob/module_test.go
- protocol/x/perpetuals/module_test.go
- protocol/x/prices/module_test.go
Additional comments not posted (5)
protocol/mocks/OracleClient.go (1)
130-165: LGTM! The new mock methodVersionis well-implemented.The method correctly handles variadic gRPC call options and manages mock behavior using the
Calledfunction. It also includes proper error handling and type assertions.protocol/go.mod (4)
434-434: Verify compatibility with the newgolang.org/x/toolsversion.The
golang.org/x/toolsdependency version has been updated fromv0.22.0tov0.23.0. Ensure that the new version is compatible with the rest of the codebase.Verification successful
No direct compatibility issues found with the new
golang.org/x/toolsversion.The
golang.org/x/toolsdependency version has been updated fromv0.22.0tov0.23.0. There are no direct references to this dependency in the Go source files, suggesting that the update should not cause any immediate compatibility issues.
protocol/go.modprotocol/go.sumScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility with the new `golang.org/x/tools` version. # Test: Check for any breaking changes or incompatibilities. rg --type go 'golang.org/x/tools'Length of output: 33
Script:
#!/bin/bash # Description: Verify compatibility with the new `golang.org/x/tools` version. # Test: Check for any indirect usage or related files impacted by the version update. # Search for any references to `golang.org/x/tools` in the Go module files. rg 'golang.org/x/tools' --glob 'go.mod' --glob 'go.sum' # Search for any references to `golang.org/x/tools` in all Go files. rg 'golang.org/x/tools' --type goLength of output: 9917
14-14: Verify compatibility with the new Cosmos SDK version.The Cosmos SDK version has been updated from
v0.50.7tov0.50.8. Ensure that the new version is compatible with the rest of the codebase.
70-70: Verify compatibility with the newslinkyversion.The
slinkydependency version has been updated fromv1.0.4-0.20240715165738-8218f83b6eb1tov1.0.5-0.20240723200102-e4ba512cc7cc. Ensure that the new version is compatible with the rest of the codebase.
426-426: Verify compatibility with the newgolang.org/x/modversion.The
golang.org/x/moddependency version has been updated fromv0.18.0tov0.19.0. Ensure that the new version is compatible with the rest of the codebase.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- protocol/testutil/sim_helpers/genesis_parameters.go (1 hunks)
- protocol/x/prices/simulation/genesis.go (3 hunks)
Additional comments not posted (6)
protocol/testutil/sim_helpers/genesis_parameters.go (3)
88-88: Verify the impact of the tightened constraint forMinMinExchangesPerMarket.The
Reasonablevalue has been decreased from 3 to 2. Ensure this change aligns with the overall market behavior and system requirements.
92-93: Verify the impact of the tightened constraints forMaxMinExchangesPerMarket.The
Reasonablevalue has been reduced from 5 to 3, and theValidvalue has been significantly lowered from 100 to 6. Ensure this change aligns with the overall market validation and system requirements.
101-102: Verify the impact of the shifted range forMaxMarketExponent.The
Reasonablevalue has been adjusted from 0 to -5, and theValidvalue has been changed from 10 to -1. Ensure this change aligns with the overall market calculations and system requirements.protocol/x/prices/simulation/genesis.go (3)
91-101: LGTM! The dynamically generatedExchangeConfigJsonenhances simulation realism.The change from hardcoded empty JSON to a dynamically generated JSON string that includes multiple exchanges improves the flexibility and realism of the market simulation.
118-132: LGTM! The construction ofmarketmapGenesisfrom market parameters improves simulation accuracy.The change ensures that the market map is constructed from the market parameters using the
ConstructMarketMapFromParamsfunction, improving the accuracy and consistency of the simulation.
136-172: LGTM! TheConstructMarketMapFromParamsfunction enhances simulation functionality.The new function converts market parameters into a market map using an API handler from the
dydxpackage, improving the functionality and realism of the simulation.
| func(genesisState *marketmaptypes.GenesisState) { | ||
| markets := make(map[string]marketmaptypes.Market) | ||
| cp, _ := slinky.MarketPairToCurrencyPair(GENESIS_MARKET_PARAM.Pair) | ||
| ticker := marketmaptypes.Ticker{ |
There was a problem hiding this comment.
nit: Add a constant to testutil/constants for this market map market?
There was a problem hiding this comment.
This is derived from the GENESIS_MARKET_PARAM var defined in this file, so I think it makes sense to leave it like this
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (7)
- protocol/Makefile (2 hunks)
- protocol/testing/e2e/gov/add_new_market_test.go (6 hunks)
- protocol/testing/genesis.sh (1 hunks)
- protocol/x/perpetuals/keeper/perpetual_test.go (9 hunks)
- protocol/x/perpetuals/lib/lib_test.go (12 hunks)
- protocol/x/prices/keeper/market_test.go (8 hunks)
- protocol/x/prices/simulation/genesis.go (3 hunks)
Files skipped from review due to trivial changes (1)
- protocol/Makefile
Files skipped from review as they are similar to previous changes (4)
- protocol/testing/e2e/gov/add_new_market_test.go
- protocol/x/perpetuals/keeper/perpetual_test.go
- protocol/x/perpetuals/lib/lib_test.go
- protocol/x/prices/keeper/market_test.go
Additional comments not posted (8)
protocol/x/prices/simulation/genesis.go (4)
91-101: Verify the correctness ofexchangeJsonconstruction.The dynamically generated
exchangeJsonstring improves flexibility. Ensure that themarketNameis correctly formatted and used in the JSON string.Verification successful
Verify the correctness of
exchangeJsonconstruction.The dynamically generated
exchangeJsonstring improves flexibility. ThemarketNameis correctly formatted and used in the JSON string. TheexchangeJsonis appropriately used in theExchangeConfigJsonfield of theMarketParamstruct.
protocol/x/prices/simulation/genesis.go:exchangeJsonis constructed and used correctly.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness of `exchangeJson` construction. # Test: Search for the usage of `exchangeJson`. Expect: Correct formatting and usage. rg --type go -A 5 $'exchangeJson'Length of output: 1453
136-154: Verify the initialization of the API handler.The API handler is initialized with dummy variables to pass validation. Ensure that the initialization parameters are correct and appropriate for the simulation context.
Verification successful
Verified the initialization of the API handler.
The API handler is initialized with dummy variables to pass validation, and the parameters used are consistent and appropriate for the simulation context.
protocol/x/prices/simulation/genesis.goprotocol/testutil/keeper/prices.goprotocol/app/upgrades/v6.0.0/upgrade.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the initialization of the API handler. # Test: Search for the initialization of `dydx.NewAPIHandler`. Expect: Correct initialization parameters. rg --type go -A 5 $'dydx.NewAPIHandler'Length of output: 1274
Script:
#!/bin/bash # Description: Verify the usage context of the API handler. # Test: Search for the usage of `dydx.NewAPIHandler` in the codebase to understand its context. rg --type go 'dydx.NewAPIHandler' -A 10Length of output: 2276
118-132: Verify the integration ofConstructMarketMapFromParams.The integration of the new function
ConstructMarketMapFromParamslooks good. Ensure that the function is correctly used and the market map is properly constructed.Verification successful
The integration of
ConstructMarketMapFromParamsis verified.The function
ConstructMarketMapFromParamsis correctly defined and used inprotocol/x/prices/simulation/genesis.go. Additionally, it is thoroughly tested inprotocol/testutil/keeper/prices.goandprotocol/testing/e2e/gov/add_new_market_test.go.
protocol/x/prices/simulation/genesis.go: Properly constructs the market map and integrates it into the genesis state.protocol/testutil/keeper/prices.go: Includes test cases that validate the function's behavior.protocol/testing/e2e/gov/add_new_market_test.go: Further tests the function in an end-to-end scenario.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the integration of `ConstructMarketMapFromParams`. # Test: Search for the usage of `ConstructMarketMapFromParams`. Expect: Correct usage and integration. rg --type go -A 5 $'ConstructMarketMapFromParams'Length of output: 2553
Script:
#!/bin/bash # Extract the full definition of `ConstructMarketMapFromParams` in `genesis.go` ast-grep --lang go --pattern $'func ConstructMarketMapFromParams($_, $_) $_' protocol/x/prices/simulation/genesis.go # Extract the context around the usage of `ConstructMarketMapFromParams` in `genesis.go` rg --type go -C 5 'ConstructMarketMapFromParams' protocol/x/prices/simulation/genesis.go # Verify the test cases in `prices.go` rg --type go -A 10 'ConstructMarketMapFromParams' protocol/testutil/keeper/prices.go # Verify the test cases in `add_new_market_test.go` rg --type go -A 10 'ConstructMarketMapFromParams' protocol/testing/e2e/gov/add_new_market_test.goLength of output: 2281
156-172: Verify the construction and conversion of market parameters.The function constructs a response structure from market parameters and converts it into a market map. Ensure that the construction and conversion logic is correct and handles all edge cases.
protocol/testing/genesis.sh (4)
517-540: Verify the correctness of the MarketMap configuration for "BTC/USD".The configuration includes detailed parameters and multiple provider configurations. Ensure that all values, especially the normalization settings, are correct and consistent with the intended market setup.
541-547: Verify the correctness of the MarketMap configuration for "USDT/USD".The configuration includes detailed parameters and multiple provider configurations. Ensure that all values, especially the inversion settings for some providers, are correct and consistent with the intended market setup.
548-548: Verify the correctness of the prices module configurations.The configurations include detailed parameters for multiple markets. Ensure that all values, especially the price and exchange configurations, are correct and consistent with the intended market setup.
517-547: Verify the correctness of the MarketMap configurations for "BTC/USD" and "USDT/USD".The configurations include detailed parameters and multiple provider configurations. Ensure that all values, especially the normalization and inversion settings, are correct and consistent with the intended market setup.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/indexer-build-and-push-dev-staging.yml (1 hunks)
- protocol/scripts/genesis/sample_pregenesis.json (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- protocol/scripts/genesis/sample_pregenesis.json
Additional comments not posted (1)
.github/workflows/indexer-build-and-push-dev-staging.yml (1)
9-9: LGTM!The addition of the branch pattern
chenyao/tra-508to theonsection is correct.
| @@ -6,6 +6,7 @@ on: # yamllint disable-line rule:truthy | |||
| - main | |||
| - 'release/indexer/v[0-9]+.[0-9]+.x' # e.g. release/indexer/v0.1.x | |||
| - 'release/indexer/v[0-9]+.x' # e.g. release/indexer/v1.x | |||
| - 'chenyao/tra-508' | |||
There was a problem hiding this comment.
nit: Remove before merging.
| @@ -6,6 +6,7 @@ on: # yamllint disable-line rule:truthy | |||
| - main | |||
| - 'release/protocol/v[0-9]+.[0-9]+.x' # e.g. release/protocol/v0.1.x | |||
| - 'release/protocol/v[0-9]+.x' # e.g. release/protocol/v1.x | |||
| - 'chenyao/tra-508' | |||
There was a problem hiding this comment.
nit: Remove before merging.
| Price: constants.FiveBillion, | ||
| }, | ||
| ) | ||
| require.Error(t, err) |
There was a problem hiding this comment.
nit: Check the error against the expected error type.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- protocol/x/prices/keeper/market_test.go (8 hunks)
Files skipped from review as they are similar to previous changes (1)
- protocol/x/prices/keeper/market_test.go
Changelist
[Describe or list the changes made in this PR]
Test Plan
[Describe how this PR was tested (if applicable)]
Author/Reviewer Checklist
state-breakinglabel.indexer-postgres-breakinglabel.PrepareProposalorProcessProposal, manually add the labelproposal-breaking.feature:[feature-name].backport/[branch-name].refactor,chore,bug.Summary by CodeRabbit
New Features
Bug Fixes
Tests
Refactor