Fix v4-proto-py package #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roy-dydx
approved these changes
Sep 8, 2023
roy-dydx
reviewed
Sep 8, 2023
| $$(find ./$${dir} -type f -name '*.proto'); \ | ||
| done; \ | ||
| touch v4-proto-py/v4-proto-py/__init__.py | ||
| echo "import os\nimport sys\n\nsys.path.insert(0, os.path.abspath(os.path.dirname(__file__)))" > v4-proto-py/v4_proto/__init__.py | ||
|
|
There was a problem hiding this comment.
I don't like modifying the python path in here.
There was a problem hiding this comment.
I think it would be sufficient to just do touch v4-proto-py/v4_proto/__init__.py here?
There was a problem hiding this comment.
Resolved: this is a hack to resolve protocolbuffers/protobuf#1491 (comment).
We should consider using sed to change the import statements instead. Mostly because we are hiding some real googleapi protos if we do this.
roy-dydx
requested changes
Sep 8, 2023
roy-dydx
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the build of v4-proto-py, as I was trying to import it into the
v4-client-pywith no luck. The following changes worked for me:v4_proto(when importing the package, it gets put underv4-proto, which has incompatible naming with python)__init__.py. This was in the originaldydxpy, i'm not completely familiar with what it does but it helped to set the subdirectories correctly