add megavault owner shares query #2323
Conversation
WalkthroughThis pull request enhances the querying capabilities for megavault owner shares within the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
Outside diff range and nitpick comments (7)
indexer/packages/v4-protos/src/codegen/dydxprotocol/vault/query.lcd.ts (2)
63-74: LGTM with a minor suggestion:megavaultOwnerSharesmethod updated correctlyThe
megavaultOwnerSharesmethod has been updated to require aQueryMegavaultOwnerSharesRequestparameter, which is a good practice for ensuring proper input. The new logic correctly handles the address parameter if provided.Consider using optional chaining for a more concise check:
if (params?.address != null) { options.params.address = params.address; }This change would make the code slightly more readable and consistent with modern TypeScript practices.
Line range hint
75-90: LGTM with a minor suggestion: NewmegavaultAllOwnerSharesmethod added correctlyThe new
megavaultAllOwnerSharesmethod is well-implemented and follows the existing patterns in the class. It correctly handles pagination parameters and uses the appropriate endpoint and return type.For consistency with other methods in the class, consider moving the
pagination: undefineddefault value to the method body:async megavaultAllOwnerShares(params: QueryMegavaultAllOwnerSharesRequest = {}): Promise<QueryMegavaultAllOwnerSharesResponseSDKType> { const options: any = { params: {} }; if (typeof params?.pagination !== "undefined") { setPaginationParams(options, params.pagination); } const endpoint = `dydxprotocol/vault/megavault/all_owner_shares`; return await this.req.get<QueryMegavaultAllOwnerSharesResponseSDKType>(endpoint, options); }This change would make the method signature more consistent with others in the class while maintaining the same functionality.
protocol/x/vault/client/cli/query.go (2)
173-177: LGTM: Function updated to query all owner shares.The changes correctly update the function to query all owner shares instead of a specific owner's shares, which aligns with the PR objective. The request type and query client method have been appropriately updated.
Consider updating the function name from
CmdQueryListOwnerSharestoCmdQueryListAllOwnerSharesto more accurately reflect its new functionality. This would improve code readability and maintain consistency with the new query name.
226-251: LGTM: New function added to query owner shares by address.The new
CmdQueryOwnerSharesfunction is well-implemented and follows the existing pattern for CLI commands. It correctly uses theMegavaultOwnerSharesmethod from the query client and handles input validation and error checking appropriately.Consider adding a brief comment above the function to describe its purpose and expected input, similar to other functions in this file. For example:
// CmdQueryOwnerShares returns the command to query megavault owner shares for a specific address. func CmdQueryOwnerShares() *cobra.Command { // ... (existing implementation) }This would improve code documentation and maintain consistency with other functions in the file.
indexer/packages/v4-protos/src/codegen/dydxprotocol/vault/query.rpc.Query.ts (2)
21-24: LGTM: Query interface updated correctly with a minor suggestion.The changes to the
Queryinterface look good:
- The
megavaultOwnerSharesmethod now requires a request parameter, improving type safety.- The new
megavaultAllOwnerSharesmethod is properly added with clear documentation.Consider adding a brief comment explaining the difference between
megavaultOwnerSharesandmegavaultAllOwnerSharesto clarify their distinct purposes.
73-85: LGTM: QueryClientImpl methods implemented correctly with a minor suggestion.The changes to the
QueryClientImplclass methods look good:
- The
megavaultOwnerSharesmethod now correctly requires a request parameter.- The new
megavaultAllOwnerSharesmethod is implemented consistently with other methods in the class.- Both methods use the correct request and response types, and the RPC calls are properly set up.
Consider adding error handling for the RPC calls. For example, you could wrap the
promise.then()calls in a try-catch block to handle any potential errors during decoding or network issues.protocol/x/vault/keeper/grpc_query_shares.go (1)
49-52: Enhance error handling with more contextWhen fetching
megavaultEquity, an error is returned if the operation fails:megavaultEquity, err := k.GetMegavaultEquity(ctx) if err != nil { return nil, status.Error(codes.Internal, err.Error()) }Currently, the error returned to the client might not provide enough context about the failure.
Consider wrapping the error with more descriptive information to aid in debugging:
if err != nil { return nil, status.Errorf(codes.Internal, "failed to get megavault equity: %v", err) }
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
protocol/x/vault/types/query.pb.gois excluded by!**/*.pb.goprotocol/x/vault/types/query.pb.gw.gois excluded by!**/*.pb.gw.go
Files selected for processing (7)
- indexer/packages/v4-protos/src/codegen/dydxprotocol/vault/query.lcd.ts (4 hunks)
- indexer/packages/v4-protos/src/codegen/dydxprotocol/vault/query.rpc.Query.ts (5 hunks)
- indexer/packages/v4-protos/src/codegen/dydxprotocol/vault/query.ts (7 hunks)
- proto/dydxprotocol/vault/query.proto (3 hunks)
- protocol/x/vault/client/cli/query.go (3 hunks)
- protocol/x/vault/keeper/grpc_query_shares.go (3 hunks)
- protocol/x/vault/keeper/grpc_query_shares_test.go (5 hunks)
Additional context used
buf
proto/dydxprotocol/vault/query.proto
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
Additional comments not posted (17)
indexer/packages/v4-protos/src/codegen/dydxprotocol/vault/query.lcd.ts (3)
3-3: LGTM: Import statement updated correctlyThe import statement has been properly updated to include all the necessary types for the new and modified methods. This change is consistent with the modifications made in the file.
18-18: LGTM: New method binding added correctlyThe
megavaultAllOwnerSharesmethod is properly bound in the constructor, following the existing pattern for method bindings. This change is consistent with the addition of the new method in the class.
Line range hint
1-90: Overall assessment: Well-implemented changes with minor suggestionsThe changes in this file successfully implement the new
megavaultAllOwnerSharesquery and update themegavaultOwnerSharesquery as described in the PR objectives. The code quality is good, and the changes are consistent with the existing codebase.A few minor suggestions have been made for improved readability and consistency, but these are not critical issues. The new functionality appears to be correctly implemented and follows the established patterns in the
LCDQueryClientclass.protocol/x/vault/client/cli/query.go (2)
33-33: LGTM: New command added correctly.The addition of
CmdQueryOwnerShares()to the command list is consistent with the existing pattern and aligns with the PR objective of adding a new query for megavault owner shares.
Line range hint
1-251: Overall assessment: Changes are well-implemented and align with PR objectives.The modifications to this file successfully introduce the new query for megavault owner shares while maintaining consistency with existing code patterns. The changes enhance the CLI's querying capabilities as intended. Minor suggestions for improvements have been made to further increase code clarity and consistency.
indexer/packages/v4-protos/src/codegen/dydxprotocol/vault/query.rpc.Query.ts (4)
4-4: LGTM: Import statement updated correctly.The import statement has been properly updated to include the new types
QueryMegavaultAllOwnerSharesRequestandQueryMegavaultAllOwnerSharesResponse. This change is consistent with the addition of the newmegavaultAllOwnerSharesmethod.
42-42: LGTM: Constructor updated correctly.The
megavaultAllOwnerSharesmethod is properly bound in theQueryClientImplconstructor. This ensures that the new method will work correctly when called on an instance ofQueryClientImpl.
120-126: LGTM: createRpcQueryExtension function updated correctly.The changes to the
createRpcQueryExtensionfunction are consistent with the updates to theQueryinterface andQueryClientImplclass:
- The
megavaultOwnerSharesmethod now correctly requires a request parameter.- The new
megavaultAllOwnerSharesmethod is properly added and implemented.These changes ensure that the RPC query extension correctly exposes the updated and new methods.
Line range hint
1-137: Overall assessment: Well-implemented changes with minor suggestions for improvement.The changes in this file successfully introduce the new
megavaultAllOwnerSharesquery and update themegavaultOwnerSharesquery. The modifications are consistent across theQueryinterface,QueryClientImplclass, andcreateRpcQueryExtensionfunction. These changes enhance the querying capabilities for megavault owner shares.Key points:
- New
megavaultAllOwnerSharesmethod added to query all owner shares.megavaultOwnerSharesmethod updated to require a request parameter, improving type safety.- Proper implementation and binding of new and updated methods in
QueryClientImpl.- Consistent updates in the
createRpcQueryExtensionfunction.Suggestions for further improvement:
- Add brief comments to clarify the distinction between
megavaultOwnerSharesandmegavaultAllOwnerShares.- Consider implementing error handling for RPC calls in the
QueryClientImplmethods.These changes align well with the PR objectives of introducing a new query related to megavault owner shares.
protocol/x/vault/keeper/grpc_query_shares.go (2)
55-62: Verify mathematical correctness of equity calculationsThe calculations for
ownerEquityandownerWithdrawableEquityinvolve multiple big integer operations. It's important to verify that these computations accurately reflect the intended financial logic.Consider writing unit tests to cover scenarios with various share amounts, including edge cases like zero shares and maximum possible shares. This will help ensure that the calculations are correct and handle all possible inputs appropriately.
Line range hint
72-101: Well-implementedMegavaultAllOwnerSharesmethodThe
MegavaultAllOwnerSharesfunction is effectively implemented, handling pagination correctly and ensuring robust error handling during the iteration over the store.proto/dydxprotocol/vault/query.proto (1)
39-44: LGTM: Addition of new RPC method 'MegavaultAllOwnerShares'The new RPC method
MegavaultAllOwnerSharesis correctly defined with appropriate request and response messages, and the HTTP GET endpoint is properly specified.protocol/x/vault/keeper/grpc_query_shares_test.go (2)
Line range hint
17-98: Test functionTestMegavaultAllOwnerSharesupdated correctly with comprehensive test casesThe updated function
TestMegavaultAllOwnerSharescorrectly reflects the new request type and includes thorough test cases for different scenarios, such as success with owners, success with no owners, and error handling for nil requests.
100-265: New test functionTestMegavaultOwnerSharesadds comprehensive coverageThe newly added
TestMegavaultOwnerSharesfunction provides extensive test cases covering various scenarios, including:
- Success cases with zero, one, and two share unlocks.
- Error cases for non-existent owners and nil requests.
This enhances the robustness of the testing suite by ensuring the
MegavaultOwnerSharesquery behaves as expected under different conditions.indexer/packages/v4-protos/src/codegen/dydxprotocol/vault/query.ts (3)
144-160: Enhancement: Added detailed fields toQueryMegavaultOwnerSharesResponse.The addition of fields like
address,shares,shareUnlocks,equity, andwithdrawableEquityenriches the response data, providing more comprehensive information about the owner's shares in the megavault.
186-201: Introduction ofQueryMegavaultAllOwnerSharesRequestandResponseinterfaces.The new interfaces facilitate querying all owner shares with pagination support, enhancing the querying capabilities for the megavault.
128-128: Update usages to include the requiredaddressfield inQueryMegavaultOwnerSharesRequest.The
QueryMegavaultOwnerSharesRequestinterface now requires anaddressfield. Please ensure that all code instances creating this request provide theaddressparameter, replacing any prior usage ofpagination.Run the following script to identify any instances that may need updating:
Also applies to: 136-136
| shareUnlocks, exists := k.GetOwnerShareUnlocks(ctx, req.Address) | ||
| totalLockedShares := big.NewInt(0) | ||
| if exists { | ||
| totalLockedShares = shareUnlocks.GetTotalLockedShares() | ||
| } |
There was a problem hiding this comment.
Potential nil dereference of shareUnlocks
At lines 43-47, if exists is false, shareUnlocks will be uninitialized or nil. However, at line 66, shareUnlocks.ShareUnlocks is accessed without checking if shareUnlocks is nil, which could lead to a nil pointer dereference.
To prevent a possible runtime panic, ensure that shareUnlocks is properly initialized when it does not exist. You can modify the code as follows:
ownerShares, exists := k.GetOwnerShares(ctx, req.Address)
if !exists {
return nil, status.Error(codes.NotFound, "owner not found")
}
+shareUnlocks := &types.OwnerShareUnlocks{}
totalLockedShares := big.NewInt(0)
if unlocksExist {
shareUnlocks, unlocksExist = k.GetOwnerShareUnlocks(ctx, req.Address)
totalLockedShares = shareUnlocks.GetTotalLockedShares()
}Alternatively, check for nil before accessing shareUnlocks.ShareUnlocks when constructing the response.
Committable suggestion was skipped due to low confidence.
| @@ -1,9 +1,10 @@ | |||
| syntax = "proto3"; | |||
| package dydxprotocol.vault; | |||
|
|
|||
| import "cosmos_proto/cosmos.proto"; | |||
There was a problem hiding this comment.
Fix missing import 'cosmos_proto/cosmos.proto'
The imported file cosmos_proto/cosmos.proto does not exist, causing compilation errors. Please verify the import path or ensure that the file is included in your project dependencies.
If the path is incorrect, update it to point to the correct location of cosmos.proto. Otherwise, include the necessary dependency in your build configuration.
Tools
buf
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (2)
proto/dydxprotocol/vault/query.proto (1)
121-140: LGTM: Enhanced QueryMegavaultOwnerSharesResponse with detailed owner informationThe changes to
QueryMegavaultOwnerSharesResponsesignificantly improve the amount of information provided about an owner's shares and equity in the megavault. The new fields (address, shares, share_unlocks, equity, and withdrawable_equity) offer a comprehensive view of an owner's position.The use of appropriate gogoproto options and clear comments for each field is commendable.
Consider adding units to the comments for
equityandwithdrawable_equityfields for extra clarity:- // Owner equity in megavault (in quote quantums). + // Owner equity in megavault (in quote quantums, smallest unit of the quote asset). - // Equity that owner can withdraw in quote quantums (as one cannot - // withdraw locked shares). + // Equity that owner can withdraw (in quote quantums, smallest unit of the quote asset). + // This excludes locked shares which cannot be withdrawn.protocol/x/vault/keeper/grpc_query_shares_test.go (1)
100-274: LGTM: Comprehensive test cases for MegavaultOwnerShares query with a minor suggestionThe
TestMegavaultOwnerSharesfunction provides an extensive set of test cases for theMegavaultOwnerSharesquery. It covers various scenarios including zero unlocks, single unlock, multiple unlocks, and error cases. The equity calculations and test setup, including the initialization of the megavault main vault, are well-implemented.Consider adding a test case for when the total shares are zero to ensure the function handles potential division by zero errors gracefully. This edge case could occur in real-world scenarios and it's important to verify the behavior.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
protocol/x/vault/types/query.pb.gois excluded by!**/*.pb.goprotocol/x/vault/types/query.pb.gw.gois excluded by!**/*.pb.gw.go
Files selected for processing (7)
- indexer/packages/v4-protos/src/codegen/dydxprotocol/vault/query.lcd.ts (4 hunks)
- indexer/packages/v4-protos/src/codegen/dydxprotocol/vault/query.rpc.Query.ts (5 hunks)
- indexer/packages/v4-protos/src/codegen/dydxprotocol/vault/query.ts (7 hunks)
- proto/dydxprotocol/vault/query.proto (3 hunks)
- protocol/x/vault/client/cli/query.go (3 hunks)
- protocol/x/vault/keeper/grpc_query_shares.go (3 hunks)
- protocol/x/vault/keeper/grpc_query_shares_test.go (5 hunks)
Files skipped from review as they are similar to previous changes (4)
- indexer/packages/v4-protos/src/codegen/dydxprotocol/vault/query.lcd.ts
- indexer/packages/v4-protos/src/codegen/dydxprotocol/vault/query.rpc.Query.ts
- protocol/x/vault/client/cli/query.go
- protocol/x/vault/keeper/grpc_query_shares.go
Additional context used
buf
proto/dydxprotocol/vault/query.proto
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
Additional comments not posted (15)
proto/dydxprotocol/vault/query.proto (5)
39-44: LGTM: New RPC method for querying all megavault owner sharesThe addition of the
MegavaultAllOwnerSharesRPC method to the Query service is well-implemented. It provides a way to query all owner shares of the megavault, which enhances the functionality of the vault system.The method signature, request/response types, and HTTP GET endpoint are all correctly defined.
115-115: LGTM: Address field added to QueryMegavaultOwnerSharesRequestThe addition of the
addressfield toQueryMegavaultOwnerSharesRequestis a good improvement. It allows the query to be more specific by providing the owner's address.The use of
(cosmos_proto.scalar) = "cosmos.AddressString"is correct for Cosmos SDK address types, ensuring proper serialization and validation of the address field.
142-146: LGTM: New request message for querying all megavault owner sharesThe addition of
QueryMegavaultAllOwnerSharesRequestis well-structured and appropriate for the new RPC method.The inclusion of a pagination field (of type
cosmos.base.query.v1beta1.PageRequest) is a good practice, allowing for efficient querying of potentially large sets of owner shares.
Line range hint
1-193: Summary: Comprehensive enhancements to megavault querying capabilitiesThe changes in this file significantly improve the querying capabilities for megavault owner shares. Here's a summary of the key enhancements:
- Added a new RPC method
MegavaultAllOwnerSharesto query all owner shares.- Enhanced
QueryMegavaultOwnerSharesRequestandQueryMegavaultOwnerSharesResponsewith more detailed information.- Introduced new message types for querying all owner shares with pagination support.
These changes provide a more comprehensive and flexible way to query megavault information, which should improve the overall functionality of the vault system. The additions are well-structured, consistent with existing code, and follow protobuf best practices.
To ensure all changes are properly integrated, please verify the following:
- The
OwnerSharemessage type is correctly defined or imported.- All new RPC methods are properly implemented in the corresponding Go code.
- The changes are reflected in any client-side code that interacts with these RPCs.
Run the following command to check for any undefined message types:
This will help locate the definition of the
OwnerSharemessage type if it exists in your project.
4-5: Verify the existence of 'cosmos_proto/cosmos.proto' in your project dependenciesThe import of
cosmos_proto/cosmos.protois necessary for using cosmos-related scalar types, and the pagination import is needed for the new pagination-related fields. However, the static analysis tool indicates that thecosmos_proto/cosmos.protofile might be missing.Please ensure that the
cosmos_proto/cosmos.protofile is included in your project dependencies. If it's not present, you may need to add it to your build configuration or update your dependency management.Run the following command to check if the file exists in your project:
If the file is not found, you may need to update your project's dependencies or build configuration.
Tools
buf
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
protocol/x/vault/keeper/grpc_query_shares_test.go (1)
Line range hint
17-98: LGTM: Comprehensive test cases for MegavaultAllOwnerShares queryThe
TestMegavaultAllOwnerSharesfunction provides a thorough set of test cases for theMegavaultAllOwnerSharesquery. It covers successful scenarios with multiple owners, cases with no owners, and error handling for nil requests. The test setup and assertions are well-structured and comprehensive.indexer/packages/v4-protos/src/codegen/dydxprotocol/vault/query.ts (9)
3-3: Added necessary imports from './share'The new imports
NumShares,ShareUnlock, andOwnerShareare appropriately added for use in the updated interfaces.
128-128: Replaced 'pagination' with required 'address' field in QueryMegavaultOwnerSharesRequestThe change to include a required
addressfield enhances the specificity of the request. Ensure that all callers of this interface are updated accordingly.Also applies to: 136-136
145-160: Expanded QueryMegavaultOwnerSharesResponse with detailed owner share informationThe addition of
address,shares,shareUnlocks,equity, andwithdrawableEquityfields provides comprehensive data about the owner's shares and equity in the megavault.Also applies to: 168-184
186-193: Introduced QueryMegavaultAllOwnerSharesRequest for querying all owner sharesThe new interface with optional
paginationsupports retrieval of all owner shares, facilitating broader queries.Also applies to: 199-201
207-216: Added QueryMegavaultAllOwnerSharesResponse to handle responses for all owner sharesIncluding
ownerSharesarray and optionalpaginationaligns with the request interface and enhances response handling.Also applies to: 216-217
Line range hint
729-766: Implemented encode/decode functions for QueryMegavaultOwnerSharesRequestThe
addressfield is correctly encoded and decoded, ensuring proper serialization of the request.
774-855: Implemented encode/decode functions for QueryMegavaultOwnerSharesResponseAll new fields are correctly handled in
encode,decode, andfromPartialmethods with appropriate field numbers and initializations.
856-899: Implemented QueryMegavaultAllOwnerSharesRequest encode/decode functionsThe
paginationfield is properly managed, allowing for correct serialization of requests.
Line range hint
900-949: Implemented QueryMegavaultAllOwnerSharesResponse encode/decode functionsThe encoding and decoding of
ownerSharesandpaginationensure accurate response serialization.
| // QueryMegavaultAllOwnerSharesRequest is a request type for the | ||
| // MegavaultAllOwnerShares RPC method. | ||
| message QueryMegavaultAllOwnerSharesRequest { | ||
| cosmos.base.query.v1beta1.PageRequest pagination = 1; |
There was a problem hiding this comment.
oh this was the old MegavaultOwnerSharesRequest and it lists out all owner shares
proto/dydxprotocol/vault/query.proto
Outdated
| @@ -35,6 +36,12 @@ service Query { | |||
| returns (QueryMegavaultOwnerSharesResponse) { | |||
| option (google.api.http).get = "/dydxprotocol/vault/megavault/owner_shares"; | |||
There was a problem hiding this comment.
nit:
| option (google.api.http).get = "/dydxprotocol/vault/megavault/owner_shares"; | |
| option (google.api.http).get = "/dydxprotocol/vault/megavault/owner_shares/{address}"; |
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
protocol/x/vault/types/query.pb.gois excluded by!**/*.pb.goprotocol/x/vault/types/query.pb.gw.gois excluded by!**/*.pb.gw.go
<details>
Files selected for processing (2)
- indexer/packages/v4-protos/src/codegen/dydxprotocol/vault/query.lcd.ts (4 hunks)
- proto/dydxprotocol/vault/query.proto (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- indexer/packages/v4-protos/src/codegen/dydxprotocol/vault/query.lcd.ts
Additional context used
buf
proto/dydxprotocol/vault/query.proto
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
Additional comments not posted (6)
proto/dydxprotocol/vault/query.proto (6)
5-5: LGTM: Pagination import addedThe addition of the import for pagination is correct and necessary for the new pagination-related fields in the query messages.
37-44: LGTM: New query method and updated HTTP optionThe changes to the Query service are well-implemented:
- The updated HTTP GET option for
MegavaultOwnerSharesnow includes the address parameter, allowing for more specific queries.- The new
MegavaultAllOwnerSharesmethod has been added, which aligns with the PR objective of querying all megavault owner shares.These changes enhance the querying capabilities for megavault owner shares as intended.
116-116: LGTM: Address field added to QueryMegavaultOwnerSharesRequestThe addition of the address field with the
(cosmos_proto.scalar)option is correct and aligns with the updated query functionality.Note: The effectiveness of this change depends on resolving the
cosmos_proto/cosmos.protoimport issue mentioned earlier.
122-141: LGTM: Expanded QueryMegavaultOwnerSharesResponseThe expansion of the
QueryMegavaultOwnerSharesResponsemessage is well-implemented:
- It now includes detailed information about the owner's shares, equity, and withdrawable equity.
- The use of
(gogoproto.nullable) = falseensures that these fields are always present in the response.- The custom types for equity fields use the appropriate serializable integer type.
These changes provide a comprehensive response for megavault owner share queries, which aligns with the PR objectives.
145-147: LGTM: New QueryMegavaultAllOwnerSharesRequest messageThe new
QueryMegavaultAllOwnerSharesRequestmessage is well-defined:
- It includes a pagination field, which is essential for handling large datasets of owner shares.
- The use of the imported pagination request type is correct.
This message type properly supports the new
MegavaultAllOwnerSharesRPC method.
4-4: Verify the import path for 'cosmos_proto/cosmos.proto'The static analysis tool indicates that the file "cosmos_proto/cosmos.proto" does not exist. This import is crucial for the
(cosmos_proto.scalar)option used in the message definitions.Please run the following script to check if the file exists in the project or its dependencies:
If the file is not found, ensure that the correct dependency is included in your project or update the import path accordingly.
Verification successful
Import path for 'cosmos_proto/cosmos.proto' verified.
The file
"cosmos_proto/cosmos.proto"exists in the project, ensuring that the import statement is correct. The initial concern regarding the missing import has been resolved.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if cosmos_proto/cosmos.proto exists if fd -t f "cosmos_proto/cosmos.proto"; then echo "File found" else echo "File not found" echo "Searching for similar files:" fd -t f "cosmos.*proto" fiLength of output: 66
Tools
buf
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
Changelist
query for owner shares, locked shares, their proportion of equity, and how much is withdrawable
Test Plan
[Describe how this PR was tested (if applicable)]
Author/Reviewer Checklist
state-breakinglabel.indexer-postgres-breakinglabel.PrepareProposalorProcessProposal, manually add the labelproposal-breaking.feature:[feature-name].backport/[branch-name].refactor,chore,bug.Summary by CodeRabbit
Summary by CodeRabbit