This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Resolution (macOS): improve detection #2356
Open
CarterLi
wants to merge
1
commit into
dylanaraps:master
Choose a base branch
from
CarterLi:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hykilpikonna
approved these changes
Aug 10, 2023
hykilpikonna
added a commit
to hykilpikonna/hyfetch
that referenced
this pull request
Aug 10, 2023
…rove detection Upstream PR: dylanaraps/neofetch#2356 Thanks to @CarterLi Co-authored-by: 李通洲 <zhangsongcui3371@sina.com>
hykilpikonna
added a commit
to hykilpikonna/hyfetch
that referenced
this pull request
Aug 10, 2023
Thank you for your contribution! This PR is merged into hyfetch since this repo (dylanaraps/neofetch) seems no longer maintained. HyFetch is a fork of neofetch with LGBTQ pride flags, but the repo also maintains an updated version of the original neofetch, addressing many pull requests that are not merged in the original repo. Read the "Running Updated Original Neofetch" section for more info! |
Also just fixed some shellcheck warnings for you in hykilpikonna/hyfetch@526c97f |
1. fix detection when `screenresolution` is not available 2. make scale factor detection actually work 3. remove `screenresolution` dependency EDIT: applied changes suggested by @hykilpikonna and fixed a [bug](hykilpikonna/hyfetch#196) that neofetch fails to print scale factors when `system_profiler` fails to detect refresh rates.
1 task
Applied changes suggested by @hykilpikonna and fixed a bug that neofetch fails to print scale factors when |
hykilpikonna
added a commit
to hykilpikonna/hyfetch
that referenced
this pull request
Oct 11, 2023
…rove detection Upstream PR: dylanaraps/neofetch#2356 Thanks to @CarterLi Co-authored-by: 李通洲 <zhangsongcui3371@sina.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
screenresolution
is not availablescreenresolution
dependencyBefore
After