Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Resolution (macOS): improve detection #2356

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CarterLi
Copy link

@CarterLi CarterLi commented Aug 8, 2023

  1. fix detection when screenresolution is not available
  2. make scale factor detection actually work
  3. remove screenresolution dependency

Before

image

  • neofetch reports the native / maximum resolution for the built-in display, instead of current scaled output resolution
  • neofetch reports the output resolution for the external display, instead of scaled resolution
  • neofetch fails to detect refresh rate for both displays
  • neofetch fails to detect the scale factor, though it tries to detect it in the code

After

image

@CarterLi
Copy link
Author

CarterLi commented Aug 8, 2023

Ad: besides other fixes and improvements, detect these sh*t 10 times faster using fastfetch

image

@hykilpikonna
Copy link

Work on non-hidpi displays as well!

image

hykilpikonna added a commit to hykilpikonna/hyfetch that referenced this pull request Aug 10, 2023
…rove detection

Upstream PR: dylanaraps/neofetch#2356
Thanks to @CarterLi

Co-authored-by: 李通洲 <zhangsongcui3371@sina.com>
hykilpikonna added a commit to hykilpikonna/hyfetch that referenced this pull request Aug 10, 2023
@hykilpikonna
Copy link

Thank you for your contribution!

This PR is merged into hyfetch since this repo (dylanaraps/neofetch) seems no longer maintained.

HyFetch is a fork of neofetch with LGBTQ pride flags, but the repo also maintains an updated version of the original neofetch, addressing many pull requests that are not merged in the original repo.

Read the "Running Updated Original Neofetch" section for more info!

@hykilpikonna
Copy link

Also just fixed some shellcheck warnings for you in hykilpikonna/hyfetch@526c97f

1. fix detection when `screenresolution` is not available
2. make scale factor detection actually work
3. remove `screenresolution` dependency

EDIT: applied changes suggested by @hykilpikonna and fixed a
[bug](hykilpikonna/hyfetch#196) that neofetch
fails to print scale factors when `system_profiler` fails to detect
refresh rates.
@CarterLi
Copy link
Author

Applied changes suggested by @hykilpikonna and fixed a bug that neofetch fails to print scale factors when system_profiler fails to detect refresh rates.

hykilpikonna added a commit to hykilpikonna/hyfetch that referenced this pull request Oct 11, 2023
…rove detection

Upstream PR: dylanaraps/neofetch#2356
Thanks to @CarterLi

Co-authored-by: 李通洲 <zhangsongcui3371@sina.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants