This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Improve wayland wm detection #2430
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- permission denied spam from fuser was getting conflated into stdout - unquote the inner $tmp_pid refereence, so that the shell will strip whitespace properly around the output pid number
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On my arch system running the river wm, get_wm wasn't working.
First off, I'd had no reason to install lsof as yet, having only fuser.
Next up the output of fuser was way more than the expected "just a pid": it included a bunch of permission denied entries while enumerating all non-user procs, and also some extra whitespace around the output pid, which was interacting poorly with the defensive quoting inside the sub-shell expansion of $tmp_pid.
TODO