Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing CI for Node 4 #326

Merged
merged 2 commits into from
Jul 18, 2019
Merged

Fixing CI for Node 4 #326

merged 2 commits into from
Jul 18, 2019

Conversation

mansona
Copy link
Contributor

@mansona mansona commented Jan 13, 2019

I noticed that CI was broken on one of my other PRs #323 because apparently Yarn doesn't support Node 4

I'm not trying to open a can of worms with the whole "npm vs Yarn" debate, all I know is that CI is currently broken and this PR fixes the issue 👍

I also added testing in Node 8 and 10 for good measure 🎉

@LinusU
Copy link
Collaborator

LinusU commented Jan 14, 2019

I'm okay with switching to npm, what do you think @dylang? ☺️

@lorenzleutgeb
Copy link

lorenzleutgeb commented Jul 3, 2019

I just proposed similar changes in #351 and #352. I didn't touch lockfiles, however. @mansona maybe you could update your PR by also including Node 12 which has since been released and is now the most current LTS.

@mansona
Copy link
Contributor Author

mansona commented Jul 3, 2019

@lorenzleutgeb I have updated the PR as requested. I haven't removed the old node versions that are EOL right now (4 and 6) because that would require a major version bump of npm-check

If this passes we can at least get it merged and then decide to drop node 4 and node 6 support later 👍

@lorenzleutgeb
Copy link

Not sure if removing a testing environment from build automation constitutes a breaking change. No interface to the outside world is being changed. But I get your point that it would be more diligent to test with Node 4 as well :)

Now let's hope some maintainers are around...

@mansona
Copy link
Contributor Author

mansona commented Jul 3, 2019

I am part of one of the Ember core teams and we have a policy that when you stop testing a particular version you're dropping support for that version. Essentially if anyone adds a small change (like arrow functions) you won't notice that it breaks the build in Node 4 because you're not testing it anymore 😄 It's why I wanted to fix CI in the first place so that it was still a clear intent of versions that you want to support 👍

@mcmxcdev
Copy link

mcmxcdev commented Jul 3, 2019

Agreeing with @mansona here, it is very common that JS libraries bump up a major version when they drop support for an older node version.

@LinusU LinusU merged commit f569c7d into dylang:master Jul 18, 2019
@LinusU
Copy link
Collaborator

LinusU commented Jul 18, 2019

Thanks!

[...] it is very common that JS libraries bump up a major version when they drop support for an older node version.

Yeah, this is definitely how it should be done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants