Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validation should include buffer as acceptable type #8

Merged
merged 2 commits into from
Sep 4, 2024
Merged

fix: validation should include buffer as acceptable type #8

merged 2 commits into from
Sep 4, 2024

Conversation

nilslice
Copy link
Member

@nilslice nilslice commented Sep 4, 2024

Fix from change in #5

I have also bumped the package.json version if we're good to go and can release this

chrisdickinson
chrisdickinson approved these changes Sep 4, 2024
View reviewed changes
Copy link

@chrisdickinson chrisdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nilslice nilslice merged commit 68c92f8 into main Sep 4, 2024
3 checks passed
@nilslice nilslice deleted the fix-validation branch September 4, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdickinson chrisdickinson chrisdickinson approved these changes

@mhmd-azeez mhmd-azeez Awaiting requested review from mhmd-azeez mhmd-azeez is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilslice @chrisdickinson