-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unpaired surrogate in OsStr on Windows leads to debug_assert failure in v6.4.0 #14
Comments
oconnor663
added a commit
to BLAKE3-team/BLAKE3
that referenced
this issue
Nov 20, 2022
v6.4.0 has a bug where invalid UTF-16 filenames fail a debug_assert on Windows. See dylni/os_str_bytes#14. The vast majority of b3sum users should be running a binary built in release mode and shouldn't be affected by this. This lockfile change fixes our CI, but note that `cargo install` doesn't respect lockfiles by default (without --locked), so anyone running a debug binary against invalid Windows filepaths (very rare) will still need to wait for an upstream patch release.
Thanks for this issue! This has been fixed in version 6.4.1, but I'm surprised this wasn't caught in fuzz testing I performed before the release. The previous version has been yanked as well. However, this should not have caused any incorrect results, aside from the failed assertion, for any Rust version so far. |
Confirmed that v6.4.1 fixes my tests. Thanks for the lightning speed fix! |
kayabaNerve
added a commit
to serai-dex/serai
that referenced
this issue
Nov 21, 2022
Mandated by dylni/os_str_bytes#14.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
My
b3sum
crate depends onos_str_bytes
(6.4.0) indirectly viaclap
(4.0.26), and I have a test case that uses invalid UTF-16 filenames on Windows. 76c28d5#diff-3b7ba22f3645054b5b1c07651b4c378e01c0f8eda295e24e4bedf4e6e3a79382R72 added adebug_assert
that is failing in CI for me. The following is a minimized repro of what I think is causing the crash:The text was updated successfully, but these errors were encountered: