Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

funds stuck in x/dist when failed to allocate to sequencer #357

Closed
omritoptix opened this issue Apr 4, 2024 · 0 comments · Fixed by #358
Closed

funds stuck in x/dist when failed to allocate to sequencer #357

omritoptix opened this issue Apr 4, 2024 · 0 comments · Fixed by #358
Assignees
@danwt
Labels
bug Something isn't working

Comments

@omritoptix
Copy link
Contributor

In x/dist/keeper/allocation.go:40-44, if there is an error in AllocateTokensToSequencer, the remainingFees is still deducted with the proposerReward. This would cause funds to be left in the x/dist module, which will not be distributed. We recommend not deducting the remainingFees if an error occurs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danwt danwt

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@omritoptix @danwt