Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(allocation): do not destroy fee rewards if allocating to proposer fails #358

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

danwt
Copy link
Contributor

@danwt danwt commented Apr 5, 2024

PR Standards

Opening a pull request should be able to meet the following requirements


Closes #357

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@danwt danwt changed the title fix(allocation): TODO fix(allocation): do not destroy fee rewards if allocating to proposer fails Apr 5, 2024
@danwt danwt marked this pull request as ready for review April 5, 2024 09:04
@danwt danwt requested a review from a team as a code owner April 5, 2024 09:04
@omritoptix omritoptix merged commit bfd0943 into main Apr 5, 2024
6 checks passed
@omritoptix omritoptix deleted the danwt/357-fix-stuck-funds-in-allocation branch April 5, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

funds stuck in x/dist when failed to allocate to sequencer
3 participants