Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rollapp genesis token locking upon channel creation #333

Merged
merged 32 commits into from
Mar 19, 2024

Conversation

omritoptix
Copy link
Contributor

@omritoptix omritoptix commented Mar 18, 2024

PR Standards

Opening a pull request should be able to meet the following requirements


The previous PR for this branch was merged to the wrong branch, hence it was reverted and re-created targeting main.
Since it depends on this #321 , should wait until it's merged to main to keep the diff cleaner and not create merge conflicts.

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

…-inflation-rate-adjustments' into feature/add-hub-genesis-module
@omritoptix omritoptix requested a review from a team as a code owner March 18, 2024 15:56
@omritoptix omritoptix marked this pull request as draft March 18, 2024 15:57
@omritoptix omritoptix changed the title feat: Rollapp genesis token locking upon channel creation feat: rollapp genesis token locking upon channel creation Mar 18, 2024
zale144
zale144 previously approved these changes Mar 19, 2024
@zale144 zale144 marked this pull request as ready for review March 19, 2024 09:55
@omritoptix omritoptix merged commit 4bbdcda into main Mar 19, 2024
2 checks passed
@omritoptix omritoptix deleted the feature/add-hub-genesis-module branch March 19, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants