Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sequencers): sequencers genesis operator address not exported #367

Merged

Conversation

mtsitrin
Copy link
Collaborator

@mtsitrin mtsitrin commented Apr 8, 2024

PR Standards

Opening a pull request should be able to meet the following requirements


Closes #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@mtsitrin mtsitrin requested a review from a team as a code owner April 8, 2024 07:27
@mtsitrin mtsitrin linked an issue Apr 8, 2024 that may be closed by this pull request
@mtsitrin mtsitrin changed the title fix: sequencers genesis operator address not exported fix(sequencers): sequencers genesis operator address not exported Apr 8, 2024
@mtsitrin mtsitrin self-assigned this Apr 8, 2024
Copy link
Contributor

@danwt danwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved but asked for clarification in a comment

Comment on lines +32 to +39
// init dymint sequencer as expected for initGenesis
pubkey := utils.CreateTestPubKeys(1)[0]
tmPubkey, err := cryptocodec.ToTmProtoPublicKey(pubkey)
require.NoError(t, err)
dymintSeq := abci.ValidatorUpdate{
PubKey: tmPubkey,
Power: 1,
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// init dymint sequencer as expected for initGenesis
pubkey := utils.CreateTestPubKeys(1)[0]
tmPubkey, err := cryptocodec.ToTmProtoPublicKey(pubkey)
require.NoError(t, err)
dymintSeq := abci.ValidatorUpdate{
PubKey: tmPubkey,
Power: 1,
}
// init dymint sequencer as expected for initGenesis, this is arbitrary/dummy
pubkey := utils.CreateTestPubKeys(1)[0]
tmPubkey, err := cryptocodec.ToTmProtoPublicKey(pubkey)
require.NoError(t, err)
dymintSeq := abci.ValidatorUpdate{
PubKey: tmPubkey,
Power: 1,
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a little confusing here without remembering all the details, would be good to clarify a little in a comment

@mtsitrin mtsitrin merged commit 2a1f308 into main Apr 8, 2024
7 checks passed
@mtsitrin mtsitrin deleted the mtsitrin/352-sequencers-genesis_operator_address-not-exported branch April 8, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sequencers: genesis_operator_address not exported
2 participants