-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sequencers): sequencers genesis operator address not exported #367
fix(sequencers): sequencers genesis operator address not exported #367
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved but asked for clarification in a comment
// init dymint sequencer as expected for initGenesis | ||
pubkey := utils.CreateTestPubKeys(1)[0] | ||
tmPubkey, err := cryptocodec.ToTmProtoPublicKey(pubkey) | ||
require.NoError(t, err) | ||
dymintSeq := abci.ValidatorUpdate{ | ||
PubKey: tmPubkey, | ||
Power: 1, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// init dymint sequencer as expected for initGenesis | |
pubkey := utils.CreateTestPubKeys(1)[0] | |
tmPubkey, err := cryptocodec.ToTmProtoPublicKey(pubkey) | |
require.NoError(t, err) | |
dymintSeq := abci.ValidatorUpdate{ | |
PubKey: tmPubkey, | |
Power: 1, | |
} | |
// init dymint sequencer as expected for initGenesis, this is arbitrary/dummy | |
pubkey := utils.CreateTestPubKeys(1)[0] | |
tmPubkey, err := cryptocodec.ToTmProtoPublicKey(pubkey) | |
require.NoError(t, err) | |
dymintSeq := abci.ValidatorUpdate{ | |
PubKey: tmPubkey, | |
Power: 1, | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a little confusing here without remembering all the details, would be good to clarify a little in a comment
PR Standards
Opening a pull request should be able to meet the following requirements
Closes #XXX
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
For Author:
godoc
commentsFor Reviewer:
After reviewer approval: