Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(genesis bridge): better UX for chains without genesis transfers #458

Merged
merged 80 commits into from
Jun 24, 2024
Merged

fix(genesis bridge): better UX for chains without genesis transfers #458

merged 80 commits into from
Jun 24, 2024

Conversation

danwt
Copy link
Contributor

@danwt danwt commented Jun 19, 2024 •
edited
Loading

PR Standards

Opening a pull request should be able to meet the following requirements

see also hub pr dymensionxyz/dymension#961

Closes #457, #459

This PR also addresses missed comments from
#449 (comment)
#449 (comment)
#449 (comment)
#449 (comment)

#449 (comment) will be fixed in #462

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@danwt danwt requested a review from a team as a code owner June 19, 2024 15:46
@danwt danwt marked this pull request as draft June 20, 2024 09:53
@danwt danwt marked this pull request as ready for review June 20, 2024 11:44
@danwt danwt mentioned this pull request Jun 20, 2024
Merged
29 tasks
@danwt danwt requested a review from mtsitrin June 20, 2024 11:44
@danwt danwt mentioned this pull request Jun 20, 2024
Merged
29 tasks
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 21, 2024
View reviewed changes
x/hub-genesis/types/state.go Dismissed Show dismissed Hide dismissed
@danwt danwt mentioned this pull request Jun 21, 2024
Merged
12 tasks
mtsitrin
mtsitrin reviewed Jun 23, 2024
View reviewed changes
proto/hub-genesis/genesis.proto Show resolved Hide resolved
proto/hub-genesis/state.proto Show resolved Hide resolved
x/hub-genesis/keeper/ibc_module.go Show resolved Hide resolved
x/hub-genesis/keeper/ibc_module.go Outdated Show resolved Hide resolved
@danwt danwt requested a review from mtsitrin June 24, 2024 13:25
@mtsitrin mtsitrin merged commit fd8806d into main Jun 24, 2024
7 checks passed
@mtsitrin mtsitrin deleted the danwt/457-move-transfersenabled branch June 24, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtsitrin mtsitrin Awaiting requested review from mtsitrin

Assignees
No one assigned
Labels
dym-internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Genesis bridge: better UX for chains without genesis transfers
2 participants
@danwt @mtsitrin