Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): adds a doc.go for hub genesis #478

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

danwt
Copy link
Contributor

@danwt danwt commented Jul 8, 2024

PR Standards

Opening a pull request should be able to meet the following requirements


Closes #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@danwt danwt requested a review from a team as a code owner July 8, 2024 14:46
@mtsitrin mtsitrin merged commit 23b96de into main Jul 8, 2024
7 checks passed
@mtsitrin mtsitrin deleted the danwt/add-doc-file-for-hub-genesis branch July 8, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants