Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hub-genesis): added a query to generate genesis bridge data #609

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

keruch
Copy link
Contributor

@keruch keruch commented Nov 27, 2024

Description


Closes #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here


For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@keruch keruch self-assigned this Nov 27, 2024
@keruch keruch requested a review from a team as a code owner November 27, 2024 14:38
go.mod Outdated Show resolved Hide resolved
@keruch keruch requested a review from zale144 November 28, 2024 22:25
Copy link
Collaborator

@mtsitrin mtsitrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
small comment

// PrepareGenesisBridgeData prepares the genesis bridge data.
// Bridge data contains the genesis transfer packet data if the genesis accounts are defined, otherwise it's nil.
// Additionally, the method returns the packet coin (if any) that will be used for the escrow.
func (k Keeper) PrepareGenesisBridgeData(ctx sdk.Context) (types.GenesisBridgeData, sdk.Coin, error) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why u need to return packetCoin? it can be extracted from data.GenesisTransfer if needed by caller

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, removed it. did a separate method:

// BaseCoinSupply returns the total supply of the base denom: the sum of all the genesis account amounts.
func (g GenesisInfo) BaseCoinSupply() sdk.Coin {
	amount := sdk.ZeroInt()
	for _, acc := range g.GenesisAccounts {
		amount = amount.Add(acc.Amount)
	}
	return sdk.NewCoin(g.BaseDenom(), amount)
}

mtsitrin
mtsitrin previously approved these changes Dec 1, 2024
@omritoptix omritoptix merged commit ffec6e8 into main Dec 2, 2024
7 checks passed
@omritoptix omritoptix deleted the kirill/441-genesis-bridge-validation branch December 2, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants