feat(hub-genesis): whitelisted address trigger genesis transfer #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtsitrin
reviewed
Dec 10, 2024
mtsitrin
reviewed
Dec 10, 2024
mtsitrin
previously approved these changes
Dec 10, 2024
mtsitrin
previously approved these changes
Dec 10, 2024
| return err | ||
| } | ||
|
|
||
| if !ack.Success() { | ||
| w.logger(ctx).Error("acknowledgement failed for genesis transfer", "packet", packet, "ack", ack) | ||
| return errors.New("acknowledgement failed for genesis transfer") | ||
| // something wrong - need to fix the hub with gov prop and try to send transfer again |
There was a problem hiding this comment.
why u removed the logging?
omritoptix
reviewed
Dec 10, 2024
x/hub-genesis/keeper/msg_server.go
Outdated
| if !state.CanonicalHubTransferChannelHasBeenSet() { | ||
| state.SetCanonicalTransferChannel(port, channelID) | ||
| } | ||
| if state.HubPortAndChannel.Channel != channelID { |
There was a problem hiding this comment.
lets assume a bug in relayer and sent wrong channel id with the hub.
in that case after first attempt we're gonna set it (SetCanonicalTransferChannel).
Than we find out it's acutally a different channel which is the canonical on the hub.
Than we try again, but fail with channel id mismatch.
Why dot we not simply try every time with the passed channel given we're not in flight (vs setting the first channel attempt as the only one)? ( we will need to clear the canonical transfser channel on ack err though)
omritoptix
reviewed
Dec 10, 2024
omritoptix
changed the title
omritoptix
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goes with dymensionxyz/dymension#1637
Description
Closes #624
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleasedsection inCHANGELOG.mdgodoccommentsSDK Checklist
maptime.Now()sendCoinand notSendCoinsFull security checklist here
For Reviewer:
After reviewer approval: