support dymint signatures verification + add dymint to the default-al…

…lowrd-clients list (#23)

modules/core/02-client/types/params.go

@@ -10,8 +10,8 @@ import (
 )
 
 var (
-	// DefaultAllowedClients are "06-solomachine" and "07-tendermint"
-	DefaultAllowedClients = []string{exported.Solomachine, exported.Tendermint}
+	// DefaultAllowedClients are "01-dymint", "06-solomachine" and "07-tendermint"
+	DefaultAllowedClients = []string{exported.Dymint, exported.Solomachine, exported.Tendermint}
 
 	// KeyAllowedClients is store's key for AllowedClients Params
 	KeyAllowedClients = []byte("AllowedClients")

modules/light-clients/01-dymint/types/header.go

@@ -88,7 +88,6 @@ func (h Header) ValidateBasic() error {
 
 // ValidateCommit checks if the given commit is a valid commit from the passed-in validatorset
 func (h Header) ValidateCommit() (err error) {
-	chainID := h.Header.ChainID
 	blockID, err := tmtypes.BlockIDFromProto(&h.SignedHeader.Commit.BlockID)
 	if err != nil {
 		return sdkerrors.Wrap(err, "invalid block ID from header SignedHeader.Commit")
@@ -116,15 +115,16 @@ func (h Header) ValidateCommit() (err error) {
 			return sdkerrors.Wrap(clienttypes.ErrInvalidHeader, "validator set did not commit to header")
 		}
 		// Validate signature.
-		voteSignBytes := tmCommit.VoteSignBytes(chainID, valIdx)
 		if !bytes.Equal(commitSig.ValidatorAddress, h.Header.ProposerAddress) {
 			return fmt.Errorf("wrong proposer address in commit, got %X) but expected %X", valIdx, h.Header.ProposerAddress)
 		}
-		if !val.PubKey.VerifySignature(voteSignBytes, commitSig.Signature) {
+		headerBytes, err := h.SignedHeader.Header.Marshal()
+		if err != nil {
+			return err
+		}
+		if !val.PubKey.VerifySignature(headerBytes, commitSig.Signature) {
 			return fmt.Errorf("wrong signature (#%d): %X", valIdx, commitSig.Signature)
 		}
-	} else {
-		return sdkerrors.Wrap(clienttypes.ErrInvalidHeader, "validator set did not commit to header")
 	}
 
 	return nil