Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 5.1.0 #32

Merged
merged 159 commits into from
May 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
159 commits
Select commit Hold shift + click to select a range
9d79e86
Backport commits from main to v3 release branch (#682)
colin-axner Jan 5, 2022
151907a
improve 04-channel logging (#692) (#698)
mergify[bot] Jan 10, 2022
6738a96
add cli to get denom hash from trace path and base denom (#679) (#711)
mergify[bot] Jan 12, 2022
b482493
removing unused proto imports in interchain-accounts (#718) (#720)
mergify[bot] Jan 12, 2022
22fbe82
fix: support custom chain IDs for testing (#774) (#797)
mergify[bot] Jan 27, 2022
a536701
Merge branch 'release/v3.0.x' of github.com:cosmos/ibc-go into colin/…
colin-axner Jan 31, 2022
d3b0a36
Merge pull request #815 from cosmos/colin/backport-v3
colin-axner Jan 31, 2022
349bddf
Defensive checks for active channel (#785)
seantking Jan 31, 2022
2e6e861
Merge pull request #817 from cosmos/mergify/bp/release/v3.0.x/pr-785
colin-axner Feb 1, 2022
f0ea30a
build(deps): bump github.com/cosmos/cosmos-sdk from 0.44.5 to 0.45.0 …
mergify[bot] Feb 2, 2022
c230603
rename portid and port prefix for interchain accounts submodules (#77…
mergify[bot] Feb 2, 2022
dea0505
test: adding ica test for multiple controllers, single host (#816) (#…
mergify[bot] Feb 2, 2022
60fdc75
the ica_auth page was renamed to auth-modules (#792) (#830)
mergify[bot] Feb 2, 2022
3f882c7
chore: replace error string in transfer acks with const (#818) (#831)
mergify[bot] Feb 2, 2022
5d9e7db
refactor: active channel key format (#823) (#832)
mergify[bot] Feb 2, 2022
6d95456
refactor: RegisterInterchainAccount (#814) (#835)
mergify[bot] Feb 2, 2022
578847c
refactor: reformat KeyOwnerAccount (#833) (#836)
mergify[bot] Feb 2, 2022
3903308
chore: adding encoding and txType fields to metadata (#824) (#837)
mergify[bot] Feb 2, 2022
8306273
refactor: include transaction response in ics27 channel acknowledgeme…
mergify[bot] Feb 2, 2022
a59c033
test: ensure ics27 optimistic packet sends are disallowed (#842) (#843)
mergify[bot] Feb 3, 2022
53cad5d
ADR 003: ICS27 Ack format (#812) (#844)
mergify[bot] Feb 3, 2022
bb867fd
docs: add security model to ics27 docs (#841) (#845)
mergify[bot] Feb 3, 2022
3262969
test: Register using same owner address on multiple connections (#846…
mergify[bot] Feb 4, 2022
c53829f
Move emissions to functions (#783) (#855)
mergify[bot] Feb 7, 2022
402a3bf
build(deps): bump github.com/cosmos/cosmos-sdk from 0.45.0 to 0.45.1 …
mergify[bot] Feb 7, 2022
45a84f2
Added ChannelId to MsgChannelOpenInitResponse (#848) (#856)
mergify[bot] Feb 7, 2022
37bbee1
fix: ica host OnRecvPacket error acknowledgement (#885) (#886)
mergify[bot] Feb 8, 2022
6511e9c
chore: add defensive check to ensure metadata does not change when re…
mergify[bot] Feb 9, 2022
6c9cf52
bug: use custom ante handler to reject redundant transactions in sima…
mergify[bot] Feb 10, 2022
45b8e92
refactor: allow the mock module to be used multiple times as base ibc…
mergify[bot] Feb 10, 2022
2641fa1
imp: support custom keys for testing (#893) (#902)
mergify[bot] Feb 10, 2022
96ca59b
chore: add ParsePacketFromEvents testing helper function (#904) (#919)
mergify[bot] Feb 15, 2022
f418799
fix: correctly claim capability for mock module, handle genesis expor…
mergify[bot] Feb 15, 2022
053e00e
docs: update migration docs for upgrade proposal in relation to ICS27…
mergify[bot] Feb 15, 2022
f68514c
chore(ica): add trail of bits audit report (#903) (#944)
mergify[bot] Feb 17, 2022
5534418
refactor: WriteAcknowledgement API (backport #882) (#943)
mergify[bot] Feb 17, 2022
8c17224
add changelog entry for bump of SDK
Feb 18, 2022
523c596
testing: adding multiple sender accounts for testing purposes (#935) …
mergify[bot] Feb 22, 2022
b604030
fix: classify client states without consensus states as expired (#941…
mergify[bot] Feb 22, 2022
e93162c
Create test chain with multiple validators (#942) (#960)
mergify[bot] Feb 22, 2022
0b18651
chore: update migration docs (#985) (#986)
mergify[bot] Feb 23, 2022
3c33f77
bug: support base denoms with slashes (#978) (#1019)
mergify[bot] Mar 1, 2022
171498a
ibctesting: make `testing.T` public (#1020) (#1030)
mergify[bot] Mar 1, 2022
4af1e62
upgrade ics23 to v0.7 (#948) (#1028)
mergify[bot] Mar 1, 2022
dcb5247
feat: Add a function to initialize the ICS27 module via an upgrade pr…
mergify[bot] Mar 2, 2022
11c018f
fix package import (#1007) (#1036)
mergify[bot] Mar 2, 2022
571ba40
docs: add missing args to NewKeeper in integration docs (#1038) (#1054)
mergify[bot] Mar 3, 2022
e43079e
chore: fix mispelled words (#991) (#1072)
mergify[bot] Mar 3, 2022
6f2bf38
chore: fix broken link (#972) (#1066)
mergify[bot] Mar 3, 2022
2160689
update changelog
Mar 3, 2022
22bea13
small fixes for v2 to v3 migration (#1016) (#1074)
mergify[bot] Mar 4, 2022
227a609
call packet.GetSequence() rather than passing the func as argument (b…
mergify[bot] Mar 8, 2022
5c0bf8b
Add counterpartyChannelID param to IBCModule.OnChanOpenAck (#1086) (#…
mergify[bot] Mar 9, 2022
549d9bf
fix mirgation docs (#1091) (#1092)
mergify[bot] Mar 9, 2022
45fdb81
fix: handle testing update client errors (#1094) (#1095)
mergify[bot] Mar 10, 2022
16c65c6
replace channel keeper with IBC keeper in AnteDecorator (#950) (#1096)
mergify[bot] Mar 10, 2022
1f346a7
ibctesting: custom voting power reduction for testing (#939) (#1104)
mergify[bot] Mar 11, 2022
b3823d4
update changelog
Mar 15, 2022
eaf9d67
update changelog
Mar 15, 2022
6e1b25a
fix: adjust InitModule to account for empty controller and host keepe…
mergify[bot] Mar 15, 2022
fde4494
update changelog
Mar 15, 2022
0ab8568
Merge pull request from GHSA-j658-c98j-fww4 (#1127)
Mar 15, 2022
46e0206
fixes for the documentation about handling ack for SDK <= 0.45 (#1122…
mergify[bot] Mar 15, 2022
10ebf0d
call packet.GetSequence() rather than passing the func as argument (b…
mergify[bot] Mar 21, 2022
d538bc4
fixes for go-releaser configuration (#1148) (#1157)
mergify[bot] Mar 22, 2022
c0a8e81
add versions for new releases (#1175) (#1183)
mergify[bot] Mar 28, 2022
ea52a75
fix typos in the controller params (#1172) (#1182)
mergify[bot] Mar 28, 2022
7662473
requirements document for ICA (#1173) (#1209)
mergify[bot] Apr 4, 2022
f49b8bc
imp: improve Logger performance (#1160) (#1218)
mergify[bot] Apr 6, 2022
73dca92
docs: replace links in apps with correct ones (#1255) (#1261)
mergify[bot] Apr 14, 2022
52f00fb
update godoc of `RegisterInterchainAccount` (#1256) (#1262)
mergify[bot] Apr 14, 2022
70d8472
build(deps): bump github.com/cosmos/cosmos-sdk from 0.45.1 to 0.45.3 …
mergify[bot] Apr 21, 2022
0645553
add missing changelog entry for bump of sdk 0.45.3 (#1272) (#1277)
mergify[bot] Apr 25, 2022
5883227
fixing dead links from sdk default branch update (#1301) (#1303)
mergify[bot] Apr 27, 2022
33b063e
override default docsBranch (#1355) (#1389)
mergify[bot] May 17, 2022
75ee548
build(deps): bump github.com/cosmos/cosmos-sdk from 0.45.3 to 0.45.4 …
mergify[bot] May 18, 2022
f58b8c9
add empty keepers checking in ibc NewKeeper (backport #1284) (#1381)
mergify[bot] May 18, 2022
8111f7a
fix: prefix ResponseResultType enum for proto linting (#1143) (#1392)
mergify[bot] May 18, 2022
41a0733
feat: Add sender to fungible_token_packet events (backport #1414) (#1…
mergify[bot] May 24, 2022
0337676
add swagger for interchain accounts (#1402) (#1410)
mergify[bot] May 24, 2022
c26c51c
add actual parameter example to denom-trace and denom-hash CLI querie…
mergify[bot] May 30, 2022
968d697
Emit channel close event on ordered channel close (backport #1464) (#…
mergify[bot] Jun 2, 2022
d745ace
chore: improve DenomTrace grpc (backport #1342) (#1503)
mergify[bot] Jun 9, 2022
da89037
Emit an event to indicate a successful acknowledgement in the ICA mod…
mergify[bot] Jun 9, 2022
1842464
Update CHANGELOG.md
Jun 14, 2022
b84992c
Update CHANGELOG.md
Jun 14, 2022
23f555c
Update CHANGELOG.md
Jun 14, 2022
df58f1d
Update CHANGELOG.md
Jun 14, 2022
ae866d8
Update versions
Jun 16, 2022
79eeb56
Delete v3-to-v4.md
Jun 20, 2022
53e1594
docs: add upgrade client proposal event (#1596) (#1634)
mergify[bot] Jul 1, 2022
b91ef4e
feat: emitting an event when handling a client upgrade proposal (back…
mergify[bot] Jul 5, 2022
2c986a0
fix broken link (#1776) (#1806)
mergify[bot] Jul 28, 2022
93611dd
fix: add cosmos_proto.implements_interface (backport #1740) (#1815)
mergify[bot] Jul 29, 2022
f0c3d3a
Update CHANGELOG.md
Aug 2, 2022
79a4af5
Update CHANGELOG.md
Aug 2, 2022
3a514ef
Update CHANGELOG.md
Aug 2, 2022
7533807
chore: adding dockerfile and release task to release/3.0.x (#1928)
chatton Aug 9, 2022
0ec1fcc
Fixing github action workflows (backport #1428) (#1937)
mergify[bot] Aug 11, 2022
5c407ab
fix: "acknowledgement written" logs unsupported type (backport #1919)…
mergify[bot] Aug 12, 2022
02b55a3
fix broken link (#2059) (#2094)
mergify[bot] Aug 23, 2022
3252455
chore: fix broken link to bank module spec (backport #2201) (#2206)
mergify[bot] Sep 7, 2022
c87a53d
fix broken link/update link (#2338) (#2343)
mergify[bot] Sep 21, 2022
773e22b
Fix ICAControllerKeeper (#2303) (#2329)
mergify[bot] Sep 21, 2022
4ae2834
Adding `paramsKeeper.Subspace(icahosttypes.SubModuleName)` (#2220) (#…
mergify[bot] Sep 21, 2022
466e428
fix: add nil checks for controller and host keeper services (backport…
mergify[bot] Sep 21, 2022
5f25ecd
Move client specific logic to SelfClient interface
liorzilp Nov 16, 2022
fbb8b30
Merge pull request #2 from dymensionxyz/liorzilp/01-client-agnostic
liorzilp Nov 16, 2022
68a2df9
Creating TestChainClientI and TestChainTendermint having the Tendermi…
liorzilp Nov 17, 2022
ea1aea0
Fixing all the places where tendermint logic was used from TestChain
liorzilp Nov 17, 2022
e168d15
Merge pull request #4 from dymensionxyz/liorzilp/02-multi-client-type…
liorzilp Nov 17, 2022
3a8e98b
Move ClientConfig logic to tendermint chain
liorzilp Nov 20, 2022
3035c5c
Merge pull request #8 from dymensionxyz/liorzilp/07-additions-light-c…
liorzilp Nov 20, 2022
11afc18
Make ConstructUpdateClientHeader TestChainClientI method instead of s…
liorzilp Nov 20, 2022
6a5cb1b
Merge pull request #9 from dymensionxyz/liorzilp/07-additions-light-c…
liorzilp Nov 20, 2022
c29ed84
Merge branch 'liorzilp/07-additions-light-client-agnostic' of github.…
liorzilp Nov 20, 2022
309d690
fix lint warning
liorzilp Nov 21, 2022
6eb5038
Merge pull request #10 from dymensionxyz/liorzilp/07-additions-light-…
liorzilp Nov 21, 2022
3e3d47b
Merge branch 'liorzilp/07-additions-light-client-agnostic' of github.…
liorzilp Nov 21, 2022
ce25fe2
Copy 07-tendermint, rename and create 01-dymint
liorzilp Nov 21, 2022
99cf0cb
move ConstructUpdateClientHeader to common testChain code using a new…
liorzilp Nov 22, 2022
f8b752d
fix CreateClient to use the correct ClientConfig
liorzilp Nov 22, 2022
95151b9
07-tendermint assumes the other chain is also tendermint - fix it
liorzilp Nov 22, 2022
40169cc
Merge pull request #11 from dymensionxyz/liorzilp/07-additions-light-…
liorzilp Nov 22, 2022
e62908e
Merge branch 'liorzilp/07-additions-light-client-agnostic' of github.…
liorzilp Nov 22, 2022
07debb3
Support dymint<->tendermint IBC tests
liorzilp Nov 22, 2022
48327aa
Merge pull request #12 from dymensionxyz/liorzilp/05-dymint-client
liorzilp Nov 22, 2022
2220c9a
* remove validator set checking
liorzilp Nov 23, 2022
7fe3911
enhance Validate Commit to check the commit and the proposer signatur…
liorzilp Nov 23, 2022
70780bb
ignore ConsensusState->NextValidatorsHash
liorzilp Nov 23, 2022
a67ae1b
clean TrustLevel and UnbondingPeriod leftovers
liorzilp Nov 23, 2022
4799d14
ignore Header->TrustedValidators
liorzilp Nov 23, 2022
d4c02a3
Merge pull request #13 from dymensionxyz/liorzilp/06-update-state
liorzilp Nov 23, 2022
8c8d008
Update README.md
liorzilp Nov 24, 2022
8dc49fc
Update README.md
liorzilp Nov 24, 2022
e03dadc
add clientHooks
liorzilp Nov 28, 2022
d6b464a
Merge pull request #15 from dymensionxyz/liorzilp/14-client-hooks
liorzilp Nov 29, 2022
86c9ec9
remove redundant test cases
liorzilp Nov 29, 2022
efd1f9f
Merge pull request #17 from dymensionxyz/liorzilp/16-fix-misbehaviour…
liorzilp Nov 29, 2022
33f4824
add GetChainID
liorzilp Nov 30, 2022
78f09f4
Merge pull request #19 from dymensionxyz/liorzilp/18-get-chain-id
liorzilp Nov 30, 2022
ba5bed4
add GetLastHeader
liorzilp Dec 6, 2022
1e5a27e
fix missing EndBlock() / remove BeginBlock()
liorzilp Dec 6, 2022
2bdb22e
Merge pull request #21 from dymensionxyz/liorzilp/20-test-chain-changes
liorzilp Dec 6, 2022
06ff366
support dymint signatures verification + add dymint to the default-al…
ItzhakBokris Dec 21, 2022
bcb8546
Liorzilp/25 upgrade v3.4.0 (#26)
liorzilp Jan 4, 2023
1870174
added backward compatible interface (#27)
mtsitrin Jan 5, 2023
e315bbf
feat: message interceptor (#29)
liorzilp Mar 12, 2023
1c5a349
Merge branch 'main-dym' into support_5.1.0
mtsitrin May 2, 2023
408ecdc
compiles. removed in the meanwhile all related to self client. will b…
mtsitrin May 2, 2023
e157265
running keeper with Dymint light client
mtsitrin May 3, 2023
7eecb10
cleanup after comparing with origin/v5.1.0
mtsitrin May 3, 2023
37af5a3
wrapped 02-client keeper to an interface. added core NewKeeperWithDymint
mtsitrin May 3, 2023
2b6ccef
added dymint keepers
mtsitrin May 3, 2023
657cfa8
original tests compiles and run
mtsitrin May 3, 2023
2a4f330
Trying to make dymint tests work. WIP
mtsitrin May 3, 2023
97171e2
fixed linter
mtsitrin May 11, 2023
483b0ed
gofumpt
mtsitrin May 11, 2023
ff99454
fixed goimports
mtsitrin May 11, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ write a little note why.

- [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules/10-structure.md).
- [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules/11-structure.md).
- [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing)
- [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
- [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ The Inter-Blockchain Communication protocol (IBC) allows blockchains to talk to
3.1 [ICS 07 Tendermint](https://github.com/cosmos/ibc-go/tree/main/modules/light-clients/07-tendermint)

3.2 [ICS 06 Solo Machine](https://github.com/cosmos/ibc-go/tree/main/modules/light-clients/06-solomachine)

3.3 [DIP 01 Dymint](https://github.com/dymensionxyz/ibc-go/tree/main-dym/modules/light-clients/01-dymint)

Note: The localhost client is currently non-functional.

Expand Down
325 changes: 325 additions & 0 deletions docs/client/swagger-ui/swagger.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5466,6 +5466,331 @@ paths:
format: boolean
tags:
- Query
'/ibc/core/client/v1/consensus_states/{client_id}/heights':
get:
summary: >-
ConsensusStateHeights queries the height of every consensus states
associated with a given client.
operationId: ConsensusStateHeights
responses:
'200':
description: A successful response.
schema:
type: object
properties:
consensus_state_heights:
type: array
items:
type: object
properties:
revision_number:
type: string
format: uint64
title: the revision that the client is currently on
revision_height:
type: string
format: uint64
title: the height within the given revision
description: >-
Normally the RevisionHeight is incremented at each height
while keeping

RevisionNumber the same. However some consensus algorithms
may choose to

reset the height in certain conditions e.g. hard forks,
state-machine

breaking changes In these cases, the RevisionNumber is
incremented so that

height continues to be monitonically increasing even as the
RevisionHeight

gets reset
title: >-
Height is a monotonically increasing data type

that can be compared against another Height for the purposes
of updating and

freezing clients
title: consensus state heights
pagination:
title: pagination response
type: object
properties:
next_key:
type: string
format: byte
title: |-
next_key is the key to be passed to PageRequest.key to
query the next page most efficiently
total:
type: string
format: uint64
title: >-
total is total number of results available if
PageRequest.count_total

was set, its value is undefined otherwise
description: >-
PageResponse is to be embedded in gRPC response messages where
the

corresponding request message has used PageRequest.

message SomeResponse {
repeated Bar results = 1;
PageResponse page = 2;
}
title: |-
QueryConsensusStateHeightsResponse is the response type for the
Query/ConsensusStateHeights RPC method
default:
description: An unexpected error response
schema:
type: object
properties:
error:
type: string
code:
type: integer
format: int32
message:
type: string
details:
type: array
items:
type: object
properties:
type_url:
type: string
description: >-
A URL/resource name that uniquely identifies the type of
the serialized

protocol buffer message. This string must contain at
least

one "/" character. The last segment of the URL's path
must represent

the fully qualified name of the type (as in

`path/google.protobuf.Duration`). The name should be in
a canonical form

(e.g., leading "." is not accepted).


In practice, teams usually precompile into the binary
all types that they

expect it to use in the context of Any. However, for
URLs which use the

scheme `http`, `https`, or no scheme, one can optionally
set up a type

server that maps type URLs to message definitions as
follows:


* If no scheme is provided, `https` is assumed.

* An HTTP GET on the URL must yield a
[google.protobuf.Type][]
value in binary format, or produce an error.
* Applications are allowed to cache lookup results based
on the
URL, or have them precompiled into a binary to avoid any
lookup. Therefore, binary compatibility needs to be preserved
on changes to types. (Use versioned type names to manage
breaking changes.)

Note: this functionality is not currently available in
the official

protobuf release, and it is not used for type URLs
beginning with

type.googleapis.com.


Schemes other than `http`, `https` (or the empty scheme)
might be

used with implementation specific semantics.
value:
type: string
format: byte
description: >-
Must be a valid serialized protocol buffer of the above
specified type.
description: >-
`Any` contains an arbitrary serialized protocol buffer
message along with a

URL that describes the type of the serialized message.


Protobuf library provides support to pack/unpack Any values
in the form

of utility functions or additional generated methods of the
Any type.


Example 1: Pack and unpack a message in C++.

Foo foo = ...;
Any any;
any.PackFrom(foo);
...
if (any.UnpackTo(&foo)) {
...
}

Example 2: Pack and unpack a message in Java.

Foo foo = ...;
Any any = Any.pack(foo);
...
if (any.is(Foo.class)) {
foo = any.unpack(Foo.class);
}

Example 3: Pack and unpack a message in Python.

foo = Foo(...)
any = Any()
any.Pack(foo)
...
if any.Is(Foo.DESCRIPTOR):
any.Unpack(foo)
...

Example 4: Pack and unpack a message in Go

foo := &pb.Foo{...}
any, err := ptypes.MarshalAny(foo)
...
foo := &pb.Foo{}
if err := ptypes.UnmarshalAny(any, foo); err != nil {
...
}

The pack methods provided by protobuf library will by
default use

'type.googleapis.com/full.type.name' as the type URL and the
unpack

methods only use the fully qualified type name after the
last '/'

in the type URL, for example "foo.bar.com/x/y.z" will yield
type

name "y.z".



JSON

====

The JSON representation of an `Any` value uses the regular

representation of the deserialized, embedded message, with
an

additional field `@type` which contains the type URL.
Example:

package google.profile;
message Person {
string first_name = 1;
string last_name = 2;
}

{
"@type": "type.googleapis.com/google.profile.Person",
"firstName": <string>,
"lastName": <string>
}

If the embedded message type is well-known and has a custom
JSON

representation, that representation will be embedded adding
a field

`value` which holds the custom JSON in addition to the
`@type`

field. Example (for message [google.protobuf.Duration][]):

{
"@type": "type.googleapis.com/google.protobuf.Duration",
"value": "1.212s"
}
parameters:
- name: client_id
description: client identifier
in: path
required: true
type: string
- name: pagination.key
description: |-
key is a value returned in PageResponse.next_key to begin
querying the next page most efficiently. Only one of offset or key
should be set.
in: query
required: false
type: string
format: byte
- name: pagination.offset
description: >-
offset is a numeric offset that can be used when key is unavailable.

It is less efficient than using key. Only one of offset or key
should

be set.
in: query
required: false
type: string
format: uint64
- name: pagination.limit
description: >-
limit is the total number of results to be returned in the result
page.

If left empty it will default to a value to be set by each app.
in: query
required: false
type: string
format: uint64
- name: pagination.count_total
description: >-
count_total is set to true to indicate that the result set should
include

a count of the total number of items available for pagination in
UIs.

count_total is only respected when offset is used. It is ignored
when key

is set.
in: query
required: false
type: boolean
format: boolean
tags:
- Query
'/ibc/core/client/v1/consensus_states/{client_id}/revision/{revision_number}/height/{revision_height}':
get:
summary: >-
Expand Down
4 changes: 2 additions & 2 deletions docs/ibc/integration.md
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ func NewApp(...args) *App {

### Module Managers

In order to use IBC, we need to add the new modules to the module `Manager` and to the `SimulationManager` in case your application supports [simulations](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules/13-simulator.md).
In order to use IBC, we need to add the new modules to the module `Manager` and to the `SimulationManager` in case your application supports [simulations](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules/14-simulator.md).

```go
// app.go
Expand Down Expand Up @@ -178,7 +178,7 @@ connection handhake.
The IBC module also has
[`BeginBlock`](https://github.com/cosmos/ibc-go/blob/main/modules/core/02-client/abci.go) logic as
well. This is optional as it is only required if your application uses the [localhost
client](https://github.com/cosmos/ibc/blob/master/spec/client/ics-009-loopback-client) to connect two
client](https://github.com/cosmos/ibc/tree/main/spec/client/ics-009-loopback-cilent) to connect two
different modules from the same chain.

::: tip
Expand Down
Loading