Add a EmitTypeEvent function that doesn't add double quotes to string attributes #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwt
requested changes
Aug 21, 2024
utils/uevent/events.go
Outdated
Comment on lines
15
to
16
| // EmitTypedEvent takes a typed event and emits it | ||
| func EmitTypedEvent(ctx sdk.Context, tev proto.Message) error { |
There was a problem hiding this comment.
You can just call it EmitTyped since it's in uevent
There was a problem hiding this comment.
this follows the original naming in the sdk
There was a problem hiding this comment.
are you sure? this will mean renaming it all over the hub repo, and anywhere else where this method is used.
danwt
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that emitting such typed events that have complex attributes (slices, structs...) might look ugly.