Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update docs regarding connections and update related tests #258

Merged
merged 3 commits into from
Jan 9, 2025
Merged

update docs regarding connections and update related tests #258

merged 3 commits into from
Jan 9, 2025

Conversation

devkral
Copy link
Contributor

@devkral devkral commented Jan 8, 2025 •
edited
Loading

Changes:

  • improve connection docs
  • test harder that the not connected warnings are appropriate.
  • update tests which uses old style connections

@devkral
update connection docs
77fe3ed 
Changes:

- improve connection docs
- test harder that the not connected warnings are appropiate.
@devkral devkral marked this pull request as draft January 8, 2025 22:48
@devkral devkral changed the title update docs regarding connections update docs regarding and update tests Jan 8, 2025
@devkral devkral changed the title update docs regarding and update tests update docs regarding connections and update related tests Jan 8, 2025
@devkral devkral marked this pull request as ready for review January 8, 2025 23:04
@devkral devkral requested a review from tarsil January 8, 2025 23:04
@tarsil tarsil merged commit c236738 into main Jan 9, 2025
10 checks passed
@tarsil tarsil deleted the devkral/docs/update branch January 9, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarsil tarsil tarsil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devkral @tarsil