Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Params array: only promote first argument if it can be an array #267

Merged
merged 2 commits into from
Dec 1, 2022
Merged

Params array: only promote first argument if it can be an array #267

merged 2 commits into from
Dec 1, 2022

Conversation

metoule
Copy link
Contributor

@metoule metoule commented Nov 27, 2022

When trying to parse a params array, promoting the first argument only makes sense if it might be the full array.

Fixes #263

@metoule metoule merged commit ea1f4e5 into dynamicexpresso:master Dec 1, 2022
@metoule metoule deleted the fix_263 branch December 1, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davideicardi davideicardi davideicardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception "Incorrect number of arguments supplied" when params array has null in first parameter
2 participants
@metoule @davideicardi