Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw exception when trying to register a closed generic type. #268

Merged
merged 2 commits into from
Dec 1, 2022
Merged

Throw exception when trying to register a closed generic type. #268

merged 2 commits into from
Dec 1, 2022

Conversation

metoule
Copy link
Contributor

@metoule metoule commented Nov 27, 2022

This new exception will prevent users from trying to reference a closed generic type, and provide the proper type to register.

target.Reference(typeof(List<string>)); // throws 
target.Reference(typeof(List<>)); // doesn't throw

Fixes #264

@metoule metoule merged commit 86d57bd into dynamicexpresso:master Dec 1, 2022
@metoule metoule deleted the fix_264 branch December 1, 2022 12:41
@Vennotius Vennotius mentioned this pull request May 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davideicardi davideicardi davideicardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unknown identifier IDictionary
2 participants
@metoule @davideicardi